Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Andreas Färber
Nuohan, Am 21.05.2013 08:16, schrieb Jesse Larrew: On 05/20/2013 10:00 PM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. --- target-i386/arch_memory_mapping.c |2

Re: [Qemu-devel] [PATCH v1 1/1] qom/object: Don't poll cast cache for NULL objects

2013-05-21 Thread Andreas Färber
. The preceding check of the cast cache dereferences obj however causing a segfault. Fix by conditionalizing the cast cache logic on obj being non-null. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Otherwise, Reviewed-by: Andreas Färber afaer...@suse.de Andreas --- qom/object.c | 4

Re: [Qemu-devel] IDE disk FLUSH take more than 30 secs, the SUSE guest reports lost interrupt and the file system becomes read-only

2013-05-21 Thread Andreas Färber
Hi, Am 21.05.2013 09:12, schrieb Gonglei (Arei): In the case of physical hard disk's speed which processing IO (when grouping RAID) is very slow, I encountered a problem. I dd big file in SUSE virtual machine, the command is linux:/ # dd if=/dev/zero of=./info bs=1M count=5000;sync but

Re: [Qemu-devel] (Another) 1.4.1 - 1.5.0 migration failure

2013-05-21 Thread Andreas Färber
Hi, Am 21.05.2013 13:33, schrieb Nicholas Thomas: Migrating from: /opt/qemu-1.4.1/bin/qemu-system-x86_64 -M pc -watchdog i6300esb -watchdog-action reset [...] to: /opt/qemu-1.5.0/bin/qemu-system-x86_64 -M pc-i440fx-1.4 -watchdog i6300esb -watchdog-action reset [...] I get:

Re: [Qemu-devel] KVM call agenda for 2013-05-21

2013-05-21 Thread Andreas Färber
Am 21.05.2013 16:34, schrieb Juan Quintela: Anthony Liguori anth...@codemonkey.ws wrote: Maybe we could use a wiki page to setup a rolling agenda? I think this could be easier for everybody involved. Especially because you just look if there is anything to discuss? On the other hand, the

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Andreas Färber
Am 21.05.2013 14:05, schrieb Qiao Nuohan: On 05/21/2013 07:32 PM, Andreas Färber wrote: This patch is missing a Signed-off-by! Ha! I forgot it. If you can reply with one, I'd fix up the subject for you (it should indicate where you are fixing it) and queue it together with my CPU'ish

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-22 Thread Andreas Färber
Am 22.05.2013 03:25, schrieb Qiao Nuohan: On 05/22/2013 09:21 AM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-22 Thread Andreas Färber
Am 22.05.2013 14:50, schrieb Stefan Hajnoczi: Net queues support efficient receive disable. For example, tap's file descriptor will not be polled while its peer has receive disabled. This saves CPU cycles for needlessly copying and then dropping packets which the peer cannot receive.

[Qemu-devel] [PATCH qom-cpu 1/4] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-05-22 Thread Andreas Färber
The memory mapping API uses hwaddr, so use it in the struct, too. This avoids a header dependency on target_ulong type. Cc: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/sysemu/memory_mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Qemu-devel] [PATCH qom-cpu 0/4] memory_mapping: Clean up stubs

2013-05-22 Thread Andreas Färber
...@cn.fujitsu.com Cc: Jens Freimann jf...@linux.vnet.ibm.com Cc: Vincent Rabin ra...@rab.in Cc: Paolo Bonzini pbonz...@redhat.com Andreas Färber (4): memory_mapping: Use hwaddr type for MemoryMapping virt_addr field memory_mapping: Change cpu_get_memory_mapping() argument to CPUState memory_mapping

[Qemu-devel] [PATCH qom-cpu 3/4] memory_mapping: Change cpu_paging_enabled() argument to CPUState

2013-05-22 Thread Andreas Färber
Removes the last occurrence of CPUArchState from sysemu/memory_mapping.h. Signed-off-by: Andreas Färber afaer...@suse.de --- include/sysemu/memory_mapping.h | 2 +- memory_mapping.c | 2 +- target-i386/arch_memory_mapping.c | 7 +-- 3 files changed, 7 insertions(+), 4

[Qemu-devel] [PATCH qom-cpu 2/4] memory_mapping: Change cpu_get_memory_mapping() argument to CPUState

2013-05-22 Thread Andreas Färber
Eliminates an occurrence of CPUArchState from sysemu/memory_mapping.h. Signed-off-by: Andreas Färber afaer...@suse.de --- include/sysemu/memory_mapping.h | 2 +- memory_mapping.c | 2 +- target-i386/arch_memory_mapping.c | 5 - 3 files changed, 6 insertions(+), 3 deletions

[Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a

2013-05-22 Thread Andreas Färber
Allows us to drop CONFIG_NO_GET_MEMORY_MAPPING with its indirect dependency on CONFIG_HAVE_GET_MEMORY_MAPPING in Makefile.target. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 -- stubs/Makefile.objs | 1

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-22 Thread Andreas Färber
the place to add new values is more likely to differ between targets and becomes more secure to add to. So if we don't go for Paolo's string version, Reviewed-by: Andreas Färber afaer...@suse.de One thought that crossed my mind was whether to put [ and ] on lines of their own to aid adding before

Re: [Qemu-devel] [PATCH 3/9 v3] Move includes and struct definition to dump.h

2013-05-22 Thread Andreas Färber
Am 17.05.2013 05:24, schrieb Qiao Nuohan: Move includes and definition of struct DumpState into include/sysemu/dump.h. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 29 -

Re: [Qemu-devel] New targets (was: [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line)

2013-05-22 Thread Andreas Färber
Am 22.05.2013 16:28, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: More common is however that people start writing a new target and don't submit it yet (ahem!) while another target gets added, and the current form of rebreaking this block of enum values causes more

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Andreas Färber
Am 17.05.2013 05:24, schrieb Qiao Nuohan: Qiao Nuohan (9): Add API to manipulate dump_bitmap Add API to manipulate cache_data Move includes and struct definition to dump.h Add API to create header of vmcore Add API to create data of dump bitmap Add API to create page Add API

Re: [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG target VERSION 2

2013-05-23 Thread Andreas Färber
Hi, Am 23.05.2013 10:09, schrieb Claudio Fontana: This series implements preliminary support for the ARM aarch64 TCG target. [snip] Generally, please post patch series without --in-reply-to= and use --subject-prefix=PATCH v2 etc. plus a change log in the cover letter to distinguish

Re: [Qemu-devel] [PATCH 0/4] ARM aarch64 TCG target VERSION 2

2013-05-23 Thread Andreas Färber
Am 23.05.2013 14:50, schrieb Peter Maydell: On 23 May 2013 13:37, Andreas Färber afaer...@suse.de wrote: If Big Endian targets are not yet supported, should this rather be an RFC? Or is that just about some unimplemented opcodes? I'm happy for us to wait until an actual big-endian system

Re: [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable

2013-05-23 Thread Andreas Färber
Am 23.05.2013 08:58, schrieb liguang: before change: Bdebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x74 tdebugcon: write addr=0x val=0x69 idebugcon: write addr=0x val=0x6e ndebugcon: write addr=0x val=0x67

Re: [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print addr=0x0, val=0x0 bug when use DEBUG_DEBUGCON

2013-05-23 Thread Andreas Färber
Am 23.05.2013 08:58, schrieb liguang: when use DEBUG_DEBUGCON, screen spits: debugcon: write addr=0x val=0x00 Rdebugcon: write addr=0x val=0x00 udebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 idebugcon: write

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-24 Thread Andreas Färber
to X86CPU fields. However I am guessing that all these registers are accessed by TCG code via offsets from cpu_env - please verify that. If so, Reviewed-by: Andreas Färber afaer...@suse.de However, it would be nice if you could fix the \ alignment in patch 06/12 or in the cleanup patch 12/12. Regards

Re: [Qemu-devel] [PATCH] Remove unnecessary break statements

2013-05-24 Thread Andreas Färber
, continue, goto or throw statements are unnecessary. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Andreas Färber afaer...@suse.de Also removes a tab while at it. :) Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild

Re: [Qemu-devel] [PATCH 4/4] debugcon: use fprintf(stderr...) instead of printf

2013-05-24 Thread Andreas Färber
Am 24.05.2013 04:47, schrieb liguang: suggested by Andreas Färber afaer...@suse.de Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/char/debugcon.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c index 3b0637d

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:28, schrieb Michael Tokarev: 24.05.2013 06:47, liguang wrote: when enable DEBUG_DEBUGCON, there are some message printing bugs, so fix them. this patch-set based on previous 3 patches, http://comments.gmane.org/gmane.comp.emulators.qemu/212550

Re: [Qemu-devel] [PATCH (trivial)] don't run pkg-config for features explicitly disabled

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:19, schrieb Michael Tokarev: We test pkg-config for curses and curl even if those are explicitly disabled. Move these tests inside `if $feature != no' sections. Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-25 Thread Andreas Färber
), and it should actually be different from plain --libs. $pkg_config should already contain --static for static builds, so I see nothing wrong with this patch, Reviewed-by: Andreas Färber afaer...@suse.de but maybe I'm missing something? One thing to note is that in an unfortunate layering violation

Re: [Qemu-devel] [libvirt] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

2013-05-25 Thread Andreas Färber
Am 25.05.2013 11:18, schrieb Peter Maydell: On 24 May 2013 22:38, Eric Blake ebl...@redhat.com wrote: I think knowing the architecture (such as x86 vs. pseries ppc) is used by libvirt to know what default devices the board supports (for example, whether usb is present by default). ...but

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-25 Thread Andreas Färber
Hi, Am 24.05.2013 21:24, schrieb Lior Vernia: I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. Before we start going into technical details, what are you trying to achieve on a high level and how did you try to do it? Are you using

Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

2013-05-25 Thread Andreas Färber
Am 25.05.2013 01:01, schrieb Brad Smith: Remove the OSS support for OpenBSD. The OSS API has not been usable for quite some time. Signed-off-by: Brad Smith b...@comstyle.com Reviewed-by: Andreas Färber afaer...@suse.de CC'ing qemu-trivial. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr

Re: [Qemu-devel] Potential to accelerate QEMU for specific architectures

2013-05-26 Thread Andreas Färber
Am 26.05.2013 07:40, schrieb Lior Vernia: On Sat, May 25, 2013 at 10:06 PM, Andreas Färber afaer...@suse.de wrote: Am 24.05.2013 21:24, schrieb Lior Vernia: I am running x86 applications on an ARM device using QEMU, and found it too slow for my needs. Before we start going into technical

[Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-26 Thread Andreas Färber
c689b4f1bac352dcfd6ecb9a1d45337de0f1de67) [AF: Use error_set() instead of error_setg*()] Signed-off-by: Andreas Färber afaer...@suse.de --- qemu-ga.c| 2 +- qga/commands-posix.c | 117 +-- 2 files changed, 115 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PATCH 12/15] s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62

2013-05-26 Thread Andreas Färber
Am 24.05.2013 19:03, schrieb Paolo Bonzini: With the next patch, the memory API will complain if the TARGET_PHYS_ADDR_SPACE_BITS gets dangerously close to an overflow. s390x can handle up to 64 bit of physical address space from its page tables, but we never use that much. Just decrease the

Re: [Qemu-devel] FPU x86 instructions error

2013-05-26 Thread Andreas Färber
Hi, Am 24.05.2013 23:44, schrieb Paolo Bonzini: Il 24/05/2013 23:39, Clemens Kolbitsch ha scritto: we recently had an issue with running a program using FPU instructions to obtain the current EIP (basically a weird way of call 0; pop eax) that was not working on QEMU (with TCG). Looking at

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-26 Thread Andreas Färber
Am 24.05.2013 13:37, schrieb Andreas Färber: Am 23.04.2013 10:16, schrieb liguang: remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson r...@twiddle.net Li Guang (12) target-i386/helper: remove EAX macro target-i386/helper: remove EBX

Re: [Qemu-devel] IDE disk FLUSH take more than 30 secs, the SUSE guest reports lost interrupt and the file system becomes read-only

2013-05-26 Thread Andreas Färber
Am 21.05.2013 09:12, schrieb Gonglei (Arei): Through analysis, I found that because the system call the fdatasync command in the Qemu over 30s, after the Guest's kernel thread detects the io transferation is timeout, went to check IDE disk state. But the IDE disk status is 0x50, rather

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-26 Thread Andreas Färber
Am 27.05.2013 02:11, schrieb Laszlo Ersek: On 05/26/13 15:34, Andreas Färber wrote: From: Laszlo Ersek ler...@redhat.com The qemu guest agent creates a bunch of files with insecure permissions when started in daemon mode. For example: -rw-rw-rw- 1 root root /var/log/qemu-ga.log -rw-rw

Re: [Qemu-devel] [PATCH 12/15] s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62

2013-05-27 Thread Andreas Färber
Am 27.05.2013 09:28, schrieb Paolo Bonzini: Il 26/05/2013 23:08, Christian Borntraeger ha scritto: On 26/05/13 21:07, Paolo Bonzini wrote: Il 26/05/2013 16:14, Andreas Färber ha scritto: With the next patch, the memory API will complain if the TARGET_PHYS_ADDR_SPACE_BITS gets dangerously

Re: [Qemu-devel] Selecting device variant types based on bdrv size

2013-05-27 Thread Andreas Färber
Hi, Am 27.05.2013 09:50, schrieb Peter Crosthwaite: I have a bit of a chicken and egg problem trying to refactor Jans AT24 I2C EEPROM model. I'm trying to migrate static class properties up to the class level rather than down on the device property level (as we did for EHCI in the

Re: [Qemu-devel] [PATCH qom-cpu 0/3] Conroe/Penryn/Nehalem CPUID family/level fixes

2013-05-27 Thread Andreas Färber
Am 27.05.2013 22:23, schrieb Eduardo Habkost: This series changes the CPUID family and level fields of the Conroe, Penryn, and Nehalem CPU models. Testing: those model/level values have been in use on Red Hat Enterprise Linux since version 6.0 (released in 2010). The fix wasn't submitted

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-28 Thread Andreas Färber
Am 28.05.2013 04:11, schrieb li guang: 在 2013-05-26日的 17:55 +0200,Andreas Färber写道: Am 24.05.2013 13:37, schrieb Andreas Färber: Am 23.04.2013 10:16, schrieb liguang: remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF as suggested by Richard Henderson r...@twiddle.net Li Guang

[Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Andreas Färber
this by setting BUSY_STAT, so that the guest is made aware we are in the middle of an operation and no ATA commands are attempted to be processed concurrently. Addresses BNC#637297. Suggested-by: Gonglei (Arei) arei.gong...@huawei.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/core.c

Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros

2013-05-28 Thread Andreas Färber
ESI macro target-i386/helper: remove EDI macro target-i386/helper: remove EIP macro target-i386/helper: remove DF macro target-i386/helper: remove redundant env-eip assignment target-i386: fix over 80 chars warnings Reviewed-by: Andreas Färber afaer

Re: [Qemu-devel] [PATCH] ide: Set BSY bit during FLUSH

2013-05-28 Thread Andreas Färber
Am 28.05.2013 10:27, schrieb Kevin Wolf: Am 28.05.2013 um 10:18 hat Andreas Färber geschrieben: The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11

Re: [Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc, microblaze softmmu targets

2013-05-28 Thread Andreas Färber
Am 24.05.2013 17:26, schrieb Peter Maydell: A number of our softmmu targets (PPC, ARM, Microblaze) now more or less require flattened device tree support for various board models to work correctly. Make libfdt mandatory if the target list includes these, rather than building unhelpful

Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile

2013-05-28 Thread Andreas Färber
Am 28.05.2013 10:54, schrieb Paolo Bonzini: Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto: The symlink to asm platform linux headers is made in the build tree by the configure script but gcc is not told to look for them there. The patch fixes this. Signed-off-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a

2013-05-28 Thread Andreas Färber
Am 23.05.2013 12:08, schrieb Paolo Bonzini: Il 22/05/2013 15:09, Andreas Färber ha scritto: Allows us to drop CONFIG_NO_GET_MEMORY_MAPPING with its indirect dependency on CONFIG_HAVE_GET_MEMORY_MAPPING in Makefile.target. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target

Re: [Qemu-devel] [Xen-devel] target-i386: Introduce ICC bus/device/bridge

2013-05-28 Thread Andreas Färber
Am 28.05.2013 13:49, schrieb Stefano Stabellini: On Mon, 27 May 2013, Igor Mammedov wrote: On Fri, 24 May 2013 08:56:14 -0600 jacek burghardt jaceksburgha...@gmail.com wrote: I wonder if anyone has patch that allows to tlak to icc bus introduced in qemu upstream ?

[Qemu-devel] [PATCH qom-cpu v2 2/7] dump: Move stubs into libqemustub.a

2013-05-28 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_HAVE_CORE_DUMP. Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c = stubs/dump.c | 0

[Qemu-devel] [PATCH qom-cpu v2 3/7] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-05-28 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 -- memory_mapping.c | 2 +- qom/cpu.c | 13 + target

[Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Fix mask of pte index in memory mapping

2013-05-28 Thread Andreas Färber
...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/arch_memory_mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c index 844893f..a2eb7e7 100644 --- a/target-i386

[Qemu-devel] [PATCH qom-cpu v2 5/7] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-05-28 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c | 2 +- qom/cpu.c | 14 ++ target

[Qemu-devel] [PATCH qom-cpu v2 7/7] dump: Unconditionally compile

2013-05-28 Thread Andreas Färber
CONFIG_HAVE_CORE_DUMP. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 +- configure | 4 hmp-commands.hx | 2 -- stubs/dump.c| 8 4 files changed, 1 insertion(+), 15 deletions(-) diff --git a/Makefile.target b/Makefile.target index f9e1d89..b0be124 100644

[Qemu-devel] [PATCH qom-cpu v2 0/7] dump: Build cleanups redone

2013-05-28 Thread Andreas Färber
...@cn.fujitsu.com Cc: Qiao Nuohan qiaonuo...@cn.fujitsu.com Cc: Jens Freimann jf...@linux.vnet.ibm.com Cc: Vincent Rabin ra...@rab.in Cc: Paolo Bonzini pbonz...@redhat.com Andreas Färber (6): dump: Move stubs into libqemustub.a cpu: Turn cpu_paging_enabled() into a CPUState hook memory_mapping: Move

[Qemu-devel] [PATCH qom-cpu v2 4/7] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

2013-05-28 Thread Andreas Färber
This will avoid issues with hwaddr and ram_addr_t when including sysemu/memory_mapping.h for CONFIG_USER_ONLY. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qemu/typedefs.h | 2 ++ include/sysemu/memory_mapping.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions

[Qemu-devel] [PATCH qom-cpu v2 6/7] memory_mapping: Drop qemu_get_memory_mapping() stub

2013-05-28 Thread Andreas Färber
mapping also don't implement dump support, we will not reach this code today and can worry about changing cpu_paging_enabled() default when the need arises. This allows us to drop CONFIG_HAVE_GET_MEMORY_SUPPORT and thereby keep configure out of the picture. Signed-off-by: Andreas Färber afaer

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-28 Thread Andreas Färber
Am 28.05.2013 18:46, schrieb Paolo Bonzini: Il 28/05/2013 18:34, Bandan Das ha scritto: Eduardo Habkost ehabk...@redhat.com writes: On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: Il 27/05/2013 14:09, Eduardo Habkost ha scritto: On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo

Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8

2013-05-28 Thread Andreas Färber
Am 28.05.2013 19:01, schrieb Anthony Liguori: Peter Maydell peter.mayd...@linaro.org writes: Ping again! This patchset has now been on the list for eleven weeks without any review. Objective C is a foreign language. For that reason I've been applying our C Coding Style for indentation and

Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8

2013-05-28 Thread Andreas Färber
Am 22.04.2013 22:29, schrieb Peter Maydell: These patches fix various compiler and runtime warnings QEMU provokes on MacOSX 10.8. The first two fix a leak and some deprecated functions which cause warnings in the system log when QEMU runs. The second two avoid some functions which cause

[Qemu-devel] [PULL 0/4] Cocoa patch queue 2013-05-29

2013-05-28 Thread Andreas Färber
Hello, This is the current Cocoa queue. Please pull. It contains warning fixes for Mac OS X v10.8 and drops support for v10.2 and earlier. Cc: Peter Maydell peter.mayd...@linaro.org The following changes since commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29: Remove Sun4c, Sun4d and a few

[Qemu-devel] [PULL 4/4] cocoa: Avoid deprecated NSOpenPanel beginSheetForDirectory

2013-05-28 Thread Andreas Färber
. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber andreas.faer...@web.de --- ui/cocoa.m | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index bb59511..be49179 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -35,6

[Qemu-devel] [PULL 1/4] cocoa: Fix leaks of NSScreen and NSConcreteMapTable

2013-05-28 Thread Andreas Färber
-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber andreas.faer...@web.de --- ui/cocoa.m | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 1971d9c..5d7a1e0 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -960,6 +960,8 @@ int main

[Qemu-devel] [PULL 3/4] cocoa: Avoid deprecated NSOpenPanel filename method

2013-05-28 Thread Andreas Färber
From: Peter Maydell peter.mayd...@linaro.org Avoid the NSOpenPanel filename method (deprecated in MacOSX 10.6) in favour of using the URL method and extracting the path from the resulting NSUrl object. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber

[Qemu-devel] [PULL 2/4] cocoa: Avoid deprecated CPS* functions

2013-05-28 Thread Andreas Färber
to a graphical app with menubar and Dock icon, which is TransformProcessType. (This function came in with MacOSX 10.3, so there's no need to retain the old method as we don't support anything earlier than 10.3 anyway.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH

2013-05-29 Thread Andreas Färber
Am 29.05.2013 13:34, schrieb Kevin Wolf: From: Andreas Färber afaer...@suse.de The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest

Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine-init

2013-05-29 Thread Andreas Färber
now cope with a machine without an emulated CPU. This fix should be backported to QEMU 1.5. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: imamm...@redhat.com CC: qemu-sta...@nongnu.org Change looks okay, Reviewed-by: Andreas Färber afaer...@suse.de

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Andreas Färber
Am 30.05.2013 15:16, schrieb Luiz Capitulino: On Thu, 30 May 2013 15:16:18 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/30/13 14:59, Luiz Capitulino wrote: On Tue, 28 May 2013 14:19:22 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: The code used to walk IA-32e page-tables, and

Re: [Qemu-devel] [PATCH] xen: start PCI hole at 0xe0000000 (same as pc_init1 and qemu-xen-traditional)

2013-05-30 Thread Andreas Färber
Am 30.05.2013 15:20, schrieb Stefano Stabellini: We are currently setting the PCI hole to start at HVM_BELOW_4G_RAM_END, that is 0xf000. Start the PCI hole at 0xe000 instead, that is the same value used by pc_init1 and qemu-xen-traditional. This fixes a bug with device assignment of

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Andreas Färber
Am 30.05.2013 16:14, schrieb Luiz Capitulino: On Thu, 30 May 2013 16:10:28 +0200 Andreas Färber afaer...@suse.de wrote: Am 30.05.2013 15:16, schrieb Luiz Capitulino: On Thu, 30 May 2013 15:16:18 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/30/13 14:59, Luiz Capitulino wrote: On Tue

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Andreas Färber
51:12). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de But please add a target-i386: prefix when queuing it. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB

[Qemu-devel] [PATCH qom-cpu v3 1/9] dump: Move stubs into libqemustub.a

2013-05-30 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_HAVE_CORE_DUMP. Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c = stubs/dump.c | 0

[Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-05-30 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c | 2 +- qom/cpu.c | 14 ++ target

[Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-30 Thread Andreas Färber
...@cn.fujitsu.com Cc: Qiao Nuohan qiaonuo...@cn.fujitsu.com Cc: Jens Freimann jf...@linux.vnet.ibm.com Cc: Vincent Rabin ra...@rab.in Cc: Paolo Bonzini pbonz...@redhat.com Cc: Luiz Capitulino lcapitul...@redhat.com Andreas Färber (7): dump: Move stubs into libqemustub.a cpu: Turn

[Qemu-devel] [PATCH qom-cpu v3 7/9] memory_mapping: Drop qemu_get_memory_mapping() stub

2013-05-30 Thread Andreas Färber
mapping also don't implement dump support, we will not reach this code today and can worry about changing cpu_paging_enabled() default when the need arises. This allows us to drop CONFIG_HAVE_GET_MEMORY_SUPPORT. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 4

[Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-05-30 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 -- memory_mapping.c | 2 +- qom/cpu.c | 13 + target

[Qemu-devel] [PATCH qom-cpu v3 5/9] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

2013-05-30 Thread Andreas Färber
This will avoid issues with hwaddr and ram_addr_t when including sysemu/memory_mapping.h for CONFIG_USER_ONLY. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qemu/typedefs.h | 2 ++ include/sysemu/memory_mapping.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions

[Qemu-devel] [PATCH qom-cpu v3 3/9] target-i386: walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Andreas Färber
). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/arch_memory_mapping.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target-i386/arch_memory_mapping.c b

[Qemu-devel] [PATCH qom-cpu v3 9/9] memory_mapping: Change qemu_get_guest_memory_mapping() semantics

2013-05-30 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- memory_mapping.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/memory_mapping.c b/memory_mapping.c index 481530a..55ac2b8 100644 --- a/memory_mapping.c +++ b/memory_mapping.c

[Qemu-devel] [PATCH qom-cpu v3 8/9] dump: Unconditionally compile

2013-05-30 Thread Andreas Färber
CONFIG_HAVE_CORE_DUMP and leave configure completely out of the picture for target CPU features. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 +- configure | 4 hmp-commands.hx | 2 -- stubs/dump.c| 8 4 files changed, 1 insertion(+), 15 deletions(-) diff

[Qemu-devel] [PATCH qom-cpu v3 2/9] target-i386: Fix mask of pte index in memory mapping

2013-05-30 Thread Andreas Färber
...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/arch_memory_mapping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c index 844893f..a2eb7e7 100644 --- a/target-i386

Re: [Qemu-devel] [PATCH] target-i386: pc: fix crash when attempting hotplug CPU with negative ID

2013-05-30 Thread Andreas Färber
Am 30.05.2013 17:09, schrieb Igor Mammedov: QMP command { 'execute': 'cpu-add', 'arguments': { 'id': -1 }} may cause QEMU SIGSEGV at: piix4_cpu_hotplug_req () ... g-sts[cpu_id / 8] |= (1 (cpu_id % 8)); ... Since for PC in current implementation id should be in range

Re: [Qemu-devel] [PATCH 1/2] dec.c - move to pci-bridge

2013-05-30 Thread Andreas Färber
Am 30.05.2013 11:30, schrieb Michael S. Tsirkin: Looks like dec.c is in pci-host by mistake. Moving it over to pci-bridge. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-bridge/Makefile.objs | 2 + hw/pci-bridge/dec.c | 156

Re: [Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/

2013-05-30 Thread Andreas Färber
Acked-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH v2 4/5] pc: add 1.6 compat type

2013-05-30 Thread Andreas Färber
Am 30.05.2013 13:07, schrieb Michael S. Tsirkin: Identical to 1.5 ATM, but changes will accumulate. Signed-off-by: Michael S. Tsirkin m...@redhat.com You did notice that Eduardo had a similar patch yesterday or so? Yours does not handle q35 by comparison. --- hw/i386/pc_piix.c | 13

Re: [Qemu-devel] [PATCH qom-cpu 0/3] Conroe/Penryn/Nehalem CPUID family/level fixes

2013-05-30 Thread Andreas Färber
Am 28.05.2013 11:31, schrieb Igor Mammedov: On Mon, 27 May 2013 17:23:52 -0300 Eduardo Habkost ehabk...@redhat.com wrote: This series changes the CPUID family and level fields of the Conroe, Penryn, and Nehalem CPU models. Testing: those model/level values have been in use on Red Hat

Re: [Qemu-devel] [PATCH 1/2] xen: remove xen_vcpu_init

2013-05-30 Thread Andreas Färber
it manually here. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/i386/pc_piix.c |1 - xen-all.c | 23 --- 2 files changed, 0 insertions(+), 24 deletions(-) Reviewed-by: Andreas Färber afaer...@suse.de and I've queued a copy on qom

Re: [Qemu-devel] [PATCH] s390/ipl: Fix spurious errors in virtio

2013-05-31 Thread Andreas Färber
and friends, especially on reboot. Lets zero out the relevant fields. To activate the patch we need to rebuild s390-ccw.img as well. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Tested-by: Andreas Färber afaer...@suse.de Indeed no such errors any more, but I'm still seeing

Re: [Qemu-devel] [PATCH 06/22] memory: dispatch unassigned accesses based on .valid.accepts

2013-06-03 Thread Andreas Färber
Am 03.06.2013 09:31, schrieb Paolo Bonzini: Il 01/06/2013 17:28, Blue Swirl ha scritto: This means that memory.c is getting knowledge about CPU types and it becomes more specific to current target. I think memory.c should be generic and target agnostic (maybe one day compiled just once) with

Re: [Qemu-devel] [PATCH v1 2/3] memory: as_update_topology_pass: Improve comments

2013-06-04 Thread Andreas Färber
Am 03.06.2013 07:32, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com These comments we're a little difficult to read. First one had While we're picky: were - Paolo can you fix up in your queue? Andreas incorrect parenthesis. The part about

Re: [Qemu-devel] [PATCH v2] gtk: don't use g_object_unref on GdkCursor

2013-06-04 Thread Andreas Färber
Am 03.06.2013 23:14, schrieb Anthony Liguori: It's not a GObject. Cc: Gerd Hoffman kra...@redhat.com Reported-by: Michael Tokarev m...@tls.msk.ru Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- v1 - v2 - Fix summary to agree with code (Peter) --- ui/gtk.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH] target-i386: cpu: fix potential buffer overrun in get_register_name_32()

2013-06-04 Thread Andreas Färber
Am 03.06.2013 18:23, schrieb Igor Mammedov: spotted by Coverity, x86_reg_info_32[] is CPU_NB_REGS32 elements long, so accessing x86_reg_info_32[CPU_NB_REGS32] will be one element off array. Signed-off-by: Igor Mammedov imamm...@redhat.com --- target-i386/cpu.c |2 +- 1 files changed,

Re: [Qemu-devel] [PATCH 00/13 v2] pseries: savevm / migration support

2013-06-04 Thread Andreas Färber
Am 04.06.2013 14:20, schrieb Alexey Kardashevskiy: I still have to learn how to force git not to overwrite the original commit author :-/ Is there any way to tell the original creator in the commit message so it could live in a git forever and survive commit changes? To fix it up: git

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-06-04 Thread Andreas Färber
Anthony, Am 31.05.2013 20:48, schrieb Anthony Liguori: Applied. Thanks. I don't see this applied, neither in qemu-stable-1.1.git nor in qemu.git stable-1.1 branch? Do we have an active maintainer for 1.1 or 1.3? Unfortunately qemu.git MAINTAINERS has not been updated with stable branches and

Re: [Qemu-devel] [PATCH 0/2] tcg: Remove redundant tcg_target_init checks

2013-06-04 Thread Andreas Färber
redundant tcg_target_init checks Reviewed-by: Andreas Färber afaer...@suse.de Andreas include/exec/cpu-defs.h | 2 +- tcg/arm/tcg-target.c| 6 -- tcg/i386/tcg-target.c | 6 -- tcg/s390/tcg-target.c | 7 --- 4 files changed, 1 insertion(+), 20 deletions(-) -- SUSE

Re: [Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-04 Thread Andreas Färber
Hi, Am 04.06.2013 18:22, schrieb Jesse Larrew: Virtio devices are initialized prior to plugging them into a bus. However, other initializations (such as host_features) don't occur until after the device is plugged into the bus. If a device needs to modify it's configuration based on

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize time, and memory_region_destroy at instance_finalize time. The general idea looks good. Could you please

Re: [Qemu-devel] [PATCH 1/2] Add Linux libnuma detection

2013-06-05 Thread Andreas Färber
Am 05.06.2013 05:58, schrieb Wanlong Gao: Add detection of libnuma (mostly contained in the numactl package) to the configure script. Currently this is Linux only, but can be extended later should the need for other interfaces come up. Can be enabled or disabled on the command line, default is

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Andreas Färber
Am 05.06.2013 12:28, schrieb Michael Tokarev: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all PCI devices (the sole to support hotplug _and_ use MemoryRegions) to do memory_region_del_subregion at unrealize

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:06, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote: Am 05.06.2013 13:10, schrieb Michael S. Tsirkin: On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: Am 04.06.2013 20:51, schrieb Paolo Bonzini: This series changes all

  1   2   3   4   5   6   7   8   9   10   >