Re: [Qemu PATCH v2 9/9] hw/mem/cxl_type3: Add dpa range validation for accesses to dc regions

2023-08-30 Thread Jørgen Hansen
On 7/25/23 20:39, Fan Ni wrote: > From: Fan Ni > > Not all dpa range in the dc regions is valid to access until an extent > covering the range has been added. Add a bitmap for each region to > record whether a dc block in the region has been backed by dc extent. > For the bitmap, a bit in the

Re: [Qemu PATCH v2 6/9] hw/mem/cxl_type3: Add DC extent list representative and get DC extent list mailbox support

2023-09-08 Thread Jørgen Hansen
On 7/25/23 20:39, Fan Ni wrote: > From: Fan Ni > > Add dynamic capacity extent list representative to the definition of > CXLType3Dev and add get DC extent list mailbox command per > CXL.spec.3.0:.8.2.9.8.9.2. > > Signed-off-by: Fan Ni > --- > hw/cxl/cxl-mailbox-utils.c | 71

Re: [Qemu PATCH v2 7/9] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2023-09-08 Thread Jørgen Hansen
On 7/25/23 20:39, Fan Ni wrote: > From: Fan Ni > > Per CXL spec 3.0, two mailbox commands are implemented: > Add Dynamic Capacity Response (Opcode 4802h) 8.2.9.8.9.3, and > Release Dynamic Capacity (Opcode 4803h) 8.2.9.8.9.4. > > Signed-off-by: Fan Ni > --- > hw/cxl/cxl-mailbox-utils.c |

Re: [RFC] CXL: TCG/KVM instruction alignment issue discussion default

2023-02-27 Thread Jørgen Hansen
On 2/18/23 11:22, Gregory Price wrote: > Breaking this off into a separate thread for archival sake. > > There's a bug with handling execution of instructions held in CXL > memory - specifically when an instruction crosses a page boundary. > > The result of this is that type-3 devices cannot use

Re: [RFC] CXL: TCG/KVM instruction alignment issue discussion default

2023-03-01 Thread Jørgen Hansen
On 2/28/23 11:49, Jonathan Cameron wrote: >>> Second there's the performance issue: >>> >>> 0) Do we actually care about performance? How likely are users to >>> attempt to run software out of CXL memory? >>> >>> 1) If we do care, is there a potential for converting CXL away from the >>>

Re: [PATCH 1/1] accel/tcg: Allow the second page of an instruction to be MMIO

2023-02-07 Thread Jørgen Hansen
ed-by: Sid Manning > Reported-by: Jørgen Hansen > Signed-off-by: Richard Henderson > --- > accel/tcg/translator.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c > index ef5193c67e..1cf404

Re: [PATCH v4 04/10] hw/mem/cxl_type3: Add support to create DC regions to type3 memory devices

2024-03-04 Thread Jørgen Hansen
On 2/21/24 19:15, nifan@gmail.com wrote: > CAUTION: This email originated from outside of Western Digital. Do not click > on links or open attachments unless you recognize the sender and know that > the content is safe. > > > From: Fan Ni > > With the change, when setting up memory for

Re: [PATCH v4 02/10] hw/cxl/cxl-mailbox-utils: Add dynamic capacity region representative and mailbox command support

2024-03-04 Thread Jørgen Hansen
On 2/21/24 19:15, nifan@gmail.com wrote: > CAUTION: This email originated from outside of Western Digital. Do not click > on links or open attachments unless you recognize the sender and know that > the content is safe. > > > From: Fan Ni > > Per cxl spec r3.1, add dynamic capacity

Re: Another CXL/MMIO tcg tlb corner case

2024-03-15 Thread Jørgen Hansen
> On 15 Mar 2024, at 13.25, Alex Bennée wrote: > > Jørgen Hansen writes: > >> Hi, >> >> While doing some testing using numactl-based interleaving of application >> memory >> across regular memory and CXL-based memory using QEMU with tcg, I ran into

Another CXL/MMIO tcg tlb corner case

2024-03-15 Thread Jørgen Hansen
Hi, While doing some testing using numactl-based interleaving of application memory across regular memory and CXL-based memory using QEMU with tcg, I ran into an issue similar to what we saw a while back - link to old issue:

Re: [PATCH v6 11/12] hw/cxl/cxl-mailbox-utils: Add superset extent release mailbox support

2024-04-05 Thread Jørgen Hansen
On 3/25/24 20:02, nifan@gmail.com wrote: > From: Fan Ni > > With the change, we extend the extent release mailbox command processing > to allow more flexible release. As long as the DPA range of the extent to > release is covered by accepted extent(s) in the device, the release can be >

Re: [PATCH 9/9] accel/tcg: Improve can_do_io management

2024-04-08 Thread Jørgen Hansen
second page turned out to be mmio. In this case we > truncate the block, and the previous logic for can_do_io could leave > a block with a single insn with can_do_io set to false, which would > fail an assertion in cpu_io_recompile. > > Reported-by: Jørgen Hansen > Signed-off-by: Ric

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-04-04 Thread Jørgen Hansen
On 3/25/24 20:02, nifan@gmail.com wrote: > From: Fan Ni > > Per CXL spec 3.1, two mailbox commands are implemented: > Add Dynamic Capacity Response (Opcode 4802h) 8.2.9.9.9.3, and > Release Dynamic Capacity (Opcode 4803h) 8.2.9.9.9.4. > > For the process of the above two commands, we use

Re: [PATCH v6 08/12] hw/cxl/cxl-mailbox-utils: Add mailbox commands to support add/release dynamic capacity response

2024-04-16 Thread Jørgen Hansen
On 4/15/24 19:56, fan wrote: > From 4b9695299d3d4b22f83666f8ab79099ec9f9817f Mon Sep 17 00:00:00 2001 > From: Fan Ni > Date: Tue, 20 Feb 2024 09:48:30 -0800 > Subject: [PATCH 08/13] hw/cxl/cxl-mailbox-utils: Add mailbox commands to > support add/release dynamic capacity response > > Per CXL