Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-05 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-05 at 15:26 +0200, Thomas Huth wrote: > On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: > > From: Pierre Morel > > > > On interception of STSI(15.1.x) the System Information Block > > (SYSIB) is built from the list of pre-ordered topology e

Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-06 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-06 at 10:21 +0200, Thomas Huth wrote: > On 05/09/2023 17.25, Nina Schoetterl-Glausch wrote: > > On Tue, 2023-09-05 at 15:26 +0200, Thomas Huth wrote: > > > On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: > > > > From: Pierre Morel > > >

[PATCH v23 04/20] s390x/sclp: reporting the maximum nested topology entries

2023-09-14 Thread Nina Schoetterl-Glausch
-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v23 10/20] machine: adding s390 topology to info hotpluggable-cpus

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file changed, 6

[PATCH v23 06/20] s390x/cpu topology: interception of PTF instruction

2023-09-14 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v23 17/20] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed

[PATCH v23 15/20] tests/avocado: s390x cpu topology polarization

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl

[PATCH v23 07/20] target/s390x/cpu topology: activate CPU topology

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced

[PATCH v23 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado

[PATCH v23 19/20] tests/avocado: s390x cpu topology dedicated errors

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git

[PATCH v23 13/20] docs/s390x/cpu topology: document s390x cpu topology

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v22 13/20] docs/s390x/cpu topology: document s390x cpu topology

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index-internals.rst | 1

[PATCH v22 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado/s390_topology.py | 55

[PATCH v22 11/20] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-09-01 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 33 + hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 35 insertions(+) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index

[PATCH v22 04/20] s390x/sclp: reporting the maximum nested topology entries

2023-09-01 Thread Nina Schoetterl-Glausch
-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v22 07/20] target/s390x/cpu topology: activate CPU topology

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced

[PATCH v22 06/20] s390x/cpu topology: interception of PTF instruction

2023-09-01 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v22 18/20] tests/avocado: s390x cpu topology test socket full

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git

[PATCH v22 19/20] tests/avocado: s390x cpu topology dedicated errors

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git

[PATCH v22 15/20] tests/avocado: s390x cpu topology polarization

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado/s390_topology.py | 45

[PATCH v22 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-01 Thread Nina Schoetterl-Glausch
-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 37 +++ hw/s390x/cpu-topology.c | 135 +++ 2 files changed, 172 insertions(+) diff --git

[PATCH v22 20/20] tests/avocado: s390x cpu topology bad move

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v22 00/20] s390x: CPU Topology

2023-09-01 Thread Nina Schoetterl-Glausch
e guest information on host +vCPU scheduling and help the guest make better scheduling decisions. Let us provide the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Signed-off-by: Pierre Morel +Reviewed-by

[PATCH v22 14/20] tests/avocado: s390x cpu topology core

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel --- MAINTAINERS| 1 +

[PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS

[PATCH v22 01/20] CPU topology: extend with s390 specifics

2023-09-01 Thread Nina Schoetterl-Glausch
the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-common.json| 21

[PATCH v22 12/20] qapi/s390x/cpu topology: query-cpu-polarization qmp command

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 29

[PATCH v22 05/20] s390x/cpu topology: resetting the Topology-Change-Report

2023-09-01 Thread Nina Schoetterl-Glausch
Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-ccw.c

[PATCH v22 02/20] s390x/cpu topology: add topology entries on CPU hotplug

2023-09-01 Thread Nina Schoetterl-Glausch
is added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed

[PATCH v22 10/20] machine: adding s390 topology to info hotpluggable-cpus

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v22 09/20] machine: adding s390 topology to query-cpu-fast

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina

[PATCH v22 17/20] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-01 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado

Re: [PATCH v22 15/20] tests/avocado: s390x cpu topology polarization

2023-09-08 Thread Nina Schoetterl-Glausch
On Thu, 2023-09-07 at 11:02 +0200, Thomas Huth wrote: > On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: > > From: Pierre Morel > > > > Polarization is changed on a request from the guest. > > Let's verify the polarization is accordingly set by QEMU. > >

Re: [PATCH v22 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-09-08 Thread Nina Schoetterl-Glausch
On Thu, 2023-09-07 at 11:05 +0200, Thomas Huth wrote: > On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: > > From: Pierre Morel > > > > Test changes in the entitlement from both a guest and a host point of > > view, depending on the polarization. > > > &

[PATCH v23 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v23 12/20] qapi/s390x/cpu topology: query-cpu-polarization qmp command

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi

[PATCH v23 11/20] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-09-14 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 33 + hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 35 insertions(+) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index

[PATCH v23 02/20] s390x/cpu topology: add topology entries on CPU hotplug

2023-09-14 Thread Nina Schoetterl-Glausch
is added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed

[PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-14 Thread Nina Schoetterl-Glausch
the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-common.json| 21

[PATCH v23 20/20] tests/avocado: s390x cpu topology bad move

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v23 00/20] s390x: CPU Topology

2023-09-14 Thread Nina Schoetterl-Glausch
mc->smp_props.books_supported = false; + } + DEFINE_CCW_MACHINE(8_1, "8.1", false); + ## softmmu/vl.c ## @@ softmmu/vl.c: static QemuOptsList qemu_smp_opts = { 2: 6d32f1e3d4 ! 2: 5fae55e5a1 s390x/cpu topology: add topology entries on CPU hotplug @@ Commit message

[PATCH v23 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-14 Thread Nina Schoetterl-Glausch
-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 37 +++ hw/s390x/cpu-topology.c | 132 +++ 2 files changed, 169 insertions(+) diff --git

[PATCH v23 09/20] machine: adding s390 topology to query-cpu-fast

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth

[PATCH v23 14/20] tests/avocado: s390x cpu topology core

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v23 05/20] s390x/cpu topology: resetting the Topology-Change-Report

2023-09-14 Thread Nina Schoetterl-Glausch
Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-ccw.c

[PATCH v23 18/20] tests/avocado: s390x cpu topology test socket full

2023-09-14 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git

Re: [PATCH v22 14/20] tests/avocado: s390x cpu topology core

2023-09-04 Thread Nina Schoetterl-Glausch
On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Introduction of the s390x cpu topology core functions and > basic tests. > > We test the correlation between the command line and > the QMP results in query-cpus-fast for various CPU

Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-04 Thread Nina Schoetterl-Glausch
On Fri, 2023-09-01 at 17:57 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > Co-developed-by: Ni

Re: [PATCH v22 15/20] tests/avocado: s390x cpu topology polarization

2023-09-04 Thread Nina Schoetterl-Glausch
On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Polarization is changed on a request from the guest. > Let's verify the polarization is accordingly set by QEMU. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-

Re: [PATCH v22 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-09-04 Thread Nina Schoetterl-Glausch
On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > Test changes in the entitlement from both a guest and a host point of > view, depending on the polarization. > > Signed-off-by: Pierre Morel > Co-developed-by: Nina Schoetterl-

Re: [PATCH v22 17/20] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-04 Thread Nina Schoetterl-Glausch
On Fri, 2023-09-01 at 17:58 +0200, Nina Schoetterl-Glausch wrote: > From: Pierre Morel > > A dedicated CPU in vertical polarization can only have > a high entitlement. > Let's check this from both host and guest point of view. > > Signed-off-by: Pierre Morel > Co-devel

Re: [PATCH v22 14/20] tests/avocado: s390x cpu topology core

2023-09-08 Thread Nina Schoetterl-Glausch
On Thu, 2023-09-07 at 10:27 +0200, Thomas Huth wrote: > On 01/09/2023 17.58, Nina Schoetterl-Glausch wrote: > > From: Pierre Morel > > > > Introduction of the s390x cpu topology core functions and > > basic tests. > > > > We test the correlation between t

Re: [PATCH v25 02/21] CPU topology: extend with s390 specifics

2023-10-13 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-12 at 13:02 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features

Re: [PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties

2023-10-13 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-12 at 07:59 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > Clarify roles of different architectures. > > Also change things a bit in anticipation of additional members being > > added. > > > > Suggested-by: Markus

[PATCH v26 02/21] CPU topology: extend with s390 specifics

2023-10-16 Thread Nina Schoetterl-Glausch
levels to the relevant QAPI structs. Add all the supported topology levels, dedication and entitlement as properties to S390 CPUs. Create machine-common.json so we can later include it in machine-target.json also. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v26 16/21] tests/avocado: s390x cpu topology polarization

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl

[PATCH v26 14/21] docs/s390x/cpu topology: document s390x cpu topology

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v26 00/21] s390x: CPU Topology

2023-10-16 Thread Nina Schoetterl-Glausch
TCG (Thomas) - Take care of endianess to prepare TCG (Thomas) - Added comments on STSI CPU container and PFT instruction (Thomas) - Moved enabling the instructions as the last patch (Thomas) Nina Schoetterl-Glausch (1): qapi: machine.json: change docs regarding CPU topology Pierre More

[PATCH v26 06/21] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-16 Thread Nina Schoetterl-Glausch
Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- include/hw/s390x/cpu-topology.h | 1 + target/s390x/cpu.h | 1 + target/s390x/kvm/kvm_s390x.h| 1 + hw/s390x/cpu-topology.c | 11 +++ hw/s390x/s390-virtio-ccw.c

[PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-16 Thread Nina Schoetterl-Glausch
Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine.json | 58 +++ 1 file changed, 38 insertions

[PATCH v26 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-s390x-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Acked-by: Markus Armbruster Signed-off

[PATCH v26 03/21] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-16 Thread Nina Schoetterl-Glausch
is added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed

[PATCH v26 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE QAPI event

2023-10-16 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Acked-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 35 +++ hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 37 insertions(+) diff --git a/qapi/machine-target.json b

[PATCH v26 11/21] machine: adding s390 topology to info hotpluggable-cpus

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file changed, 6

[PATCH v26 05/21] s390x/sclp: reporting the maximum nested topology entries

2023-10-16 Thread Nina Schoetterl-Glausch
-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- include/hw/s390x/sclp.h | 5 +++-- hw/s390x/sclp.c | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h index c49051e17e..9aef6d9370 100644 --- a/include/hw/s390x

[PATCH v26 17/21] tests/avocado: s390x cpu topology entitlement tests

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Tested-by: Thomas Huth Signed-off-by: Nina Schoetterl

[PATCH v26 07/21] s390x/cpu topology: interception of PTF instruction

2023-10-16 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v26 21/21] tests/avocado: s390x cpu topology bad move

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QEMU refuses to move a CPU to an nonexistent location. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH v26 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-10-16 Thread Nina Schoetterl-Glausch
-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 42 + hw/s390x/cpu-topology.c | 132 +++ 2 files changed

[PATCH v26 18/21] tests/avocado: s390x cpu topology test dedicated CPU

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed

[PATCH v26 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git

[PATCH v26 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Acked-by: Markus

[PATCH v26 08/21] target/s390x/cpu topology: activate CPU topology

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced

[PATCH v26 15/21] tests/avocado: s390x cpu topology core

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v26 19/21] tests/avocado: s390x cpu topology test socket full

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git

[PATCH v26 10/21] machine: adding s390 topology to query-cpu-fast

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth

Re: [PULL 03/25] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-19 Thread Nina Schoetterl-Glausch
ecifying the topology can > still get some advantage of the CPU topology. > > Signed-off-by: Pierre Morel > Reviewed-by: Nina Schoetterl-Glausch > Co-developed-by: Nina Schoetterl-Glausch > Reviewed-by: Thomas Huth > Signed-off-by: Nina Schoetterl-Glausch >

Re: [PULL 06/25] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-19 Thread Nina Schoetterl-Glausch
ear the Modified Topology Change Report (MTCR) > > bit of the SCA in the case of a subsystem reset. > > > > Signed-off-by: Pierre Morel > > Reviewed-by: Thomas Huth > > Reviewed-by: Nina Schoetterl-Glausch > > Co-developed-by: Nina Schoetterl-Glausch > >

[PATCH] target/s390x/cpu topology: Fix ordering and creation of TLEs

2023-10-27 Thread Nina Schoetterl-Glausch
("target/s390x/cpu topology: handle STSI(15) and build the SYSIB") Signed-off-by: Nina Schoetterl-Glausch --- Unfortunately this wasn't caught by the kvm-unit-test because that also had a bug :( target/s390x/kvm/stsi-topology.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-22 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 13:11 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-21 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 12:57 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > > > Nina Schoetterl-Glausch writes: > > > > > > > From: Pierre Morel > > &g

Re: [PATCH v23 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-25 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 13:36 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > The modification of the CPU attributes are done through a monitor > > command. > > > > It allows to move the core inside t

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-25 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features

[PATCH v24 14/21] docs/s390x/cpu topology: document s390x cpu topology

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Signed-off-by: Nina Schoetterl-Glausch --- MAINTAINERS| 2 + docs/devel/index

[PATCH v24 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git

[PATCH v24 16/21] tests/avocado: s390x cpu topology polarization

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl

[PATCH v24 11/21] machine: adding s390 topology to info hotpluggable-cpus

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file changed, 6

[PATCH v24 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v24 13/21] qapi/s390x/cpu topology: add query-s390x-cpu-polarization command

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel The query-s390x-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch

[PATCH v24 00/21] s390x: CPU Topology

2023-09-26 Thread Nina Schoetterl-Glausch
ke care of endianess to prepare TCG (Thomas) - Added comments on STSI CPU container and PFT instruction (Thomas) - Moved enabling the instructions as the last patch (Thomas) Nina Schoetterl-Glausch (1): qapi: machine.json: change docs regarding CpuInstanceProperties Pierre Morel (20): CPU top

[PATCH v24 02/21] CPU topology: extend with s390 specifics

2023-09-26 Thread Nina Schoetterl-Glausch
the SMP properties with books and drawers levels and S390 CPU with dedication and entitlement, Add machine-common.json so we can later include it in machine-target.json also. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v24 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-09-26 Thread Nina Schoetterl-Glausch
-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 34 ++ hw/s390x/cpu-topology.c | 2 ++ 2 files changed, 36 insertions(+) diff --git a/qapi/machine-target.json b/qapi/machine-target.json index

[PATCH v24 17/21] tests/avocado: s390x cpu topology entitlement tests

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Test changes in the entitlement from both a guest and a host point of view, depending on the polarization. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- tests/avocado

[PATCH v24 07/21] s390x/cpu topology: interception of PTF instruction

2023-09-26 Thread Nina Schoetterl-Glausch
code 0 and 1 are intercepted and must be emulated by the userland hypervisor. During RESET all CPU of the configuration are placed in horizontal polarity. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Co-developed-by: Nina Schoetterl-Glausch Signed-off

[PATCH v24 10/21] machine: adding s390 topology to query-cpu-fast

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth

[PATCH v24 15/21] tests/avocado: s390x cpu topology core

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v24 01/21] qapi: machine.json: change docs regarding CpuInstanceProperties

2023-09-26 Thread Nina Schoetterl-Glausch
Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- Reference to s390x docs added in patch 14 qapi/machine.json | 17 + 1 file

[PATCH v24 18/21] tests/avocado: s390x cpu topology test dedicated CPU

2023-09-26 Thread Nina Schoetterl-Glausch
From: Pierre Morel A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this from both host and guest point of view. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Reviewed-by: Nina Schoetterl-Glausch Signed

[PATCH v24 03/21] s390x/cpu topology: add topology entries on CPU hotplug

2023-09-26 Thread Nina Schoetterl-Glausch
is added in the physical topology based on its core ID and it gets defaults values for the modifier attributes. This way, starting QEMU without specifying the topology can still get some advantage of the CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed

[PATCH v24 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-26 Thread Nina Schoetterl-Glausch
-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine-target.json | 42 + hw/s390x/cpu-topology.c | 132 +++ 2 files changed, 174 insertions(+) diff

  1   2   3   >