[Qemu-devel] [PATCH 0/2] register: fix incorrect read mask

Hi, This serie fix a bug in register_read_memory(). To avoid duplicated code, a new inlined function register_enabled_mask() is introduced in the first patch. Philippe Mathieu-Daudé (2): register: inline register_enabled_mask register: fix incorrect read mask hw/core/register.c | 21

[Qemu-devel] [PATCH 1/2] register: inline register_enabled_mask

This patch prepares for the fix of register_read() incorrect mask. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/register.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/core/register.c b/hw/core/register.c index 4bfb

[Qemu-devel] [PATCH 2/2] register: fix incorrect read mask

The register_read() function expects a bitmask argument. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/core/register.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/register.c b/hw/core/register.c index 12f4c1e62d..482e3f827a 100644 --

Re: [Qemu-devel] [PATCH v3 2/8] hw/mips_gictimer: provide API for retrieving frequency

imerState *gic, uint64_t count); uint32_t mips_gictimer_get_vp_compare(MIPSGICTimerState *gictimer, Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH 2/2] cirrus: replace debug printf with trace points

On 02/08/2017 10:51 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> hw/display/cirrus_vga.c | 11 +-- hw/display/trace-events | 6 ++ 2 files changed, 11 insertions(+), 6 deleti

Re: [Qemu-devel] [PATCH v3 4/8] target-mips: Provide function to test if a CPU supports an ISA

+ +return (def->insn_flags & isa) != 0; +} + void cpu_set_exception_base(int vp_index, target_ulong address) { MIPSCPU *vp = MIPS_CPU(qemu_get_cpu(vp_index)); Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH 1/2] vga: replace debug printf with trace points

On 02/08/2017 10:51 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> hw/display/trace-events | 6 ++ hw/display/vga.c| 27 --- 2 files changed, 10 inser

Re: [Qemu-devel] [PATCH v3] migrate: Introduce zero RAM checks to skip RAM migration

vices only. Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Changes in v3: - handle migration cleanup appropriately (Dave) Changes in v2: - try to migrate successfully by skipping RAM (Paolo, Greg) - drop the idea of er

Re: [Qemu-devel] [PATCH 06/22] target/openrisc: Tidy insn dumping

On 02/09/2017 01:51 AM, Richard Henderson wrote: Avoids warnings from unused variables etc. Reviewed-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> Signed-off-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --

Re: [Qemu-devel] [PATCH 15/22] target/openrisc: Enable trap, csync, msync, psync for user mode

On 02/09/2017 01:51 AM, Richard Henderson wrote: Not documented as disabled for user mode. Reviewed-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> Signed-off-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --

Re: [Qemu-devel] [PATCH 14/22] target/openrisc: Set flags on helpers

On 02/09/2017 01:51 AM, Richard Henderson wrote: Reviewed-by: Bastian Koppelmann <kbast...@mail.uni-paderborn.de> Signed-off-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/openrisc/helper.h | 24 --

Re: [Qemu-devel] [PATCH 20/22] target/openrisc: Optimize l.jal to next

On 02/09/2017 01:51 AM, Richard Henderson wrote: This allows the tcg optimizer to see, and fold, all of the constants involved in a GOT base register load sequence. Signed-off-by: Richard Henderson <r...@twiddle.net> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH 01/12] s390x/s390-virtio: get rid of DPRINTF

ic <pa...@linux.vnet.ibm.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/s390x/s390-virtio.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c index 7a3a7fe5fd..9cfb09057e 100644 --- a/hw/s390x/s390-virtio.c +

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/11] armv7m: Split systick out from NVIC

Hi peter, On 02/20/2017 12:36 PM, Peter Maydell wrote: The SysTick timer isn't really part of the NVIC proper; we just modelled it that way back when we couldn't easily have devices that only occupied a small chunk of a memory region. Split it out into its own device. Signed-off-by: Peter

Re: [Qemu-devel] [Qemu-arm] [PATCH 01/11] armv7m: Abstract out the "load kernel" code

ich choose to directly instantiate an ARMv7M device object can call it. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/arm/arm.h | 12 hw/arm/armv7m.c | 23 ++- 2 files

Re: [Qemu-devel] [PATCH 08/11] armv7m: Don't put core v7M devices under CONFIG_STELLARIS

Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/intc/Makefile.objs | 2 +- default-configs/arm-softmmu.mak | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/intc/Makefile.objs b/hw/intc/Makefile.objs i

Re: [Qemu-devel] [Qemu-arm] [PATCH 11/11] stm32f205: Rename 'nvic' local to 'armv7m'

org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/arm/stm32f205_soc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c index e6bd73a..6e1260d 100644 --- a/hw/arm/stm32f205_soc.c +++ b/hw/arm/stm

Re: [Qemu-devel] [PATCH v5] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

) on x86_64 (little-endian). > also i386-user on armv7l (32le) Signed-off-by: Helge Deller <del...@gmx.de> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Changes to v4: (all suggested by Laurent Vivier) - Handle AF_INET6 in host_to_target_sockaddr() - Drop length c

Re: [Qemu-devel] [Qemu-arm] [PATCH 02/11] armv7m: Move NVICState struct definition into header

On 02/20/2017 12:35 PM, Peter Maydell wrote: Move the NVICState struct definition into a header, so we can embed it into other QOM objects like SoCs. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- in

Re: [Qemu-devel] [Qemu-arm] [PATCH 10/11] stm32f205: Create armv7m object without using armv7m_init()

board code where it belongs, rather than the SoC object having a QOM property for the filename to load. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/arm/stm32f205_soc.h | 4 +++- hw/arm/netduino2.c

Re: [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull()

to qemu_strtou64(). Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/qemu/cutils.h | 6 +- qobject/qdict.c | 2 +- qtest.c | 34 ++--- tests/test-cuti

Re: [Qemu-devel] [PATCH 17/24] util/cutils: Drop QEMU_STRTOSZ_DEFSUFFIX_* macros

On 02/14/2017 07:26 AM, Markus Armbruster wrote: Writing QEMU_STRTOSZ_DEFSUFFIX_* instead of '*' gains nothing. Get rid of these eyesores. Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- util/c

Re: [Qemu-devel] [PATCH v4 2/4] new: debian docker targets for cross-compiling

docker target builds on the base debian image. +# +FROM qemu:debian + +# Add the foreign architecture we want and install dependacies typo "dependencies" Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> +RUN dpkg --add-architecture arm64 +RUN apt update +RUN apt install

Re: [Qemu-devel] [PATCH 1/2] monitor.c: make mon_get_cpu return NULL when there is no CPU

hen returns NULL. Signed-off-by: Ziyue Yang <skiver.cloud@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- monitor.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 3cd72a9bab..6b25cf7a2b 100644 ---

Re: [Qemu-devel] [PATCH 2/2] target/i386/monitor.c: check return value of mon_get_cpu before using it

e -monitor stdio and then type "info lapic" into qemu monitor. Signed-off-by: Ziyue Yang <skiver.cloud....@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- target/i386/monitor.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/

Re: [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends

with uint64_t. * Claims the unsigned conversions can underflow. They can't. While there, mark problematic assumptions that int64_t is long long, and uint64_t is unsigned long long with FIXME comments. Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH 03/24] tests/test-cutils: Add missing qemu_strtol()... endptr checks

On 02/14/2017 07:25 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/test-cutils.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/test-cutils.c b/tests/t

Re: [Qemu-devel] [PATCH 10/24] tests/test-cutils: Add missing qemu_strtosz()... endptr checks

On 02/14/2017 07:25 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster <arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/test-cutils.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [PATCH v4 1/4] tests/docker: add basic user mapping support

ian-armhf-cross NOUSER=1 Signed-off-by: Alex Bennée <alex.ben...@linaro.org> Reviewed-by: Fam Zheng <f...@redhat.com> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2 - write the useradd directly - change long

Re: [Qemu-devel] [PATCH 5/5] NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()

On 02/16/2017 09:29 AM, Dmitry Fleytman wrote: This is a refactoring commit that does not change behavior. Signed-off-by: Dmitry Fleytman <dmi...@daynix.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/net/net_rx_pkt.c | 9 + 1 file changed, 5 inse

Re: [Qemu-devel] [PATCH v4 3/5] slirp: Common lhost/fhost union

: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/socket.h | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/slirp/socket.h b/slirp/socket.h index 8feed2a..c1be77e 100644 --- a/slirp/s

Re: [Qemu-devel] [PATCH] linux-user: fix fork()

t Vivier <laur...@vivier.eu> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- linux-user/syscall.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f569f82..4d85355 100644 --- a/linux-user/syscall.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lm32: milkymist-tmu2: fix a third integer overflow

for coverity CID 1167561 (hopefully!). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Third time lucky -- I checked and this is the last of these multiply lines. hw/display/milkymist-tmu2.c | 2 +- 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH] tpm-tis: set selftest flag on all localities

On 02/23/2017 05:11 AM, Marc-André Lureau wrote: Set the flag on all localities, as the original commit fd859081453f94c3cbd652 intended to. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/tpm/tpm_tis

Re: [Qemu-devel] [PATCH] hw/ppc/ppc405_uc.c: Avoid integer overflows

result. Add casts to ensure we don't truncate the result. (Spotted by Coverity, CID 1005504, 1005505.) well hidden... Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/ppc405_uc.c | 6 +++--- 1 file changed,

Re: [Qemu-devel] [PATCH v2 18/30] tests: fix e1000-test leak

On 02/21/2017 11:14 AM, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/e1000-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/e1000-test.c b

Re: [Qemu-devel] [PATCH v2 07/30] tests: fix endianness-test leaks

On 02/21/2017 11:14 AM, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/endianness-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/endia

Re: [Qemu-devel] [PATCH v2 26/30] tests: allows to run single test in usb-hcd-ehci-test

andre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/usb-hcd-ehci-test.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/usb-hcd-ehci-test.c b/tests/usb-hcd-ehci-test.c index 57af8a034e..fba84b4bee 100644 --- a/tests/usb-hcd

Re: [Qemu-devel] [PATCH v2 30/30] migration: fix id leak regression

oved from make check with this series) Oops yes. Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Cc: Dr. David Alan Gilbert <dgilb...@redhat.com> Cc: Juan Quintela <quint...@redhat.com> Signed-off-by: Ma

Re: [Qemu-devel] [PATCH v2 01/30] qtest: fix a memory leak

On 02/21/2017 11:14 AM, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qtest.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH v2 13/30] tests: fix ipmi-kcs-test leak

On 02/21/2017 11:14 AM, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/ipmi-kcs-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ipmi-kcs-te

Re: [Qemu-devel] [PATCH v2 14/30] tests: fix ipmi-bt-test leak

On 02/21/2017 11:14 AM, Marc-André Lureau wrote: Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- tests/ipmi-bt-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ipmi-bt-te

Re: [Qemu-devel] [PATCH] vfio/pci: Report errors from qdev_unplug() via device request

c Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/vfio/pci.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 332f41d6627f..f2ba9b6cfafc 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2506,12 +2506

Re: [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing td

On 02/22/2017 07:56 AM, Li Qiang wrote: It should return 1 if an error occurs when reading td. This will avoid an infinite loop issue in ohci_service_ed_list. Signed-off-by: Li Qiang <liqiang...@360.cn> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/usb/hcd-ohci

Re: [Qemu-devel] [RESEND PATCH 3/9] hw/dma: QOM'ify sun4m_iommu.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/dma/sun4m_iommu.c | 12 +--- 1 file changed, 5 inse

Re: [Qemu-devel] [RESEND PATCH 1/9] hw/misc: QOM'ify eccmemctl.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: * Split the old SysBus init into an instance_init and a DeviceClass::realize function * Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [RESEND PATCH 4/9] hw/misc: QOM'ify slavio_misc.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/misc/slavio_misc.c | 43 +--

Re: [Qemu-devel] [PATCH 2/4] aspeed: remove useless comment on controller segment size

Goater <c...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/arm/aspeed.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index ac9cbd66b72a..283c03881493 100644 --- a/hw/arm/aspeed.c +++ b/hw/

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/4] aspeed/smc: use a modulo to check segment limits

On 02/09/2017 10:47 AM, Cédric Le Goater wrote: The size of a segment is not necessarily a power of 2. Signed-off-by: Cédric Le Goater <c...@kaod.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Qemu-devel] [RESEND PATCH 8/9] hw/sparc: QOM'ify sun4m.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/sparc/

Re: [Qemu-devel] [RESEND PATCH 9/9] hw/sparc64: QOM'ify sun4u.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: Drop the old SysBusDeviceClass::init and use instance_init or DeviceClass::realize instead Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/sparc64/

Re: [Qemu-devel] [PATCH 8/9] virtio: check for vring setup in virtio_queue_update_used_idx

-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/virtio/virtio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 32bf364..23fac1e 100644 --- a/hw/virtio/vi

Re: [Qemu-devel] [RESEND PATCH 7/9] hw/timer: QOM'ify slavio_timer

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: rename slavio_timer_init1 to slavio_timer_init and assign it to slavio_timer_info.instance_init, then we drop the SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@

Re: [Qemu-devel] [RESEND PATCH 5/9] hw/timer: QOM'ify m48txx_sysbus (pass 1)

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: * split the old SysBus init function into an instance_init and a Device realize function * use DeviceClass::realize instead of SysBusDeviceClass::init Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [RESEND PATCH 2/9] hw/dma: QOM'ify sparc32_dma.c

On 02/05/2017 10:37 AM, xiaoqiang zhao wrote: Drop the old SysBus init function and use instance_init and an realize function Signed-off-by: xiaoqiang zhao <zxq_yx_...@163.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/dma/sparc32_dma.c | 25 +++-

Re: [Qemu-devel] [PATCH 4/9] exec: make address_space_cache_destroy idempotent

On 01/27/2017 12:40 PM, Paolo Bonzini wrote: Clear cache->mr so that address_space_cache_destroy does nothing the second time it is called. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Ma

Re: [Qemu-devel] [PATCH 1/9] memory: make memory_listener_unregister idempotent

On 01/27/2017 12:40 PM, Paolo Bonzini wrote: Make it easy to unregister a MemoryListener without tracking whether it had been registered before. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v3: new

Re: [Qemu-devel] [PATCH] linux-user: Use correct types in load_symbols()

CID1005776) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- linux-user/elfload.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c i

Re: [Qemu-devel] [PATCH] softfloat: Use correct type in float64_to_uint64_round_to_zero()

and forth to int64_t. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- Spotted while reading the code... fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu

Re: [Qemu-devel] [PATCH] hw/pci-host/prep: Do not use hw_error() in realize function

with error_setg() in case of errors instead. Additionally, move some code around and delete the bios memory subregion again in case of such an error, so that we leave a clean state when returning to the caller. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH 2/2] register: fix incorrect read mask

On 02/10/2017 07:19 PM, Alistair Francis wrote: On Mon, Feb 6, 2017 at 3:39 PM, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: The register_read() function expects a bitmask argument. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> The functionality of these two patche

Re: [Qemu-devel] [PATCH 3/3] slirp: tcp_listen(): Don't try to close() an fd we never opened

we need closesocket() to do the right thing on Windows. Change to using the right function and only calling it if needed. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/socket.c | 4 +++- 1 file changed,

Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

;pa...@linux.vnet.ibm.com> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- I had a very similar patch named "migration: drop unused VMStateField.start" on the list. What changed since then is that we nee

Re: [Qemu-devel] [PATCH] 9pfs: proxy: assert if unmarshal fails

Hi Greg, On 02/06/2017 02:20 PM, Greg Kurz wrote: Replies from the virtfs proxy are made up of a fixed-size header (8 bytes) and a payload of variable size (maximum 64kb). When receiving a reply, the proxy backend first reads the whole header and then unmarshals it. If the header is okay, it

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Use qemu_strtoul() rather than raw strtoul()

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 74e3362..aa71588 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3621,24 +3621,24 @@ static int img

Re: [Qemu-devel] [PATCH 2/3] slirp: Convert mbufs to use g_malloc() and g_free()

-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/mbuf.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/slirp/mbuf.c b/slirp/mbuf.c index 7eddc21..5ff2455 100644 --- a/

Re: [Qemu-devel] [PATCH 2/2] qemu-img: Avoid setting ret to unused value in img_convert()

into line with the following call to bdrv_snapshot_laod_tmp_by_id_or_name(). (Fixes CID 1247240.) Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- qemu-img.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH 1/3] slirp: Check qemu_socket() return value in udp_listen()

; but Coverity complains (CID 1005723). Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/udp.c | 4 1 file changed, 4 insertions(+) diff --git a/slirp/udp.c b/slirp/udp.c index 93d7224..227d779 100644 --- a/slirp

[Qemu-devel] [PATCH v2] register: fix incorrect read mask

The register_read() function expects a bitmask argument. To avoid duplicated code, a new inlined function register_enabled_mask() is introduced. Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v2: squashed together both previous commits as suggested by Francis Alistair. h

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

Hi Mike, I failed to apply your patch on master: error: patch failed: target/ppc/Makefile.objs:1 error: target/ppc/Makefile.objs: patch does not apply error: patch failed: target/ppc/arch_dump.c:1 error: target/ppc/arch_dump.c: patch does not apply error: patch failed: target/ppc/cpu.h:1225

Re: [Qemu-devel] [PATCH v2.1 10/21] target/arm: use vector opcode to handle vadd. instruction

On 02/02/2017 11:34 AM, Kirill Batuzov wrote: Signed-off-by: Kirill Batuzov --- target/arm/translate.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index d7578e2..90e14df 100644 ---

Re: [Qemu-devel] [PATCH 2/3] ppc4xx: replace debug printf with trace points

On 02/10/2017 06:27 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier <lviv...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/ppc4xx_pci.c | 13 +++-- hw/ppc/trace-events | 4 2 files changed, 7 insertions(+), 10 deletions(-)

Re: [Qemu-devel] [PATCH 1/3] mac99: replace debug printf with trace points

On 02/10/2017 06:27 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier <lviv...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/mac_newworld.c | 15 +++ hw/ppc/trace-events | 4 2 files changed, 7 insertions(+), 12 deleti

Re: [Qemu-devel] [PATCH 3/3] spapr: replace debug printf with trace points

On 02/10/2017 06:27 AM, Laurent Vivier wrote: Signed-off-by: Laurent Vivier <lviv...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/ppc/spapr_ovec.c | 17 +++-- hw/ppc/trace-events | 4 2 files changed, 7 insertions(+), 14 deletions(-)

Re: [Qemu-devel] [PATCH 2/9] armv7m: Implement reading and writing of PRIGROUP

On 02/02/2017 05:02 PM, Peter Maydell wrote: Add a state field for the v7M PRIGROUP register and implent reading and writing it. The current NVIC doesn't honour the values written, but the new version will. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe M

Re: [Qemu-devel] [PATCH 9/9] armv7m: VECTCLRACTIVE and VECTRESET are UNPREDICTABLE

[PMM: change extracted from another patch; commit message constructed from scratch] Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/intc/armv7m_nvic.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH 1/9] armv7m: Rename nvic_state to NVICState

On 02/02/2017 05:02 PM, Peter Maydell wrote: Rename the nvic_state struct to NVICState, to match our naming conventions. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/intc/armv7m

Re: [Qemu-devel] [PATCH] linux-user: Add sockopts for IPv6 ping and IPv6 traceroute

optname=51 Unsupported setsockopt level=41 optname=8 Unsupported setsockopt level=58 optname=1 Tested on hppa-linux-user. Signed-off-by: Helge Deller <del...@gmx.de> Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org> and with IPV6_PKTINFO: Reviewed-by: Philippe Mathieu-Daudé <

Re: [Qemu-devel] [PATCH v1 1/2] new: dockerfiles/debian-s390-cross

_CONFIGURE_OPTS --cross-prefix=s390x-linux-gnu- Tested-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH] linux-user: fix inotify

[]; }; The integer fields must be byte-swapped to the target endianness. Signed-off-by: Laurent Vivier <laur...@vivier.eu> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- linux-user/syscall.c | 29 + 1 file changed, 29 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v2 10/21] char: useless NULL check

On 02/27/2017 10:41 AM, Marc-André Lureau wrote: g_strdup(NULL) returns NULL already. Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- chardev/char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] e1000: disable debug by default

tman <dmitry.fleyt...@ravellosystems.com> Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang <jasow...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- hw/net/e1000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000.c b/h

Re: [Qemu-devel] [PATCH] doc: fix function spelling

On 03/22/2017 08:52 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/io/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

On 03/22/2017 01:23 PM, Philippe Mathieu-Daudé wrote: On 03/22/2017 10:58 AM, Jeff Cody wrote: On Mon, Mar 20, 2017 at 06:33:04PM +, Peter Maydell wrote: On OpenBSD none of the ioctls probe_logical_blocksize() tries exist, so the variable sector_size is unused. Refactor the code to avoid

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.9?] block/file-posix.c: Fix unused variable warning on OpenBSD

sector_size; +success = true; +} +} return success ? 0 : -errno; } -- 2.7.4 Reviewed-by: Jeff Cody <jc...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

Re: [Qemu-devel] [PATCH v2 6/9] [optional] hw: misc: added testdev for smmu

Hi Prem, On 08/22/2016 01:17 PM, Prem Mallappa wrote: A simple PCI device which does DMA from 'src' to 'dst' given src_addr, dst_addr and size, and is used by unit test. uses pci_dma_read and pci_dma_write in a crude way but serves the purpose. Signed-off-by: Prem Mallappa

Re: [Qemu-devel] [PATCH v2] Fix input-linux reading from device

Hi Javier, can you add a line to explain what did you change between v1/v2? Thank, Phil. On 03/26/2017 06:53 AM, Javier Celaya wrote: The evdev devices in input-linux.c are read in blocks of one whole event. If there are not enough bytes available, they are discarded, instead of being kept

Re: [Qemu-devel] [PATCH 1/2] slirp: Make RA build more flexible

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/ip6_icmp.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c index 298a48dd25..d0f5cc1456 100644 --- a/slirp/ip6_icmp.c +++ b/slirp/ip6_icmp.c @@

Re: [Qemu-devel] [PATCH 2/2] slirp: Send RDNSS in RA only if host has an IPv6 DNS server

Hi Samuel, On 03/26/2017 03:46 PM, Samuel Thibault wrote: Previously we would always send an RDNSS option in the RA, making the guest try to resolve DNS through IPv6, even if the host does not actually have and IPv6 DNS server available. This makes the RDNSS option enabled only when an IPv6

Re: [Qemu-devel] [PATCH for-2.9 v2] tests/bios-tables-test: Don't pass addresses of packed struct fields

rather than addresses of packed structure fields to glib functions like g_file_get_contents() to avoid this bug. Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v1->v2 changes: put the assignments after we check t

Re: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c

Hi Saurav, you should read the QEMU Coding Style and replace your tabs by 4 spaces. On 03/20/2017 02:38 PM, Saurav Sachidanand wrote: Change malloc/strdup/free to g_malloc/g_strdup/g_free in util/envlist.c. Remove NULL checks for pointers returned from g_malloc and g_strdup as they exit in

Re: [Qemu-devel] [PATCH for-2.9 1/2] tcg/sparc: Zero extend data argument to store helpers

Hi Peter, On 03/27/2017 01:04 PM, Peter Maydell wrote: The C store helper functions take the data argument as a uint8_t, uint16_t, etc depending on the store size. The SPARC calling convention requires that data types smaller than the register size must be extended by the caller. We weren't

Re: [Qemu-devel] [PATCH] slirp: fix compilation errors with DEBUG set

wed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- slirp/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 60539de..5a94b06 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -198,7 +198,7 @@ static int get_dns_addr_resolv_conf(in

Re: [Qemu-devel] [PATCH v2 for-2.9 1/2] tcg/sparc: Zero extend data argument to store helpers

Maydell <peter.mayd...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- v1->v2: fix incorrect argument order to emit_extend() for sparc32 codepath; switch on op & MO_SIZE rather than just op. --- tcg/sparc/tcg-target.inc.c | 25 +

[Qemu-devel] [PATCH RESEND 1/3] usb-ccid: make ccid_write_data_block() cope with null buffers

static code analyzer complain: hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy(p->abData, data, len); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@ams

Re: [Qemu-devel] rawhide gcc failures [was: Proposal for deprecating unsupported host OSes & architecutures]

so lovely... as a start point for bleeding edge stuff this can go in CI as a complement of debian images in tests/docker/... using the official fedora:rawhide base image. On 03/22/2017 04:07 PM, Eric Blake wrote: On 03/16/2017 10:23 AM, Peter Maydell wrote: OK, here's a concrete proposal

[Qemu-devel] [PATCH RESEND 0/3] easy-to-fix clang warnings

This patchset fixes three easy-to-fix clang warnings. Resent adding Marc-André Lureau's Reviewed-by and CC'ing qemu-trivial as suggested by Markus Armbruster. Philippe Mathieu-Daudé (3): usb-ccid: make ccid_write_data_block() cope with null buffers device_tree: fix compiler warnings (clang 5

[Qemu-devel] [PATCH RESEND 2/3] device_tree: fix compiler warnings (clang 5)

static code analyzer complain: device_tree.c:155:18: warning: Null pointer passed as an argument to a 'nonnull' parameter while ((de = readdir(d)) != NULL) { ^~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.

[Qemu-devel] [PATCH RESEND 3/3] qga: fix compiler warnings (clang 5)

static code analyzer complain: qga/commands-posix.c:2127:9: warning: Null pointer passed as an argument to a 'nonnull' parameter closedir(dp); ^~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Marc-André

Re: [Qemu-devel] [PATCH v3 for-2.9?] virtio: fix vring_align() on 64-bit windows

which does not suffer the same problem Signed-off-by: Andrew Baumann <andrew.baum...@microsoft.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> --- include/hw/virtio/virtio.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

  1   2   3   4   5   6   7   8   9   10   >