Re: [Qemu-devel] [PATCH v2] savevm: Really verify if a drive supports snapshots

2010-05-31 Thread Kevin Wolf
Am 29.05.2010 21:55, schrieb Miguel Di Ciurcio Filho: Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten?

Re: [Qemu-devel] [PATCH v2] savevm: Really verify if a drive supports snapshots

2010-05-31 Thread Miguel Di Ciurcio Filho
On Mon, May 31, 2010 at 6:59 AM, Kevin Wolf kw...@redhat.com wrote:  int bdrv_snapshot_create(BlockDriverState *bs,                           QEMUSnapshotInfo *sn_info)  {      BlockDriver *drv = bs-drv; -    if (!drv) -        return -ENOMEDIUM; -    if (!drv-bdrv_snapshot_create) -      

[Qemu-devel] [PATCH v2] savevm: Really verify if a drive supports snapshots

2010-05-29 Thread Miguel Di Ciurcio Filho
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. First issue: Their names implies different porpouses, but they do the same thing and have exactly the same code. Maybe copied and pasted and forgotten? bdrv_has_snapshot() is called in various places for actually