Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-15 Thread Markus Armbruster
Justinien Bouron writes: > Depending on your use-case, it might be inconvenient to have qemu grab > the input device immediately upon starting the guest, especially if the > guest takes a while to start in which case it may take a few seconds > before being able to release the device via the

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-15 Thread Marc-André Lureau
Hi Justinien On Fri, Mar 15, 2024 at 6:37 AM Justinien Bouron wrote: > > Just a ping to make sure this patch hasn't been lost in the noise. > Any chance to get this merged? Should I send a v2 with a revised commit > message? > It's too late for 9.0. Please send a v2 with updated commit

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-14 Thread Justinien Bouron
Just a ping to make sure this patch hasn't been lost in the noise. Any chance to get this merged? Should I send a v2 with a revised commit message? Regards, Justinien

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-08 Thread Justinien Bouron
> > > This last two lines doesn't make sense to me. Isn't the grab > > > toggling entirely in control of the QEMU process, regardless > > > of what state the guest is at ? > > > > Actually, you're right, they do not make sense. This issue of having the > > guest > > taking a while to start and

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-08 Thread Daniel P . Berrangé
On Thu, Mar 07, 2024 at 07:38:27PM -0800, Justinien Bouron wrote: > > This last two lines doesn't make sense to me. Isn't the grab > > toggling entirely in control of the QEMU process, regardless > > of what state the guest is at ? > > Actually, you're right, they do not make sense. This issue of

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-07 Thread Justinien Bouron
> This last two lines doesn't make sense to me. Isn't the grab > toggling entirely in control of the QEMU process, regardless > of what state the guest is at ? Actually, you're right, they do not make sense. This issue of having the guest taking a while to start and the toggle keys not working,

Re: [PATCH] input-linux: Add option to not grab a device upon guest startup

2024-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2024 at 10:28:22PM -0800, Justinien Bouron wrote: > Depending on your use-case, it might be inconvenient to have qemu grab > the input device immediately upon starting the guest, especially if the > guest takes a while to start in which case it may take a few seconds > before being