[R] For Hadley Wickham: Need for a small fix in haven::read_spss

2015-07-20 Thread Dimitri Liakhovitski
Hadley, you've added function labelled to haven, which is great. However, when it so happens that in SPSS a variable has no long label, your code considers it to be NULL rather than an NA. NULL is correct, but NA would probably be better. For example, I've read in an SPSS file: library(haven)

Re: [R] For Hadley Wickham: Need for a small fix in haven::read_spss

2015-07-20 Thread Hadley Wickham
(FWIW this would've been better send to me directly or filed on github, rather than sent to R-help) I think this is more of a problem with the way that you're accessing the info, than the design of the underlying structure. I'd do something like this: attr_default - function(x, which, default) {

Re: [R] For Hadley Wickham: Need for a small fix in haven::read_spss

2015-07-20 Thread Dimitri Liakhovitski
Thank you, Hadley. Yes, you are right - next time I'll email you directly. On Mon, Jul 20, 2015 at 10:01 AM, Hadley Wickham h.wick...@gmail.com wrote: (FWIW this would've been better send to me directly or filed on github, rather than sent to R-help) I think this is more of a problem with the