Re: [Rails-core] [patch] ruby 1.8.5 warnings

2006-07-31 Thread Nicholas Seckar
Damn that's ugly. I'd rather stay on 1.8.4...On 7/31/06, Courtenay [EMAIL PROTECTED] wrote: When running ruby 1.8.5 (latest, stable) a bunch of warnings show up.activerecord/lib/active_record/connection_adapters/oracle_adapter.rb:500:warning: colon will be obsoleted; use semicolonIt seems that

Re: Re: [Rails-core] [patch] ruby 1.8.5 warnings

2006-07-31 Thread Courtenay
Haha.. it kinda makes sense, since the semicolon is breaking a line.. I guess my reason for the patch was that there is inconsistency across rails, with a mix of then, colon, semicolon, and newline.. any thoughts on what it should be? On 7/31/06, Nicholas Seckar [EMAIL PROTECTED] wrote: Damn

Re: Re: Re: [Rails-core] [patch] ruby 1.8.5 warnings

2006-07-31 Thread David Heinemeier Hansson
I guess my reason for the patch was that there is inconsistency across rails, with a mix of then, colon, semicolon, and newline.. any thoughts on what it should be? Very much depends on what makes sense in the context. I often use different conditional styles depending on the particulars. Not