Re: Formating issues in the 1.3 line

line if there are class docstrings or variables at the top of the function... The commit log could be something like : This patch (patch__function_spacing__1.3_r3341) fixes function spacing formating issues in the 1.3 line (r3341). The convention is to leave two empty lines before a function

Re: Formating issues in the 1.3 line

spacing formating issues in the 1.3 line (r3341). The convention is to leave two empty lines before a function definition. The issues were found with the code_validator script and filtered so that when a function definition followed a class docstring or class variable, only one empty line is left instead

Re: Formating issues in the 1.3 line

Hi, For this patch, most of the changes are good as it makes all functions have 2 empty lines between them. However for the spacing above the first function within a class, I would recommend only one space if there is a class docstring or class variables at the top. Two empty lines here is not

Re: Formating issues in the 1.3 line

Hi, Here is a patch that fixes function spacing (2 preceding empty lines) issues of the 1.3 line (r3340), except when a commented line precedes the function (like at line 31 of 'maths_fns/ri.py'). Cheers ! Séb :) Selon Sébastien Morin [EMAIL PROTECTED], 11.07.2007: Oups... The file

Re: Formating issues in the 1.3 line

Hi, Here is a patch for revision 3339 of line 1.3 concerning all indentation issues (without the tab issues inside the OpenDX strings. This small patch modifies solely 2 files ('test_suite/system_tests/model_free.py' and 'float.py') Ciao ! Séb Selon Edward d'Auvergne [EMAIL PROTECTED],

Re: Formating issues in the 1.3 line

Oups... The file wasn't loaded onto the server when I pressed 'send'. Sorry for that. It seems I should finish my coffee before sending mails... Ciao ! Séb :P Selon Sébastien Morin [EMAIL PROTECTED], 11.07.2007: Hi, Here is a patch for revision 3339 of line 1.3 concerning all

Re: Formating issues in the 1.3 line

Hi again ! Here is a patch solving indentation issues in the 1.3 line code (revision 3338). Ciao ! Sébastien :) Selon Sébastien Morin [EMAIL PROTECTED], 10.07.2007: Hi, Here is a patch for trailing whitespaces in the code for the 1.3 line (revision 3338). This should fix all

Re: Formating issues in the 1.3 line

Hi again ! Here is a small patch for indentation problems again, but now for tabs... Cheers Séb Selon Sébastien Morin [EMAIL PROTECTED], 10.07.2007: Hi Ed ! In fact, I thought about this but wasn't sure... Here is the patch without the modification to the code where it should end in

Re: Formating issues in the 1.3 line

Hi, I've committed this 1.3 line patch to the repository (r3339). I specificially excluded the 'dx/isosurface_3D.py' file because these changes could have caused the OpenDX programs to fail (the text output with trailing whitespace was generated by OpenDX itself, and therefore removing it might

Formating issues in the 1.3 line

Hi all, Here are a few patches solving fomating issues in the 1.3 line (revision 3324). patch_sample_scripts_palmer - sample_scripts/palmer.py patch_test_suite_runner - sample_scripts/relax_curve_diff.py patch_sample_scripts_relax_curve_diff-

Re: Formating issues in the 1.3 line

Hi again Here are other patches for solving formating issues in the 1.3 line. patch_test_suite_unit_tests_data_test_diff_tensor test_suite/unit_tests/data/test_diff_tensor.py patch_test_suite_unit_tests_data_test___init__ test_suite/unit_tests/data/test___init__.py

Re: Formating issues in the 1.3 line

Hi, These minor formatting changes do need to made to the repository. Would you still have all the changes in your checked out copy Séb? If you could send a single patch of all the changes, it will be much easier for me to apply. That would be much appreciated. Thanks, Edward On 7/9/07,

Re: Formating issues in the 1.3 line

Hi Ed ! I will send a single large patch tomorrow when I have corrected more code... Bye Séb Edward d'Auvergne wrote: Hi, These minor formatting changes do need to made to the repository. Would you still have all the changes in your checked out copy Séb? If you could send a single

Re: Formating issues in the 1.3 line

Thanks. Please try to keep different types of changes separate though. All the changes so far are whitespace related so I can commit the patch as fixing whitespace formatting in the 1.3 line. If there are other changes, these should go as separate commits into the relax repository. That way I