Re: r22427 - /trunk/lib/rotating_frame.py

2014-03-07 Thread Troels Emtekær Linnet
Hi Edward. How should I handle the value.write function? I was thinking of adding w_eff and Delta_omega as parameters, like these commits: r22409 - /trunk/specific_analyses/relax_disp/api.py http://www.mail-archive.com/relax-commits@gna.org/msg20031.html r22411 -

Re: r22427 - /trunk/lib/rotating_frame.py

2014-03-07 Thread Edward d'Auvergne
Hi, I think that the value.write function is not the best for this, as this data is too complicated. It does not work for the dispersion points either. Nevertheless it can be used. If you look at were the value is obtained in the pipe_control.value.write_data() function, you will see the

Re: r22436 - /trunk/specific_analyses/relax_disp/disp_data.py

2014-03-07 Thread Edward d'Auvergne
Hi Troels, I was just wondering what the purpose of these Domega values would be? Do you plan on allowing them to be output? It would be useful to include the purpose somewhere in the commit message. Cheers, Edward On 7 March 2014 13:21, tlin...@nmr-relax.com wrote: Author: tlinnet

Re: r22438 - /trunk/specific_analyses/relax_disp/disp_data.py

2014-03-07 Thread Edward d'Auvergne
Here I would recommend listing the dimensions for w_e in the docstring for the return value. That allows future users of the method to know what the structure of w_e they should expect. Cheers, Edward On 7 March 2014 13:21, tlin...@nmr-relax.com wrote: Author: tlinnet Date: Fri Mar 7

Re: r22440 - /trunk/specific_analyses/relax_disp/disp_data.py

2014-03-07 Thread Edward d'Auvergne
Hi, I have a recommendation for the print statements for this function. There are quite a lot, and most users will probably not be interested in seeing them. Therefore you could set a verbosity argument for the function which defaults to False. If it is set to True, then the print statements

Re: r22427 - /trunk/lib/rotating_frame.py

2014-03-07 Thread Edward d'Auvergne
Oh, I forgot to mention the following. Whenever you are in the pipe_control modules and you need data from the specific analyses, then you need to call the methods of the analysis specific API. This is the standardised way in relax to access specific data so that the code, which is mainly user