[GitHub] spark pull request: [SPARK-15417][SQL][Python] PySpark shell alway...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13203#issuecomment-220456044 **[Test build #58904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58904/consoleFull)** for PR 13203 at commit

[GitHub] spark pull request: [SPARK-15417][SQL][Python] PySpark shell alway...

2016-05-19 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/13203 [SPARK-15417][SQL][Python] PySpark shell always uses in-memory catalog ## What changes were proposed in this pull request? There is no way to use the Hive catalog in `pyspark-shell`.

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220454531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220454535 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220454396 **[Test build #58901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58901/consoleFull)** for PR 12938 at commit

[GitHub] spark pull request: [SPARK-14279] [Build] Pick the spark version f...

2016-05-19 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/13061#discussion_r6396 --- Diff: project/SparkBuild.scala --- @@ -435,7 +438,19 @@ object SparkBuild extends PomBuild { else x.settings(Seq[Setting[_]](): _*)

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220453725 **[Test build #58903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58903/consoleFull)** for PR 13163 at commit

[GitHub] spark pull request: [SPARK-15413] [ML] [MLLIB] Change `toBreeze` t...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13198#issuecomment-220453068 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15413] [ML] [MLLIB] Change `toBreeze` t...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13198#issuecomment-220453075 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15413] [ML] [MLLIB] Change `toBreeze` t...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13198#issuecomment-220452813 **[Test build #58889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58889/consoleFull)** for PR 13198 at commit

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-19 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/13155#discussion_r63954767 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1648,16 +1648,56 @@ object

[GitHub] spark pull request: [SPARK-15414][MLlib] Make the mllib,ml linalg ...

2016-05-19 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13202#issuecomment-220450350 cc: @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15416][SQL]Display a better message for...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220449991 **[Test build #58902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58902/consoleFull)** for PR 13201 at commit

[GitHub] spark pull request: [SPARK-15416][SQL]Display a better message for...

2016-05-19 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220449305 There are many space changes. Please use this link https://github.com/apache/spark/pull/13201/files?w=1 to review. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-15416][SQL]Display a better message for...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220448993 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15416][SQL]Display a better message for...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220448990 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220448741 **[Test build #58901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58901/consoleFull)** for PR 12938 at commit

[GitHub] spark pull request: [SPARK-15416][PySpark]Display a better message...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220448864 **[Test build #58898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58898/consoleFull)** for PR 13201 at commit

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-19 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/13102#issuecomment-220448360 @rxin Thank you reynold for handling this. It was taking me a lot of time to understand the dependencies. Thanks again .. I will close this now. --- If

[GitHub] spark pull request: [SPARK-15075] [SQL] Cleanup dependencies betwe...

2016-05-19 Thread dilipbiswal
Github user dilipbiswal closed the pull request at: https://github.com/apache/spark/pull/13102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220447765 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220447762 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220447465 **[Test build #58890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58890/consoleFull)** for PR 13197 at commit

[GitHub] spark pull request: [SPARK-15412][PySpark][SparkR][DOCS] Improve l...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13199#issuecomment-220447414 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15414][MLlib] Make the mllib,ml linalg ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13202#issuecomment-220447471 **[Test build #58900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58900/consoleFull)** for PR 13202 at commit

[GitHub] spark pull request: [SPARK-15412][PySpark][SparkR][DOCS] Improve l...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13199#issuecomment-220447421 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220447148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220447151 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15412][PySpark][SparkR][DOCS] Improve l...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13199#issuecomment-220447086 **[Test build #5 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)** for PR 13199 at commit

[GitHub] spark pull request: [SPARK-15414][MLlib] Make the mllib,ml linalg ...

2016-05-19 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13202 [SPARK-15414][MLlib] Make the mllib,ml linalg type conversion APIs public ## What changes were proposed in this pull request? Open up APIs for converting between new, old linear algebra

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-220446944 @jkbradley see the discussion/proposed solutions on https://github.com/apache/spark/pull/12914 --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220446855 **[Test build #58884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58884/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220446766 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220446770 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220446712 **[Test build #58899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58899/consoleFull)** for PR 13200 at commit

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220443688 **[Test build #58899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58899/consoleFull)** for PR 13200 at commit

[GitHub] spark pull request: [SPARK-15416][PySpark]Display a better message...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13201#issuecomment-220443676 **[Test build #58898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58898/consoleFull)** for PR 13201 at commit

[GitHub] spark pull request: [SPARK-15416][PySpark]Display a better message...

2016-05-19 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/13201 [SPARK-15416][PySpark]Display a better message for not finding classes removed in Spark 2.0 ## What changes were proposed in this pull request? If finding `NoClassDefFoundError` or

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13200#issuecomment-220442699 Note that I still need to add some tests to cover the behavior of the new builders. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-15075][SQL] Cleanup dependencies betwee...

2016-05-19 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/13200 [SPARK-15075][SQL] Cleanup dependencies between SQLContext and SparkS… ## What changes were proposed in this pull request? Currently SparkSession.Builder use SQLContext.getOrCreate. It should

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220442073 @andrewor14 comments addressed + ran `lint-java` locally and fixed all the issues. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-220442030 LGTM Merging with master and branch-2.0 Thanks! @holdenk We can discuss this Pyspark Params issue more. I agree it will be important to offer users

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220441597 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220441596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220441446 **[Test build #58893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58893/consoleFull)** for PR 13101 at commit

[GitHub] spark pull request: [SPARK-15413] [ML] [MLLIB] Change `toBreeze` t...

2016-05-19 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/13198#issuecomment-220438703 +cc @jkbradley @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13197 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220438005 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220438006 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220437845 **[Test build #58891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58891/consoleFull)** for PR 13197 at commit

[GitHub] spark pull request: [SPARK-15388][SQL] Fix spark sql CREATE FUNCTI...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13177#issuecomment-220437364 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15388][SQL] Fix spark sql CREATE FUNCTI...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13177#issuecomment-220437363 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13139#issuecomment-220437293 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13139#issuecomment-220437291 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13139#issuecomment-220437188 **[Test build #58897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58897/consoleFull)** for PR 13139 at commit

[GitHub] spark pull request: [SPARK-15388][SQL] Fix spark sql CREATE FUNCTI...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13177#issuecomment-220437120 **[Test build #58886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58886/consoleFull)** for PR 13177 at commit

[GitHub] spark pull request: [SPARK-15370] [SQL] Update RewriteCorrelatedSc...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13155#discussion_r63945219 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1648,16 +1648,56 @@ object

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220436565 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220436570 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220436538 **[Test build #58895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58895/consoleFull)** for PR 12938 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63943856 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,35 @@ class CodegenContext {

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220435752 actually maybe cc @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63944461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -78,8 +77,9 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63944155 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -717,6 +751,20 @@ abstract class

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220435143 cc @sameeragarwal for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13139#issuecomment-220434968 **[Test build #58897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58897/consoleFull)** for PR 13139 at commit

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12943#issuecomment-220434621 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12943#issuecomment-220434625 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12943#issuecomment-220434443 **[Test build #58894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58894/consoleFull)** for PR 12943 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63943606 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,35 @@ class CodegenContext {

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220434211 Looks good, just a remaining nit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13163#discussion_r63943470 --- Diff: launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java --- @@ -59,6 +59,16 @@ public void testClusterCmdBuilder()

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on the pull request: https://github.com/apache/spark/pull/13139#issuecomment-220434180 I addressed the review comments. Please let me know what else there is. Also, @yanboliang I'd be happy to add specific differences between R and Spark if you have some

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63943394 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala --- @@ -224,7 +224,9 @@ object GenerateColumnAccessor

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13139#discussion_r63943317 --- Diff: docs/ml-classification-regression.md --- @@ -374,6 +374,197 @@ regression model and extracting model summary statistics. +##

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13139#discussion_r63943262 --- Diff: docs/ml-classification-regression.md --- @@ -374,6 +374,197 @@ regression model and extracting model summary statistics. +##

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/13163#discussion_r63943269 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java --- @@ -147,7 +156,7 @@ List args = new ArrayList<>();

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13045#issuecomment-220433675 **[Test build #58896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58896/consoleFull)** for PR 13045 at commit

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13139#discussion_r63943165 --- Diff: docs/ml-classification-regression.md --- @@ -374,6 +374,197 @@ regression model and extracting model summary statistics. +##

[GitHub] spark pull request: [SPARK-14525][SQL] Make DataFrameWrite.save wo...

2016-05-19 Thread JustinPihony
Github user JustinPihony commented on the pull request: https://github.com/apache/spark/pull/12601#issuecomment-220431230 I just updated the branch to have no conflicts. Again, either the code looks good to merge, or I can make JDBC a `CreatableRelationProvider` (but that comes with

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12943#issuecomment-220431086 **[Test build #58894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58894/consoleFull)** for PR 12943 at commit

[GitHub] spark pull request: [SPARK-15162][SPARK-15164][PySpark][DOCS][ML] ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12938#issuecomment-220431095 **[Test build #58895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58895/consoleFull)** for PR 12938 at commit

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220431087 **[Test build #58893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58893/consoleFull)** for PR 13101 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220429840 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13188#issuecomment-220429808 **[Test build #58892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58892/consoleFull)** for PR 13188 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220429839 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220429568 **[Test build #58880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58880/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

2016-05-19 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63940722 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

2016-05-19 Thread sameeragarwal
Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63940752 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,106 @@ +/*

[GitHub] spark pull request: [SPARK-15092][SPARK-15139][PYSPARK][ML] Pyspar...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12919#issuecomment-220424235 **[Test build #58887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58887/consoleFull)** for PR 12919 at commit

[GitHub] spark pull request: [SPARK-15411] [ML] Add @since to ml.stat.Multi...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13197#issuecomment-220426130 **[Test build #58891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58891/consoleFull)** for PR 13197 at commit

[GitHub] spark pull request: [SPARK-15130][PySpark][ML][DOCS] pyspark expos...

2016-05-19 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12914#issuecomment-220426013 Personally I'm in favor of #2 or #3 since they would both give us nice looking documentation on par with that of the Scala side. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-15092][SPARK-15139][PYSPARK][ML] Pyspar...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12919#issuecomment-220424374 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Branch 2.0

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13089#issuecomment-220425293 @ahnqirage please close this PR. It seems to be opened by mistake. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11574][Core] Add metrics StatsD sink

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9518#issuecomment-220423703 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Problem select empty ORC table

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13103#issuecomment-220425159 Let's close this PR. This patch isn't opened against the correct branch anyway. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [Core] Remove unnecessary calculation of stage...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13123#issuecomment-220424954 @sharkdtu please file a JIRA and add it to the title. Otherwise let's close this PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-15388][SQL] Fix spark sql CREATE FUNCTI...

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13177#issuecomment-220424714 By the way, great catch @wangyang1992! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15367] [SQL] Add refreshTable back

2016-05-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13156#issuecomment-220424613 LGTM other than the renaming. We shouldn't have `spark.catalog.refreshTable` and `spark.sessionState.refreshTable` do different things. I would rename the latter to

<    1   2   3   4   5   6   7   8   9   >