[GitHub] spark pull request: [SPARK-15362] [ML] Make spark.ml KMeansModel l...

2016-05-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13149#issuecomment-220394198 LGTM Merging with master and branch-2.0 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63919939 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,60 @@ class CodegenContext {

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63919915 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -740,6 +813,9 @@ abstract class

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63919385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -717,6 +776,20 @@ abstract class

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r6391 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -740,6 +813,9 @@ abstract class

[GitHub] spark pull request: [SPARK-15390] fix broadcast with 100 millions ...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13182#issuecomment-220392230 **[Test build #58877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58877/consoleFull)** for PR 13182 at commit

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63918627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -124,6 +124,7 @@

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63916719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,60 @@ class CodegenContext {

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63918110 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -124,6 +124,7 @@ object

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220390916 **[Test build #58873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58873/consoleFull)** for PR 13163 at commit

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220390947 **[Test build #58875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58875/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220390918 **[Test build #58874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58874/consoleFull)** for PR 13087 at commit

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-220390952 **[Test build #58876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58876/consoleFull)** for PR 12313 at commit

[GitHub] spark pull request: [SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Sh...

2016-05-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13027#issuecomment-220390625 @lianhuiwang This PR is useful, other people could easily patch it by themselves, thanks for it. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15360][Spark-Submit]Should print spark-...

2016-05-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/13163#issuecomment-220389680 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63916714 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -124,6 +124,7 @@

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread rdblue
Github user rdblue commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-220389967 @cloud-fan, @liancheng, thanks for reviewing! I've rebased on master and fixed your comments so far. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63916876 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -706,6 +711,60 @@ class CodegenContext {

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63917072 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -740,6 +813,9 @@ abstract class

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220390039 @sarutak I like this idea, could you simplify it and minimize the changes? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12979#discussion_r63915953 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -717,6 +776,20 @@ abstract class

[GitHub] spark pull request: [SPARK-15078][SQL] Add all TPCDS 1.4 benchmark...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13188#discussion_r63915743 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/tpcds/TPCDSQueryBenchmark.scala --- @@ -0,0 +1,106 @@ +/* +

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915441 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -269,6 +270,81 @@ class HiveCommandSuite extends

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63915288 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala --- @@ -24,13 +24,13 @@ package

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915128 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-14670][SQL][WIP] allow updating driver ...

2016-05-19 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13189#issuecomment-220385998 @cloud-fan Could you have a screen shot for metrics of BroadcastExchange ? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14670][SQL][WIP] allow updating driver ...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13189#discussion_r63914891 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala --- @@ -360,17 +370,27 @@ private[spark] class SQLHistoryListener(conf:

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63914894 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-14670][SQL][WIP] allow updating driver ...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13189#discussion_r63914100 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala --- @@ -66,25 +67,25 @@ case class

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2016-05-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/10061#discussion_r63914121 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -96,6 +100,7 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63913511 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateMutableProjection.scala --- @@ -124,6 +124,7 @@ object

[GitHub] spark pull request: [SPARK-11206] Support SQL UI on the history se...

2016-05-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/10061#discussion_r63913361 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -96,6 +100,7 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-19 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13192#discussion_r63913005 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala --- @@ -24,13 +24,13 @@ package

[GitHub] spark pull request: [SPARK-15309] Bump master to version 2.1.0-SNA...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13092#issuecomment-220381427 @l15k4 you can build from branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63912066 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63912028 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63912009 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13142#issuecomment-220378020 **[Test build #58870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58870/consoleFull)** for PR 13142 at commit

[GitHub] spark pull request: [SPARK-15176][Core] Add maxShares setting to P...

2016-05-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/12951#discussion_r63911572 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala --- @@ -90,10 +92,16 @@ private[spark] class FairSchedulableBuilder(val

[GitHub] spark pull request: [SPARK-15176][Core] Add maxShares setting to P...

2016-05-19 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/12951#issuecomment-220379391 Hi @njwhite, I'm not sure I see a strong need for this -- I posted a msg on jira (as Kay had earlier). We should keep discussion about the feature in general there,

[GitHub] spark pull request: [SPARK-15176][Core] Add maxShares setting to P...

2016-05-19 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/12951#issuecomment-220379290 I commented on the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220378999 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220378989 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220378688 **[Test build #58871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58871/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13142#issuecomment-220378345 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13142#issuecomment-220378344 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220375820 **[Test build #58872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58872/consoleFull)** for PR 10125 at commit

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63908615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63908465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -348,28 +348,41 @@ case class

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220373752 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220373756 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220373429 **[Test build #58869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58869/consoleFull)** for PR 10125 at commit

[GitHub] spark pull request: [SPARK-15269][SQL] Set provided path to Catalo...

2016-05-19 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/13120#discussion_r63903975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -354,7 +356,27 @@ object

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread kevinyu98
Github user kevinyu98 commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220361041 I will push the latest one after jenkins finish. Thanks very much ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63900108 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -163,7 +168,9 @@ void validateDataFrameWithBeans(Bean bean,

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63900146 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -182,6 +189,8 @@ void validateDataFrameWithBeans(Bean bean,

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220357884 mostly LGTM, pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2016-05-19 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-220357498 For com.fasterxml.jackson.core:jackson-core, I only see 2.7.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63897785 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -182,6 +189,8 @@ void validateDataFrameWithBeans(Bean bean,

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63897657 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java --- @@ -163,7 +168,9 @@ void validateDataFrameWithBeans(Bean bean,

[GitHub] spark pull request: [SPARK-11753][SQL] Make allowNonNumericNumbers...

2016-05-19 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-220355804 Looks like paranamer:2.3 is used by avro. +-org.apache.avro:avro-compiler:1.7.3 | +-commons-lang:commons-lang:2.6 | +-org.apache.avro:avro:1.7.3

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63896316 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -348,28 +348,41 @@ case class

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63896053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-14543] [SQL] Improve InsertIntoTable co...

2016-05-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12313#discussion_r63895917 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -498,6 +499,117 @@ class Analyzer( } }

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

2016-05-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13142#issuecomment-220350310 @rxin yeah. To help code review, I split the code changes to two separate commits, as shown below [1) rename two

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220350425 **[Test build #58871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58871/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15358] [TEST] Rename HiveDDLCommandSuit...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13142#issuecomment-220350381 **[Test build #58870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58870/consoleFull)** for PR 13142 at commit

[GitHub] spark pull request: [SPARK-15296][MLlib] Refactor All Java Tests t...

2016-05-19 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13101#issuecomment-220348713 ping @srowen @andrewor14 @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13139#discussion_r63890860 --- Diff: docs/ml-classification-regression.md --- @@ -374,6 +374,197 @@ regression model and extracting model summary statistics. +##

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220345646 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220347233 **[Test build #58869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58869/consoleFull)** for PR 10125 at commit

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread kevinyu98
Github user kevinyu98 commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220346292 retest it please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-220345648 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15186][ML][DOCS] Add user guide for gen...

2016-05-19 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/13139#discussion_r63890670 --- Diff: docs/ml-classification-regression.md --- @@ -374,6 +374,197 @@ regression model and extracting model summary statistics. +##

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220342987 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220342991 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220342761 **[Test build #58867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58867/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220333996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220334004 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15018][PYSPARK][ML] Fixed bug causing e...

2016-05-19 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/12790#issuecomment-220333799 @BryanCutler Thanks for your clarifying, good point and your proposal makes sense. The only left issue is whether we can figure out a better way to handle

[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220333710 **[Test build #58865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58865/consoleFull)** for PR 13173 at commit

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2016-05-19 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/10125#discussion_r63880607 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala --- @@ -109,6 +109,7 @@ object DecimalType extends AbstractDataType {

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220321546 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220321521 **[Test build #58866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58866/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220321548 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220320973 **[Test build #58867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58867/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15165][SPARK-15205][SQL] Introduce plac...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12979#issuecomment-220319710 **[Test build #58866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58866/consoleFull)** for PR 12979 at commit

[GitHub] spark pull request: [SPARK-15341] [Doc] [ML] Add documentation for...

2016-05-19 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13131#issuecomment-220312991 cc @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15362] [ML] Make spark.ml KMeansModel l...

2016-05-19 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13149#discussion_r63870577 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -206,11 +212,21 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-15402] [ML] [PySpark] PySpark ml.evalua...

2016-05-19 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13194#issuecomment-220311748 cc @jkbradley @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [Minor] [ML] [PySpark] ml.evaluation Scala and...

2016-05-19 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/13195#issuecomment-220311690 cc @MLnick @jkbradley --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15269][SQL] Set provided path to Catalo...

2016-05-19 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13120#discussion_r63869408 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -354,7 +356,27 @@ object

[GitHub] spark pull request: [SPARK-14346][SQL] Lists unsupported Hive feat...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13173#issuecomment-220310498 **[Test build #58865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58865/consoleFull)** for PR 13173 at commit

[GitHub] spark pull request: [SPARK-15402] [ML] [PySpark] PySpark ml.evalua...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13194#issuecomment-220300668 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300727 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300728 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15402] [ML] [PySpark] PySpark ml.evalua...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13194#issuecomment-220300669 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300558 **[Test build #58859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58859/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15402] [ML] [PySpark] PySpark ml.evalua...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13194#issuecomment-220300587 **[Test build #58864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58864/consoleFull)** for PR 13194 at commit

<    2   3   4   5   6   7   8   9   >