[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13065 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 True. That is why I do not know which is the best way for us to show the argument/parameter names. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/13065 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 These function docs are printed onto the console. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`No...

2016-11-19 Thread aditya1702
Github user aditya1702 closed the pull request at: https://github.com/apache/spark/pull/15940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread aditya1702
Github user aditya1702 commented on the issue: https://github.com/apache/spark/pull/15940 @HyukjinKwon @rxin Yes I think I got confused as pointed out by Hyukjin above 😅 . @HyukjinKwon you can take this one over and cc me. I will work on another issue. Sorry for the troubles ---

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15677 Normally, most RDBMS docs are using _Italic fonts_ for the parameter/argument names. Linux man is using `underscore` to highlight argument names in descriptions. I also saw another way ```

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15717 Let us first resolve the paser/syntax-related issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #15717: [SPARK-17910][SQL] Allow users to update the comm...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15717#discussion_r88794337 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -93,6 +93,8 @@ statement SET TBLPROPERTIES

[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15935 cc @joshrosen and @zsxwing too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15677 Some of them already had backricks in the description and others did not. Matching it up with backticks was initially suggested by

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68900/ Test PASSed. ---

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68900/consoleFull)** for PR 15913 at commit

[GitHub] spark pull request #15717: [SPARK-17910][SQL] Allow users to update the comm...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15717#discussion_r88794139 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala --- @@ -694,19 +694,6 @@ class DDLCommandSuite extends

[GitHub] spark issue #15717: [SPARK-17910][SQL] Allow users to update the comment of ...

2016-11-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15717 How about the partition columns of partitioned Hive serde tables? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15677: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15677 @HyukjinKwon why did we add backticks to surround all parameters? It looks pretty weird actually. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15937: [SPARK-18508][SQL] Fix documentation error for DateDiff

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15937 Thanks I will fix that too. Merging this in master/branch-2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15907 Merging in master/branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88794022 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/RadixSort.java --- @@ -40,28 +42,28 @@ * of always copying the data

[GitHub] spark pull request #15943: [SPARK-18511] Added an api for join operations ju...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15943#discussion_r88794018 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -705,12 +701,10 @@ class Dataset[T] private[sql]( * * @param

[GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...

2016-11-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15877#discussion_r88793956 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala --- @@ -0,0 +1,150 @@ +/* + *

[GitHub] spark issue #15942: [SPARK-18407] Inferred partition columns cause assertion...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15942 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15942: [SPARK-18407] Inferred partition columns cause assertion...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15942 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68899/ Test FAILed. ---

[GitHub] spark issue #15942: [SPARK-18407] Inferred partition columns cause assertion...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15942 **[Test build #68899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68899/consoleFull)** for PR 15942 at commit

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15940 Ah, @aditya1702, I assume, from the title, you meant to do this for Python documentation. Actually, the PR you pointed out deals with all of Scala/Java documentation if I haven’t missed some.

[GitHub] spark issue #15943: [SPARK-18511] Added an api for join operations just on c...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15943 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15943: [SPARK-18511] Added an api for join operations ju...

2016-11-19 Thread shiv4nsh
GitHub user shiv4nsh opened a pull request: https://github.com/apache/spark/pull/15943 [SPARK-18511] Added an api for join operations just on column name and the join type Added an api for join operations just on column name and the join type. An Api in which we do not have to

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68900/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15913 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15942: [SPARK-18407] Inferred partition columns cause assertion...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15942 **[Test build #68899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68899/consoleFull)** for PR 15942 at commit

[GitHub] spark pull request #15942: [SPARK-18407] Inferred partition columns cause as...

2016-11-19 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/15942 [SPARK-18407] Inferred partition columns cause assertion error in StructuredStreaming ## What changes were proposed in this pull request? It turns out we are a bit enthusiastic when

[GitHub] spark issue #15893: [SPARK-18456][ML][FOLLOWUP] Use matrix abstraction for c...

2016-11-19 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/15893 LGTM. Since this doesn't have impact on performance, and make the codebase cleaner, I merged this PR into master and branch 2.1. Thanks. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #15652: [SPARK-16987] [None] Add spark-default.conf property to ...

2016-11-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15652 Aside from me not liking the API change you're introducing, you need to add a unit test to make sure the feature is working. I suggest taking the scenario I described in a previous comment

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15939 Oh, no. It seems still there are a lot of errors. I just meant to show what I have tried to test with .. :). Thanks for approving! --- If your project is set up for it, you can reply to

[GitHub] spark pull request #15652: [SPARK-16987] [None] Add spark-default.conf prope...

2016-11-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/15652#discussion_r88790872 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2142,9 +2142,10 @@ private[spark] object Utils extends Logging { */ def

[GitHub] spark issue #15941: [SQL][DOC] Fix incorrect `code` tag in docs/sql-programm...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15941 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15941: [SQL][DOC] Fix incorrect `code` tag in docs/sql-programm...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15941 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68898/ Test PASSed. ---

[GitHub] spark issue #15941: [SQL][DOC] Fix incorrect `code` tag in docs/sql-programm...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15941 **[Test build #68898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68898/consoleFull)** for PR 15941 at commit

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15940 Yes, you should check if they are exposed in the API documentation. I intentionally updated only those ones before. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14650 LGTM. There are a few style nits that I'll fix during the merge to avoid another round. Merging to master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #15941: [SQL][DOC] Fix incorrect `code` tag in docs/sql-programm...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15941 **[Test build #68898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68898/consoleFull)** for PR 15941 at commit

[GitHub] spark pull request #15941: [SQL][DOC] Fix incorrect `code` tag in docs/sql-p...

2016-11-19 Thread weiqingy
GitHub user weiqingy opened a pull request: https://github.com/apache/spark/pull/15941 [SQL][DOC] Fix incorrect `code` tag in docs/sql-programming-guide.md ## What changes were proposed in this pull request? This PR is to fix incorrect `code` tag in `sql-programming-guide.md`

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15848 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68897/ Test FAILed. ---

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15848 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15848 **[Test build #68897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68897/consoleFull)** for PR 15848 at commit

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15940 I don't think any of these actually matter, because these functions are not public documentations. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #15932: [SPARK-18448][CORE] SparkSession should implement...

2016-11-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15932#discussion_r88788935 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,6 +649,13 @@ class SparkSession private( } /**

[GitHub] spark pull request #15932: [SPARK-18448][CORE] SparkSession should implement...

2016-11-19 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15932#discussion_r88788917 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,6 +649,13 @@ class SparkSession private( } /** +

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15940 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that...

2016-11-19 Thread aditya1702
Github user aditya1702 commented on the issue: https://github.com/apache/spark/pull/15940 @HyukjinKwon Could you review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #15940: [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`No...

2016-11-19 Thread aditya1702
GitHub user aditya1702 opened a pull request: https://github.com/apache/spark/pull/15940 [SPARK-18447][BUILD][DOCS]Fix `Note:`/`NOTE:`/`Note that` across Pyth… ## What changes were proposed in this pull request? It seems that just like in Scala/Java there is inconsistency

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15848 **[Test build #68897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68897/consoleFull)** for PR 15848 at commit

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15939 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68896/ Test PASSed. ---

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15939 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15939 **[Test build #68896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68896/consoleFull)** for PR 15939 at commit

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15939 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68895/ Test PASSed. ---

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15939 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15939 **[Test build #68895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68895/consoleFull)** for PR 15939 at commit

[GitHub] spark issue #15861: [SPARK-18294][CORE] Implement commit protocol to support...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15861 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15861: [SPARK-18294][CORE] Implement commit protocol to support...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68894/ Test PASSed. ---

[GitHub] spark issue #15861: [SPARK-18294][CORE] Implement commit protocol to support...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15861 **[Test build #68894 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68894/consoleFull)** for PR 15861 at commit

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15939 **[Test build #68896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68896/consoleFull)** for PR 15939 at commit

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68893/ Test FAILed. ---

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68893/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #15939: [SPARK-3359][BUILD][DOCS] Print examples and disable gro...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15939 **[Test build #68895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68895/consoleFull)** for PR 15939 at commit

[GitHub] spark pull request #15939: [SPARK-3359][BUILD][DOCS] Print examples in javad...

2016-11-19 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/15939 [SPARK-3359][BUILD][DOCS] Print examples in javadoc and disable group and tparam tags in javadoc ## What changes were proposed in this pull request? This PR proposes/fixes two things.

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88783349 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88783252 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88783222 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88783173 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88782911 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88782865 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88782853 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark issue #15861: [SPARK-18294][CORE] Implement commit protocol to support...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15861 **[Test build #68894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68894/consoleFull)** for PR 15861 at commit

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13065 **[Test build #68891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68891/consoleFull)** for PR 13065 at commit

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68890/ Test PASSed. ---

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #68890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68890/consoleFull)** for PR 15435 at commit

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68893/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #15820: [SPARK-18373][SS][Kafka]Make failOnDataLoss=false work w...

2016-11-19 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/15820 Because the comment made by me and +1'ed by marmbrus is hidden at this point, I just want to re-iterate that this patch should not skip the rest of the partition in the case that a timeout

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15913 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68892/ Test FAILed. ---

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68892/consoleFull)** for PR 15913 at commit

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88781534 --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala --- @@ -119,7 +119,7 @@ object SparkHadoopMapReduceWriter

[GitHub] spark issue #15913: [SPARK-18481][ML] ML 2.1 QA: Remove deprecated methods f...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15913 **[Test build #68892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68892/consoleFull)** for PR 15913 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Hi, @srowen . Could you review this PR again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/6/ Test PASSed. ---

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #6 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/6/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14627 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68887/ Test PASSed. ---

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14627 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14627: [SPARK-16975][SQL][FOLLOWUP] Do not duplicately check fi...

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14627 **[Test build #68887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68887/consoleFull)** for PR 14627 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68886/ Test PASSed. ---

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68886/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15730: [SPARK-18218][ML][MLLib] Optimize BlockMatrix multiplica...

2016-11-19 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15730 @brkyvz Good question about the shuffling data in the sparse case. Now I give some simple analysis on it (maybe not very strict): as discussed above, the shuffling data contains

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13065 **[Test build #68891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68891/consoleFull)** for PR 13065 at commit

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13065 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68885/ Test FAILed. ---

  1   2   >