Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r227650326
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -831,7 +832,14 @@ case class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22144
I think this is different from the blocker tickets we opened before. We
should try our best to avoid accidentally dropping the existing support. Please
encourage more people in the community to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22468
**[Test build #97963 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97963/testReport)**
for PR 22468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22468
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97954/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22204
**[Test build #97954 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97954/testReport)**
for PR 22204 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97962/testReport)**
for PR 22512 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97961/testReport)**
for PR 22512 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97960/testReport)**
for PR 22512 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22144
Unfortunately, we didn't drop it mistakenly. It's a mistake and we should
fix it. What I try to avoid is adding back the `supportsPartial` flag. We
should look into the root cause and see how to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r227640284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -635,13 +675,17 @@ object ScalaReflection extends
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
LGTM, pending jenkins.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r227638126
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -128,6 +128,16 @@ object ScalaReflection extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22309#discussion_r227638782
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -622,6 +654,14 @@ object ScalaReflection extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22812
cc @michalsenkyr @vofque @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22812#discussion_r227638941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1837,8 +1837,6 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22812
**[Test build #97959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97959/testReport)**
for PR 22812 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22812#discussion_r227638902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -1090,15 +1096,9 @@ case class
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22812
[SPARK-25817][SQL] Dataset encoder should support combination of map and
product type
## What changes were proposed in this pull request?
After
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97953/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97953 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97953/testReport)**
for PR 22749 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22730
**[Test build #4389 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4389/testReport)**
for PR 22730 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22729
**[Test build #4391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4391/testReport)**
for PR 22729 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22795#discussion_r227634476
--- Diff: python/pyspark/sql/functions.py ---
@@ -3023,6 +3023,42 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97949/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22608
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22608
**[Test build #97949 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97949/testReport)**
for PR 22608 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97950/
Test PASSed.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22237
https://github.com/apache/spark/pull/22237/files#r223707899 makes sense to
me. Addressed. LGTM from my side as well
---
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22237
**[Test build #97958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97958/testReport)**
for PR 22237 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22309
**[Test build #97950 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97950/testReport)**
for PR 22309 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22514
**[Test build #97957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97957/testReport)**
for PR 22514 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22729
**[Test build #4390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4390/testReport)**
for PR 22729 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22811
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sandeep-katta commented on a diff in the pull request:
https://github.com/apache/spark/pull/22571#discussion_r227630523
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2434,8 +2434,15 @@ class SparkContext(config: SparkConf) extends
Logging {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22811
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22811
Hi, @un-knower . Could you close this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22811
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21688
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21688
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97947/
Test PASSed.
---
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/21632
@holdenk @sethah @HyukjinKwon @jkbradley ping... could you please take
another look at this PR? I've updated it to latest master again. Thank you!
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21688
**[Test build #97947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97947/testReport)**
for PR 21688 at commit
GitHub user un-knower opened a pull request:
https://github.com/apache/spark/pull/22811
Branch 2.4
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22144
> According to the policy, we don't have to block the current release
because of i
@cloud-fan, BTW, would you mind if I ask to share what you read? I want to
be aware of the policy as
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22663
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97945/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22663
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22663
**[Test build #97945 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97945/testReport)**
for PR 22663 at commit
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227626505
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MutableProjectionSuite.scala
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227626456
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -143,4 +144,25 @@ object InternalRow {
case u:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97952/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97952/testReport)**
for PR 22512 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #97956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97956/testReport)**
for PR 21860 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
LGTM, pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22455
**[Test build #4388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4388/testReport)**
for PR 22455 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16478
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97946/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16478
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21860
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16478
**[Test build #97946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97946/testReport)**
for PR 16478 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22755
It looks good to improve the test coverage. But, it seems to be hard to
wrap all the test case with `withSQLConf`. So, how about adding a helper
function for turning off/on codegen
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97941/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22771
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
thanks, @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/21860
thanks, @cloud-fan , I will updated it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22771
**[Test build #97941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97941/testReport)**
for PR 22771 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97944/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21632
**[Test build #97944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97944/testReport)**
for PR 21632 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22288
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97943/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22288
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/22755
cc @maropu, @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22288
**[Test build #97943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97943/testReport)**
for PR 22288 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22754
**[Test build #97955 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97955/testReport)**
for PR 22754 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22754
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/22754
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22204
**[Test build #97954 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97954/testReport)**
for PR 22204 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22204
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22514
sounds like a clean solution. please go ahead, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227618778
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MutableProjectionSuite.scala
---
@@ -0,0 +1,66 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r227618313
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -143,4 +144,25 @@ object InternalRow {
case u:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17174
@dongjoon-hyun Thanks for your checks!! I still wait for other developer's
feedbacks. If the approach is positive, I'll make a pr. Also, welcome another
idea to solve this. cc: @gatorsmile
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22745
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22745
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
1 - 100 of 584 matches
Mail list logo
