Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21465
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21465
**[Test build #99408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99408/testReport)**
for PR 21465 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23173
It seems this is similar to @HyukjinKwon PR:
https://github.com/apache/spark/pull/13252
---
-
To unsubscribe, e-mail:
Github user ramaddepally commented on the issue:
https://github.com/apache/spark/pull/23172
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23058#discussion_r237284719
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -718,13 +718,9 @@ private[spark] class BlockManager(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23052
**[Test build #99407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99407/testReport)**
for PR 23052 at commit
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23052#discussion_r237282738
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala
---
@@ -169,13 +169,18 @@ private[csv] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23158#discussion_r237280881
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -334,6 +334,42 @@ class FsHistoryProviderSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23158#discussion_r237280935
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -334,6 +334,42 @@ class FsHistoryProviderSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23172
**[Test build #99406 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99406/testReport)**
for PR 23172 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23172
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23172
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5477/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23172#discussion_r237276972
--- Diff: project/SparkBuild.scala ---
@@ -494,7 +494,12 @@ object KubernetesIntegrationTests {
dockerBuild := {
if (shouldBuildImage) {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99391/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22612
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22612
**[Test build #99391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99391/testReport)**
for PR 22612 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5476/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99405 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99405/testReport)**
for PR 23173 at commit
Github user ramaddepally commented on a diff in the pull request:
https://github.com/apache/spark/pull/23172#discussion_r237272661
--- Diff: project/SparkBuild.scala ---
@@ -494,7 +494,12 @@ object KubernetesIntegrationTests {
dockerBuild := {
if
Github user ramaddepally commented on the issue:
https://github.com/apache/spark/pull/23172
I did not realize that we need to update this file as well when I did the
change. Thanks for doing this.
LGTM apart from a minor comment.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5477/
---
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r237272654
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -111,6 +111,8 @@ displayTitle: Spark SQL Upgrading Guide
- Since Spark 2.0, Spark
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r237272454
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class OrcSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5476/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #99404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99404/testReport)**
for PR 22911 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/23058#discussion_r237268983
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,21 +785,31 @@ private[spark] class BlockManager(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22979
**[Test build #99403 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99403/testReport)**
for PR 22979 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
**[Test build #99402 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99402/testReport)**
for PR 23174 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23170
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23058
> causes any performance degradation compared to memory mapping
@ankuriitg good question, though if you look at what the old code was
doing, it wasn't memory mapping the file, it was reading
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23174
[SPARK-26194][k8s] Auto generate auth secret for k8s apps.
This change modifies the logic in the SecurityManager to do two
things:
- generate unique app secrets also when k8s is being
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99390/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23170
**[Test build #99390 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99390/testReport)**
for PR 23170 at commit
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/23159
@gatorsmile @cloud-fan Could you look at the changes - extracted from
another PR: https://github.com/apache/spark/pull/22429
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99400 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99400/testReport)**
for PR 23173 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99400/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23166
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23166
**[Test build #99401 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99401/testReport)**
for PR 23166 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99400 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99400/testReport)**
for PR 23173 at commit
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/23166#discussion_r237250388
--- Diff: python/pyspark/broadcast.py ---
@@ -134,7 +137,15 @@ def value(self):
""" Return the broadcasted value
"""
Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/23166#discussion_r237248890
--- Diff: python/pyspark/broadcast.py ---
@@ -134,7 +137,15 @@ def value(self):
""" Return the broadcasted value
"""
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23132#discussion_r237247452
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1610,6 +1610,13 @@ object SQLConf {
""" "... N
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23100
It's hard to track the huge diffs on renaming. I don't go though it
line-by-line. But if they're just renaming, the rest LGTM.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99397/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99397 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99397/testReport)**
for PR 23173 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23166
**[Test build #99399 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99399/testReport)**
for PR 23166 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23166
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22514
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23166
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23173
**[Test build #99397 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99397/testReport)**
for PR 23173 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22514
**[Test build #99398 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99398/testReport)**
for PR 22514 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22514
Retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23173
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23031
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99388/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23031
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23031
**[Test build #99388 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99388/testReport)**
for PR 23031 at commit
GitHub user koertkuipers opened a pull request:
https://github.com/apache/spark/pull/23173
[SPARK-26208][SQL] add headers to empty csv files when header=true
## What changes were proposed in this pull request?
Add headers to empty csv files when header=true, because
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23132
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23132
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23132#discussion_r237239829
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -9,6 +9,8 @@ displayTitle: Spark SQL Upgrading Guide
## Upgrading From Spark SQL 2.4 to 3.0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23132
**[Test build #99396 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99396/testReport)**
for PR 23132 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/23171
The approach looks great, and can significantly improve the performance.
For Long, I agree that we should also implement binary search approach for
`O(logn)` look up.
Wondering which one
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/22598#discussion_r237234310
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/KafkaTokenUtil.scala ---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/spark/pull/23166#discussion_r237231750
--- Diff: python/pyspark/broadcast.py ---
@@ -118,8 +121,16 @@ def dump(self, value, f):
f.close()
def load_from_path(self,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99383/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99383/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23172
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23172
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23172
**[Test build #99395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99395/testReport)**
for PR 23172 at commit
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/23166#discussion_r237228157
--- Diff: python/pyspark/broadcast.py ---
@@ -118,8 +121,16 @@ def dump(self, value, f):
f.close()
def load_from_path(self,
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/23171#discussion_r237227892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -335,6 +343,41 @@ case class In(value: Expression,
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/23172
[SPARK-25957][followup] Build python docker image in sbt build too.
docker-image-tool.sh requires explicit argument to create the python
image now; do that from the sbt integration tests target
Github user aokolnychyi commented on the issue:
https://github.com/apache/spark/pull/23171
@gatorsmile @cloud-fan @dongjoon-hyun @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/23171#discussion_r237226275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -335,6 +343,41 @@ case class In(value: Expression,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99382/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23098
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23098
**[Test build #99382 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99382/testReport)**
for PR 23098 at commit
Github user JulienPeloton commented on a diff in the pull request:
https://github.com/apache/spark/pull/23025#discussion_r237225273
--- Diff: R/pkg/R/DataFrame.R ---
@@ -767,6 +767,14 @@ setMethod("repartition",
#' using \code{spark.sql.shuffle.partitions}
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23136
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23136
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5466/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23136
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user redsanket commented on the issue:
https://github.com/apache/spark/pull/23166
@squito yeah looking at the code we could maintain a soft reference so that
we dont have to keep requesting it from the disk. It is definitely an
optimization
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23166
**[Test build #99394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99394/testReport)**
for PR 23166 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23171
**[Test build #99393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99393/testReport)**
for PR 23171 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23166
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
301 - 400 of 769 matches
Mail list logo