[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-09-04 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 I see, Thinks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-09-04 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r214867601 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2794,6 +2794,30 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-09-03 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r214778257 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2794,6 +2794,30 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-09-03 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r214614936 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2794,6 +2794,30 @@ private[spark] object Utils extends Logging

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-30 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 I see. A new commit has been done. Thinks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-30 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 Please help me @srowen I don't know where I need to make changes. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-30 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 Why did it fail? What else should I do? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213888028 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -1184,6 +1184,25 @@ class UtilsSuite extends SparkFunSuite

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213883324 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2794,6 +2794,27 @@ private[spark] object Utils extends Logging

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213882803 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -301,16 +301,16 @@ class Dataset[T] private[sql]( // Compute

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213879659 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -1184,6 +1184,25 @@ class UtilsSuite extends SparkFunSuite

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 I have moved the method of calculating the half width of a string into util.Utils object. @maropu @srowen

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-29 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213608404 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -294,23 +294,29 @@ class Dataset[T] private[sql]( // We set

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-28 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213537923 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -294,23 +294,25 @@ class Dataset[T] private[sql]( // We set

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-28 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213525417 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -294,23 +294,25 @@ class Dataset[T] private[sql]( // We set

[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

2018-08-28 Thread xuejianbest
Github user xuejianbest commented on a diff in the pull request: https://github.com/apache/spark/pull/22048#discussion_r213525240 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -294,23 +294,25 @@ class Dataset[T] private[sql]( // We set

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-28 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 I looked at all the 0x-0x characters (unicode) and showed them under Xshell, then found all the full width characters. Get the latest regular expression. A new version has been

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-13 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 ![df.show](https://issues.apache.org/jira/secure/attachment/12935462/show.bmp) --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-13 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 Below is the display effect I tested on Xshell5. [https://issues.apache.org/jira/secure/attachment/12935462/show.bmp](url

[GitHub] spark issue #22048: Fix the show method to display the wide character alignm...

2018-08-10 Thread xuejianbest
Github user xuejianbest commented on the issue: https://github.com/apache/spark/pull/22048 After testing, it is found that regular expressions are changed to the following. `val regex = """[^\x

[GitHub] spark pull request #22048: Fix the show method to display the wide character...

2018-08-08 Thread xuejianbest
GitHub user xuejianbest opened a pull request: https://github.com/apache/spark/pull/22048 Fix the show method to display the wide character alignment problem before: +---+---+-+ |id |中国 |s2