Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12790
@MLnick Thanks for clarification. Then I think current fix is OK, since
Scala is strongly typed, we can regard ```Array()``` or ```Array.empty``` as
wrong input and throw exception. It's not
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12790
Actually the behavior in Scala is consistent - passing in `Array()` or
`Array.empty()` you are passing in `Array[Nothing]` so that is why there is a
`ClassCastException`.
Passing in an
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12790
@BryanCutler @MechCoder The current fix of removing the default value for
the ```stages``` param is OK for me. But we also should discuss the behavior of
```stages=[]``` which is inconsistent
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64018/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #64018 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64018/consoleFull)**
for PR 12790 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/12790
@yanboliang and @MechCoder , I updated this to remove the default value for
the `stages` param to be consistent with Scala and also made the pydocs a
little more clear that the param needs to
Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/12790
Awesome! Thansk!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #64018 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64018/consoleFull)**
for PR 12790 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64009/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #64009 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64009/consoleFull)**
for PR 12790 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #64009 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64009/consoleFull)**
for PR 12790 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/12790
Yeah, there is no default value in the Scala side. So I guess the thing to
do here is to just give a better error message in Python when the param is not
set and document the behavior a little
Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/12790
If that's the case then the piece of documentation that promises the
Pipeline to behave as an identity transformer when no stages are used, has to
be changed (removed).
---
If your project is
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12790
@BryanCutler I found when fitting a Scala Pipeline with no stages,
```
val pipeline = new Pipeline()
val model = pipeline.fit(df)
```
it throw exceptions:
```
Failed to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63980/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #63980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63980/consoleFull)**
for PR 12790 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #63980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63980/consoleFull)**
for PR 12790 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/12790
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/12790
Thanks for the review @MechCoder! Do you have any preference for what
should be supported from this comment (above)
https://github.com/apache/spark/pull/12790#issuecomment-227580800)
---
If
Github user MechCoder commented on the issue:
https://github.com/apache/spark/pull/12790
LGTM: cc @yanboliang @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63239/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #63239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63239/consoleFull)**
for PR 12790 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #63239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63239/consoleFull)**
for PR 12790 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60962/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #60962 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60962/consoleFull)**
for PR 12790 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/12790
Bumping this, there has been some discussion but hopefully we can get a
consensus on constructing a pipeline with no stages (should be an identity
trans). Looking at the current API, it seems
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12790
**[Test build #60962 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60962/consoleFull)**
for PR 12790 at commit
32 matches
Mail list logo
