Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/17308
LGTM. Merging to master and 2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77499/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77499 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77499/testReport)**
for PR 17308 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Thanks @viirya and @zsxwing. I have tried to address you comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77499/testReport)**
for PR 17308 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17308
LGTM and few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
@marmbrus Thank you for taking a look again. Surely, shut down hook is not
ideal for closing kafka producers. In fact, for the case of kafka sink, it
might be correct to skip cleanup step. I
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77410/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77410 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77410/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77410 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77410/testReport)**
for PR 17308 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Jenkins, retest this please !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Build is failing due to "Our attempt to download sbt locally to
build/sbt-launch-0.13.13.jar failed. Please install sbt manually from
http://www.scala-sbt.org/;
---
If your project is set up
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77358/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77358 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77358/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77358 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77358/testReport)**
for PR 17308 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Jenkins, retest this please !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77357/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77357/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #77357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77357/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76932 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76932/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76932/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76932 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76932/testReport)**
for PR 17308 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
SPARK-20737 is created to look into cleanup mechanism in a separate JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76890/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76890 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76890/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76890 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76890/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76872/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76872/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76872/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76869/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76869/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76869/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76868/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76868 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76868/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #76868 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76868/testReport)**
for PR 17308 at commit
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Hi @marmbrus and @brkyvz, Thanks a lot of taking a look.
@marmbrus You are right, we should have another way to canonicalize kafka
params. I can only think of appending a unique id to
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/17308
Taking a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/17308
@marmbrus @zsxwing @tdas This needs attention from someone
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/17308
Just to throw in my two cents, a change like this is definitely needed, as
is made clear by the second sentence of the docs
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
I can further confirm, that in logs, a kafkaproducer instance is created
almost every instant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
@tdas ping !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
@tcondie and @zsxwing any comments on this patch. I would be happy, if this
bug is fixed before 2.2 is released.
---
If your project is set up for it, you can reply to this email and have your
Github user ScrapCodes commented on the issue:
https://github.com/apache/spark/pull/17308
Please take a look, @tcondie @zsxwing !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74658/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #74658 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74658/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #74658 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74658/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74646/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #74646 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74646/testReport)**
for PR 17308 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74644/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17308
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #74646 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74646/testReport)**
for PR 17308 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17308
**[Test build #74644 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74644/testReport)**
for PR 17308 at commit
63 matches
Mail list logo
