[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-12-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-09-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 Would you guys mind if I ask to point out some concerns that I might better have to double check by myself? --- - To

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95539/ Test PASSed. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95539/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95539/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95533/ Test FAILed. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95533/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 > We have been through too many changes in related code. Each time a lot of code need to be touched to implement a new proposal... I agree in general. Thing is, I doubt if multiple

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22281 @HyukjinKwon When I implemented the migration, I met the problem you specify in the PR description. At that time I used a fallback framework to switch the data source to V1 as temporary

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95533/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 For clarification, I am okay with targeting this to 3.0.0 since the code freeze will be very soon if I am not mistaken. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 Yea, but the default fallback should rather be DataSource V2's. Both of you are super active in DataSource V2. Do you guys have some concerns about defaulting to DataSource V1's behaviour?

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22281 USING syntax has to be there, but what can USING maybe only data source v1 and file format. IIUC the agreement is: a data source v2 with catalog can create a table with USING, and the

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 @rdblue, Thanks, I will take a look and see if we can keep the current approach for the write side too. --- - To

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 > I think one possible design is to not support USING in data source v2, and always ask data sources to provide a catalog. I thought we almost all agreed with supporting USING syntax.

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread rdblue
Github user rdblue commented on the issue: https://github.com/apache/spark/pull/22281 Thanks for working on this, @HyukjinKwon. I think it's great that this is getting the conversation started. I agree with @cloud-fan that we should think through how we want v2 to work. The

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22281 We need to think of the big picture. I think one possible design is to not support USING in data source v2, and always ask data sources to provide a catalog. AFAIK there is no consensus about how

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22281 The catalog integration stuff looked to me able to proceed orthogonally since this change target to use existing catalog. It looked indeed kind of tricky but I thought the current way kind of

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22281 how is this related to the catalog integration work @rdblue is working on? IIRC @gengliangwang skipped this part when migrating file source because there are some problems hard to solve. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95460/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95460/ Test FAILed. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95459/ Test FAILed. ---

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95459/testReport)** for PR 22281 at commit

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22281 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22281: [SPARK-25280][SQL] Add support for USING syntax for Data...

2018-08-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22281 **[Test build #95460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95460/testReport)** for PR 22281 at commit