Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
@cloud-fan, thanks for getting this done! I'll wait for the equivalent
write-side PR.
---
-
To unsubscribe, e-mail:
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
> I still do not think we should mix the catalog support with the data
source APIs
We are trying to keep these separate. `Table` is the only overlap between
the two. If you prefer more
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/23086
I still do not think we should mix the catalog support with the data source
APIs. Catalog is a well-defined concept. The so-called "table catalog" is not a
catalog to me.
The data
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99493/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99493 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99493/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99493 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99493/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
+1
There are only minor suggestions left from me. I'd like to see the default
implementation of `Table.name` removed, but I don't think that should block
committing this.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99461/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99461/testReport)**
for PR 23086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99461/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99459/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99459 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99459/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99459/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99428/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99428/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99428 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99428/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99383/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99383 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99383/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99383 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99383/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99381/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99381 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99381/testReport)**
for PR 23086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99381 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99381/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99379/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99379 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99379/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99379 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99379/testReport)**
for PR 23086 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/23086
@cloud-fan, sorry to spread review comments over two days, but I've
finished the first pass. Overall, it looks great.
I think we can simplify a couple of areas, like all of the args passed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99135/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99135 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99135/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99135 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99135/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99088/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99088 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99088/testReport)**
for PR 23086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99088 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99088/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99042/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99042/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99042/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99038 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99038/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99038/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99038/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99005/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99005 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99005/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99004/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99004/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99003 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99003/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99003/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99004/testReport)**
for PR 23086 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23086
**[Test build #99005 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99005/testReport)**
for PR 23086 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23086
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/23086
@rxin @rdblue @jose-torres @gatorsmile @gengliangwang @mccheah
---
-
To unsubscribe, e-mail:
87 matches
Mail list logo
