Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220526350
@rxin I thought I had but must have missed it by mistake. Thanks for
picking to 2.0
---
If your project is set up for it, you can reply to this email and have your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220521612
@MLnick did you actually merge this in 2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220214631
LGTM, thanks @BryanCutler. Merged to master/branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220165208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220165209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220165069
**[Test build #58812 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58812/consoleFull)**
for PR 13159 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220154399
**[Test build #58812 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58812/consoleFull)**
for PR 13159 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63760782
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -53,7 +53,8 @@ private[feature] trait PCAParams extends Params with
HasInputCol
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63758013
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -53,7 +53,8 @@ private[feature] trait PCAParams extends Params with
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220118185
Ya, that would be good to fix and might as well do it here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220115544
Thanks for doing this, looks like a good improvement. While we are updating
the PyDocs here it seems like some of stages that require fitting make links to
the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220111552
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220111551
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220111395
**[Test build #58795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58795/consoleFull)**
for PR 13159 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220099502
**[Test build #58795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58795/consoleFull)**
for PR 13159 at commit
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220098861
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220096467
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220096470
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220096431
**[Test build #58792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58792/consoleFull)**
for PR 13159 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-220093981
**[Test build #58792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58792/consoleFull)**
for PR 13159 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63741239
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -106,7 +107,7 @@ object PCA extends DefaultParamsReadable[PCA] {
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63637481
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -240,7 +240,8 @@ object VectorIndexer extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63637490
--- Diff: python/pyspark/ml/feature.py ---
@@ -2401,7 +2413,7 @@ class PCAModel(JavaModel, JavaMLReadable,
JavaMLWritable):
"""
..
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13159#discussion_r63637479
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/PCA.scala ---
@@ -106,7 +107,7 @@ object PCA extends DefaultParamsReadable[PCA] {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-219899541
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-219899477
**[Test build #58728 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58728/consoleFull)**
for PR 13159 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-219899537
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-219893986
**[Test build #58728 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58728/consoleFull)**
for PR 13159 at commit
GitHub user BryanCutler opened a pull request:
https://github.com/apache/spark/pull/13159
[DOC][MINOR] ml.feature Scala and Python API sync
## What changes were proposed in this pull request?
I reviewed Scala and Python APIs for ml.feature and corrected discrepancies.
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/13159#issuecomment-219893757
cc @MLnick @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
31 matches
Mail list logo
