[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220524558 Merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220523237 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511333 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220511206 **[Test build #58935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58935/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220501865 **[Test build #58935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58935/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220501720 @hvanhovell Thanks. I have address your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915441 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -269,6 +270,81 @@ class HiveCommandSuite extends

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915128 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63915008 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63914894 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,55 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220263980 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220263982 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220263742 **[Test build #58853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58853/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220246020 **[Test build #58853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58853/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-19 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63832125 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( }

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63814999 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220205653 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220205657 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220205631 **[Test build #58833 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58833/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220204527 @hvanhovell Thanks. I have address your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220204385 **[Test build #58833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58833/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63810569 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( }

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread lianhuiwang
Github user lianhuiwang commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63809072 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( }

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220174569 @lianhuiwang this looks pretty good. What is your take on the atomicity of the truncate operation? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63792095 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63791716 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63791491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63791413 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -271,6 +274,54 @@ case class LoadData( } /**

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63788452 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -351,6 +351,26 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13170#discussion_r63788383 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -351,6 +351,26 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220167424 cc @hvanhovell for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220005341 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220005343 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220005100 **[Test build #58772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58772/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-220003377 **[Test build #2991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2991/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-219987072 **[Test build #58772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58772/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13170#issuecomment-219987019 **[Test build #2991 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2991/consoleFull)** for PR 13170 at commit

[GitHub] spark pull request: [SPARK-15335] [SQL] Implement TRUNCATE TABLE C...

2016-05-18 Thread lianhuiwang
GitHub user lianhuiwang opened a pull request: https://github.com/apache/spark/pull/13170 [SPARK-15335] [SQL] Implement TRUNCATE TABLE Command ## What changes were proposed in this pull request? Like TRUNCATE TABLE Command in Hive, TRUNCATE TABLE is also supported by Hive.