Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220667951
LGTM, merging to master / 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r64077284
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,19 @@ public void testClusterCmdBuilder()
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220523618
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220523617
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220523513
**[Test build #58937 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58937/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220512285
**[Test build #58937 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58937/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63988573
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,18 @@ public void
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220494834
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220494836
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220494714
**[Test build #58914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58914/consoleFull)**
for PR 13163 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63972318
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,18 @@ public void testClusterCmdBuilder()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63972414
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,18 @@ public void testClusterCmdBuilder()
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220480180
**[Test build #58914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58914/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63970749
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,17 @@ public void
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63969163
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,17 @@ public void testClusterCmdBuilder()
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220475085
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220475084
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220474934
**[Test build #58903 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58903/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220453725
**[Test build #58903 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58903/consoleFull)**
for PR 13163 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220434211
Looks good, just a remaining nit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63943470
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -59,6 +59,16 @@ public void testClusterCmdBuilder()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63943269
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -147,7 +156,7 @@
List args = new ArrayList<>();
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220422012
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220421720
**[Test build #58873 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58873/consoleFull)**
for PR 13163 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220422008
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220390916
**[Test build #58873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58873/consoleFull)**
for PR 13163 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220389680
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220261449
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220261272
**[Test build #58852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58852/consoleFull)**
for PR 13163 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220261453
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220243685
**[Test build #58852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58852/consoleFull)**
for PR 13163 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220213832
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220213834
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220213672
**[Test build #58832 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58832/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220202513
**[Test build #58832 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58832/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220202347
@vanzin I will check and fix the existing Unit test failure tonight.
[error] Test
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220199730
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220199731
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220199627
**[Test build #58826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58826/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220198683
@vanzin Yes, that is what I mean and I want to confirm with you. I only
check no exception.
---
If your project is set up for it, you can reply to this email
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220197965
I'm not really sure I understand what you're saying; but it should be
possible to write a unit test where you create a `SparkSubmitCommandBuilder` to
execute `--help`
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220197352
@vanzin Based on my understanding, the help message is print on console
and the launcher should not expect help message String. So, will I expect no
exception.
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220187083
@wangmiao1981 while you wait for tests to pass could you try to add a unit
test to SparkSubmitCommandBuilderSuite.java?
---
If your project is set up for it, you can
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220186955
**[Test build #58826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58826/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220186565
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220183165
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220183164
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220183010
**[Test build #58813 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58813/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220164776
**[Test build #58813 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58813/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220163385
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220152922
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220152918
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220152676
**[Test build #58810 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58810/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220129969
**[Test build #58810 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58810/consoleFull)**
for PR 13163 at commit
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220106677
@vanzin Sure. I will do it after I fully understand the logic. Good to
learn how Spark submit works. Thanks for your time!
---
If your project is set up for it,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220105549
BTW this should be a good opportunity to add a unit test to make sure
`--help` works, for example.
---
If your project is set up for it, you can reply to this email
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220104774
`--help` seems to also work with my patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220102228
@vanzin Thanks for your clarification. Let me learn and revise the change.
'--help' is also broken.
---
If your project is set up for it, you can reply to this
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63747463
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -101,6 +110,80 @@ public static void main(String[] argsArray) throws
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-220097877
Sorry, this was me. But as others said, this is not the right fix. Here's a
patch that does it:
```
diff --git
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63698118
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -101,6 +110,80 @@ public static void main(String[] argsArray) throws
Exception
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219971330
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219971328
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219971092
**[Test build #58752 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58752/consoleFull)**
for PR 13163 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219969961
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219969965
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219969720
**[Test build #58751 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58751/consoleFull)**
for PR 13163 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219964799
Is the fix not to just pull up the call to `builder.buildCommand(env);` in
Main from line 86 to after line 60? then it does require rethinking a bit how
the error path
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13163#discussion_r63665823
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -101,6 +110,80 @@ public static void main(String[] argsArray) throws
Exception {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219944557
**[Test build #58752 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58752/consoleFull)**
for PR 13163 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13163#issuecomment-219943467
**[Test build #58751 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58751/consoleFull)**
for PR 13163 at commit
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/13163
[SPARK-15360][Spark-Submit]Should print spark-submit usage when no
arguments is specified
## What changes were proposed in this pull request?
(Please fill in changes proposed in this
73 matches
Mail list logo
