Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220529510
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220529183
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220528429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220528428
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220528241
**[Test build #58940 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58940/consoleFull)**
for PR 13156 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220517365
**[Test build #58940 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58940/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220516949
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220515502
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220513843
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220507235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220507239
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220507152
**[Test build #58934 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58934/consoleFull)**
for PR 13156 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220500710
**[Test build #58934 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58934/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220500330
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220461395
**[Test build #58905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58905/consoleFull)**
for PR 13156 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220461429
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220461425
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220459388
**[Test build #58905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58905/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220458174
I see. `spark.sessionState.invalidateTable` already exists. They have the
same implementation. Thus, I will just remove
`spark.sessionState.refreshTable`? Let me
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220424613
LGTM other than the renaming. We shouldn't have
`spark.catalog.refreshTable` and `spark.sessionState.refreshTable` do different
things. I would rename the latter to
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63937901
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -163,6 +163,9 @@ private[sql] class SessionState(sparkSession:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63820600
--- Diff:
sql/hivecontext-compatibility/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
---
@@ -58,4 +58,16 @@ class HiveContext private[hive](
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63820108
--- Diff:
sql/hivecontext-compatibility/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
---
@@ -58,4 +58,16 @@ class HiveContext private[hive](
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63817417
--- Diff:
sql/hivecontext-compatibility/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
---
@@ -58,4 +58,16 @@ class HiveContext
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220212872
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220212875
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220212724
**[Test build #58831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58831/consoleFull)**
for PR 13156 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220201874
**[Test build #58831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58831/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63808728
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220200787
LGTM except the test stuff, thanks for working on it! I agree that we
should remove `refreshTable` in `SessionState`, but need someone to confirm, or
we can do it
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63808539
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220155088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220155086
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220154809
**[Test build #58808 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58808/consoleFull)**
for PR 13156 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220149993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220149990
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220149660
**[Test build #58805 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58805/consoleFull)**
for PR 13156 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220121864
**[Test build #58808 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58808/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63760124
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -163,6 +163,9 @@ private[sql] class SessionState(sparkSession:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63758568
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63758626
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63758414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -163,6 +163,9 @@ private[sql] class SessionState(sparkSession:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63757822
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -126,24 +126,9 @@ case class RefreshTable(tableIdent:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-220117679
**[Test build #58805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58805/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63732945
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63729506
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite extends
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63727680
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63719915
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63675218
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219931477
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219931474
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219931325
**[Test build #58740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63647706
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63646713
--- Diff:
sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala
---
@@ -99,4 +105,41 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63644169
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63643173
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala
---
@@ -622,7 +622,7 @@ class MetastoreDataSourcesSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219918792
**[Test build #58740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58740/consoleFull)**
for PR 13156 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219886319
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219886323
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219886108
**[Test build #58725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58725/consoleFull)**
for PR 13156 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63615059
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MultiDatabaseSuite.scala ---
@@ -202,7 +202,8 @@ class MultiDatabaseSuite extends QueryTest
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63615033
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -294,6 +294,18 @@ class SQLContext private[sql](
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63613203
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/MultiDatabaseSuite.scala ---
@@ -202,7 +202,8 @@ class MultiDatabaseSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13156#discussion_r63613130
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -294,6 +294,18 @@ class SQLContext private[sql](
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13156#issuecomment-219869025
**[Test build #58725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58725/consoleFull)**
for PR 13156 at commit
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/13156
[SPARK-15367] [SQL] Add refreshTable back
What changes were proposed in this pull request?
`refreshTable` was a method in `HiveContext`. It was deleted accidentally
while we were
67 matches
Mail list logo
