Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220875681
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220846483
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220846484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220846427
**[Test build #59112 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59112/consoleFull)**
for PR 13169 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220842129
**[Test build #59112 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59112/consoleFull)**
for PR 13169 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220841980
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220834946
@cloud-fan Failed on some unrelated cases too, can you help me retest it
again?
---
If your project is set up for it, you can reply to this email and have your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220834542
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220834541
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220834535
**[Test build #59107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59107/consoleFull)**
for PR 13169 at commit
Github user wangyang1992 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r64150440
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -353,6 +353,20 @@ class DateTimeUtilsSuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220834112
**[Test build #59107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59107/consoleFull)**
for PR 13169 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r64143999
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -353,6 +353,20 @@ class DateTimeUtilsSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220789473
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220789474
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220789398
**[Test build #59070 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59070/consoleFull)**
for PR 13169 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220784893
**[Test build #59070 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59070/consoleFull)**
for PR 13169 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220784694
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220556056
Retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220549615
seems like a irrelevant fail. retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220546244
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220546246
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220546092
**[Test build #58959 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58959/consoleFull)**
for PR 13169 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220531101
**[Test build #58959 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58959/consoleFull)**
for PR 13169 at commit
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220531075
Fixed scala style, retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220529523
**[Test build #58951 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58951/consoleFull)**
for PR 13169 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220529529
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220529531
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220528941
**[Test build #58951 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58951/consoleFull)**
for PR 13169 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220528363
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220528269
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220523060
Addressed your comments. @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220518098
LGTM, except some minor comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r63991642
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
---
@@ -353,6 +353,20 @@ class DateTimeUtilsSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r63991470
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -426,6 +426,26 @@ object DateTimeUtils {
}
Github user wangyang1992 commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-220512727
@cloud-fan Could you please help me look at this some time? A simple fix.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wangyang1992 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r63814998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -58,6 +58,7 @@ object DateTimeUtils {
final
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13169#discussion_r63809918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -58,6 +58,7 @@ object DateTimeUtils {
final
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13169#issuecomment-219985016
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user wangyang1992 opened a pull request:
https://github.com/apache/spark/pull/13169
[SPARK-15379][SQL] check special invalid date
## What changes were proposed in this pull request?
When invalid date string like "2015-02-29 00:00:00" are cast as date or
timestamp
41 matches
Mail list logo
