[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220831561 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13211#discussion_r64142098 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -437,7 +438,9 @@ class ListAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13211#discussion_r64139990 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -437,7 +438,9 @@ class ListAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220796529 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220796487 **[Test build #59074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59074/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220791312 **[Test build #59074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59074/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220791183 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220782917 **[Test build #59069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59069/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220782920 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220782922 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220782453 **[Test build #59069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59069/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220782258 @srowen Thanks. Already addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220780504 I think it's fine except that the list should be created directly from the collection for simplicity and to fit its size exactly. --- If your project is set up for

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220635827 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220635826 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220635548 **[Test build #58993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58993/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220605232 **[Test build #58993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58993/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220605028 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13211#discussion_r64019450 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -437,7 +437,11 @@ class ListAccumulator[T] extends AccumulatorV2[T,

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220553525 **[Test build #58972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58972/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220553545 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220553541 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220551437 **[Test build #58972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58972/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220550485 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220550435 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220550438 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220550229 **[Test build #58954 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58954/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220530382 **[Test build #58954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58954/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529900 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529898 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529866 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220529743 **[Test build #58938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58938/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13211#issuecomment-220514553 **[Test build #58938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58938/consoleFull)** for PR 13211 at commit

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-19 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/13211 [SPARK-15430][SQL] Fix potential ConcurrentModificationException for ListAccumulator ## What changes were proposed in this pull request? In `ListAccumulator` we create an unmodifiable view