Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221771183
**[Test build #59339 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59339/consoleFull)**
for PR 13165 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221770814
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221770536
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221770524
**[Test build #59336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59336/consoleFull)**
for PR 13165 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221770538
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221769561
**[Test build #59336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59336/consoleFull)**
for PR 13165 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221769185
I just addressed the comments and here is the
(stdout)[https://gist.github.com/HyukjinKwon/4bf35184f3a30f3bce987a58ec2bbbab]
of testing on Windiws.
---
If your
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64680778
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64680592
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64675913
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64628244
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221586554
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221586546
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221586539
**[Test build #59277 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59277/consoleFull)**
for PR 13165 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221585787
**[Test build #59277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59277/consoleFull)**
for PR 13165 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64576800
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221576056
@shivaram and @sun-rui I addressed the comment, added a test for this PR
and fixed some tests not working on Windows due to path separator.
This PR also
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r64576193
--- Diff: R/pkg/R/client.R ---
@@ -60,6 +60,15 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221581990
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221581253
**[Test build #59276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59276/consoleFull)**
for PR 13165 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221581975
**[Test build #59276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59276/consoleFull)**
for PR 13165 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221581986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221577659
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221577653
**[Test build #59275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59275/consoleFull)**
for PR 13165 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221576970
**[Test build #59275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59275/consoleFull)**
for PR 13165 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221577662
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221133227
@shivaram Thank you so much. Let me try to add a test meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-221132935
Related to my comment on #13217 -- I will test this out on windows using
the new instructions.
---
If your project is set up for it, you can reply to this email and
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220533282
@sun-rui Thank you so much. I will try to add a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220528702
I checked the source code of system2. Since a batch file with .cmd
extension is to be launched on Windows, I think it is more formal to use
shell() instead of
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220521666
1. A rough scan of the test failures shows most of them are probably
related to path handling. You can replay the failed test case in R on Windows.
For debug
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220515342
This raises some questions to me.
1. It seems several tests were failed. Could you please inform me your
thoughts?
2. Now, I think I can add some
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220515182
@sun-rui @felixcheung Right. It seems finally I made it. I made gists and
upload a PDF file for Spark UI.
Let me tell you the test results first.
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220237304
@felixcheung, this issue seems to relate to system2() only. However, let's
wait for HyukjinKwon's test result.
@HyukjinKwon, great, go ahead please.
---
If
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220224055
@sun-rui @felixcheung Let me try to build and run all tests for R first in
Windows and then will try to correct and add each test one by one. This will
take a bit
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-220216386
Does this apply to other cases:
https://github.com/apache/spark/blob/d6dc12ef0146ae409834c78737c116050961f350/R/pkg/inst/worker/daemon.R#L22
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219970686
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219970691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219970569
**[Test build #58763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58763/consoleFull)**
for PR 13165 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219966400
**[Test build #58763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58763/consoleFull)**
for PR 13165 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r63667236
--- Diff: R/pkg/R/client.R ---
@@ -43,6 +43,17 @@ determineSparkSubmitBin <- function() {
sparkSubmitBinName
}
+# R supports both
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13165#discussion_r63667121
--- Diff: R/pkg/R/client.R ---
@@ -43,6 +43,17 @@ determineSparkSubmitBin <- function() {
sparkSubmitBinName
}
+# R supports both file
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219964022
**[Test build #58760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58760/consoleFull)**
for PR 13165 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219964125
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219964128
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219960923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219960918
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219960744
**[Test build #58758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58758/consoleFull)**
for PR 13165 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219959650
**[Test build #58760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58760/consoleFull)**
for PR 13165 at commit
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219957564
Could you add a test case for Windows specific test? @shivaram
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219956443
**[Test build #58758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58758/consoleFull)**
for PR 13165 at commit
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13165#issuecomment-219955778
Please let me cc @sun-rui and @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/13165
[SPARK-8603][SPARKR] Incorrect file separator passed to Java and Scripts
from R in windows
## What changes were proposed in this pull request?
This PR corrects R file separator to
53 matches
Mail list logo
