Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15626
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86236250
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -131,8 +131,8 @@ class FileStreamSource(
*
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86220801
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -88,14 +92,13 @@ class HDFSMetadataLog[T:
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86216703
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,36 @@ package
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86219164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,36 @@ package
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r86218960
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,36 @@ package
Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85641502
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryException.scala
---
@@ -36,8 +36,8 @@ class StreamingQueryException
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85615504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85615514
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -44,9 +45,14 @@ import
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85615490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala
---
@@ -0,0 +1,62 @@
+/*
+* Licensed to the Apache
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85615458
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -713,6 +713,8 @@ class StreamExecution(
}
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85613884
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85613714
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85613616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85609921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala
---
@@ -37,14 +39,19 @@ import
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85609758
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceOffsetSuite.scala
---
@@ -36,4 +37,9 @@ class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85602991
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85605730
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85606228
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85603184
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala
---
@@ -0,0 +1,62 @@
+/*
+* Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85605203
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85608065
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -51,4 +54,11 @@ private[kafka010] object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85604066
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -44,9 +45,14 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85605189
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85603294
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -713,6 +713,8 @@ class StreamExecution(
}
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85603525
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryException.scala
---
@@ -36,8 +36,8 @@ class StreamingQueryException
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85605087
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLogSuite.scala
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85602891
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -44,9 +45,14 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85602329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala
---
@@ -37,14 +39,19 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85604754
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryException.scala
---
@@ -36,8 +36,8 @@ class StreamingQueryException
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85603113
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala
---
@@ -0,0 +1,62 @@
+/*
+* Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85607356
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -44,9 +45,14 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85602088
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceOffsetSuite.scala
---
@@ -36,4 +37,9 @@ class KafkaSourceOffsetSuite
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85041254
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85026112
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85026079
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85025740
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85025208
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -51,4 +60,8 @@ private[kafka010] object
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85025029
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -27,13 +28,21 @@ import
Github user tcondie commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r85024877
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala
---
@@ -22,7 +22,10 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84981184
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84980489
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84976242
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84978303
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -27,13 +28,21 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84980045
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -51,4 +60,8 @@ private[kafka010] object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84980399
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84976336
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84976309
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/LongOffset.scala
---
@@ -22,8 +22,18 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84976708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeq.scala
---
@@ -22,7 +22,10 @@ package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84975950
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -27,13 +28,21 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84975957
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala
---
@@ -27,13 +28,21 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/15626#discussion_r84976377
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
@@ -23,4 +23,16 @@ package
GitHub user tcondie opened a pull request:
https://github.com/apache/spark/pull/15626
SPARK-17829 [SQL] Stable format for offset log
## What changes were proposed in this pull request?
Currently we use java serialization for the WAL that stores the offsets
contained in
53 matches
Mail list logo
