Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125874238
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestData.scala ---
@@ -230,6 +230,16 @@ private[sql] trait SQLTestData { self =>
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125873472
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -712,6 +707,76 @@ class DataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125836743
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2205,47 +2205,80 @@ class Dataset[T] private[sql](
* // max
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125837050
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -220,4 +221,97 @@ object StatFunctions extends Logging
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125873943
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -712,6 +707,76 @@ class DataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125873512
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -712,6 +707,76 @@ class DataFrameSuite extends QueryTest with
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18307#discussion_r125836508
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2205,47 +2205,80 @@ class Dataset[T] private[sql](
* // max
