[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126293302 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,21 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126293500 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -175,6 +246,8 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126293557 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -231,6 +315,9 @@ package object config { private[spark] val

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126293363 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,21 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126293375 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,63 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-08 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126292668 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +62,63 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274206 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274201 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274200 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274204 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274198 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274203 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -88,50 +137,76 @@ package object config { .createOptional

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274183 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274186 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126274185 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273756 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,22 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273760 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,22 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273432 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273429 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -51,29 +63,66 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273417 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,22 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273242 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,22 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126273196 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -35,10 +35,22 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126090693 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -38,7 +38,12 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-07 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r126090608 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -38,7 +38,12 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r125938087 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -38,7 +38,12 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r125938115 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -54,7 +59,11 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-06 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18555#discussion_r125901919 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -38,7 +38,12 @@ package object config {

[GitHub] spark pull request #18555: [Minor]add checkValue in spark.internal.config ab...

2017-07-06 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/18555 [Minor]add checkValue in spark.internal.config about how to correctly set configurations ## What changes were proposed in this pull request? add checkValue for configurations