Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22921
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231596680
--- Diff: R/pkg/R/functions.R ---
@@ -1663,9 +1692,24 @@ setMethod("toDegrees",
#' @aliases toRadians toRadians,Column-method
#' @note
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231554470
--- Diff: R/pkg/R/functions.R ---
@@ -319,6 +319,27 @@ setMethod("acos",
column(jc)
})
+#' @details
+#'
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231403827
--- Diff: R/pkg/R/functions.R ---
@@ -319,6 +319,27 @@ setMethod("acos",
column(jc)
})
+#' @details
+#'
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231125506
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231024007
--- Diff: R/pkg/R/functions.R ---
@@ -1641,30 +1641,30 @@ setMethod("tanh",
})
#' @details
-#' \code{toDegrees}: Converts
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r231023768
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230784165
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230568378
--- Diff: R/pkg/R/functions.R ---
@@ -319,23 +319,23 @@ setMethod("acos",
})
#' @details
-#' \code{approxCountDistinct}:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230568058
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230568079
--- Diff: R/pkg/R/functions.R ---
@@ -1641,30 +1641,30 @@ setMethod("tanh",
})
#' @details
-#' \code{toDegrees}: Converts
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230568088
--- Diff: R/pkg/R/functions.R ---
@@ -319,23 +319,23 @@ setMethod("acos",
})
#' @details
-#' \code{approxCountDistinct}:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230449544
--- Diff: python/pyspark/sql/functions.py ---
@@ -275,15 +273,6 @@ def _():
del _name, _doc
-@since(1.3)
-def
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230449173
--- Diff: R/pkg/R/functions.R ---
@@ -1641,30 +1641,30 @@ setMethod("tanh",
})
#' @details
-#' \code{toDegrees}: Converts an
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230436963
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -279,27 +254,6 @@ class DataFrameSuite extends QueryTest with
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230428697
--- Diff: python/pyspark/sql/functions.py ---
@@ -275,15 +273,6 @@ def _():
del _name, _doc
-@since(1.3)
-def
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230429014
--- Diff: python/pyspark/storagelevel.py ---
@@ -56,16 +56,3 @@ def __str__(self):
StorageLevel.MEMORY_AND_DISK = StorageLevel(True, True, False,
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230427671
--- Diff: R/pkg/R/functions.R ---
@@ -1641,30 +1641,30 @@ setMethod("tanh",
})
#' @details
-#' \code{toDegrees}: Converts an
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230427828
--- Diff: R/pkg/R/functions.R ---
@@ -1641,30 +1641,30 @@ setMethod("tanh",
})
#' @details
-#' \code{toDegrees}: Converts an
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230283948
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -279,27 +254,6 @@ class DataFrameSuite extends QueryTest with
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230156120
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -62,17 +62,6 @@ class SQLContext private[sql](val sparkSession:
SparkSession)
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230155788
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -639,20 +639,6 @@ private[spark] object SparkConf extends Logging {
*/
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230135473
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -62,17 +62,6 @@ class SQLContext private[sql](val sparkSession:
SparkSession)
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230132632
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -639,20 +639,6 @@ private[spark] object SparkConf extends Logging {
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230057306
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathExpressionsSuite.scala
---
@@ -246,7 +246,7 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22921#discussion_r230057481
--- Diff: R/pkg/R/generics.R ---
@@ -748,7 +748,7 @@ setGeneric("add_months", function(y, x) {
standardGeneric("add_months") })
#' @rdname
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22921
[SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
## What changes were proposed in this pull request?
- Remove some AccumulableInfo .apply() methods
- Remove
27 matches
Mail list logo
