Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71102254
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/ConfigurableCredentialManager.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14235
Can you also remove "[TEST]" from the title? TEST isn't a module.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14065#discussion_r71102195
--- Diff: dev/.rat-excludes ---
@@ -99,3 +99,4 @@ spark-deps-.*
.*tsv
org.apache.spark.scheduler.ExternalClusterManager
.*\.sql
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71102174
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71102142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/systemcatalog/InformationSchema.scala
---
@@ -0,0 +1,312 @@
+/*
+ * Licensed to
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71102107
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Now, the remaining issue is using `getResource` to save the golden files. I
left a comment about that.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62448 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62448/consoleFull)**
for PR 14235 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14236
@rxin Sure, Thank you very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14116
```Scala
val catalog = spark.sessionState.catalog
catalog.setCurrentDatabase(SessionCatalog.INFORMATION_SCHEMA_DATABASE)
sql("CREATE TABLE my_tab (age INT,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101786
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14236
Since it is a small change I will just push a commit myself. Thanks for
noticing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14236#discussion_r71101740
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -977,7 +977,10 @@ object functions {
*
* @group normal_funcs
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101535
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101452
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71101399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -484,8 +521,11 @@ class SessionCatalog(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101205
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101198
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101173
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +88,58 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71101148
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14244
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62447/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14244
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14244
**[Test build #62447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62447/consoleFull)**
for PR 14244 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71101023
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71100937
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100950
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100943
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100930
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14116
General question 1: Should we disallow users to do most DDLs against
`INFORMATION_SCHEMA`? For example, create functions, create tables, ...
---
If your project is set up for it, you can reply
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100872
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -101,95 +149,125 @@ class LogicalPlanToSQLSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100858
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +88,58 @@ class LogicalPlanToSQLSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71100846
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14116#discussion_r71100512
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -471,6 +480,34 @@ class SessionCatalog(
}
Github user deanchen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13988#discussion_r71100480
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityGenerator.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to
Github user deanchen commented on the issue:
https://github.com/apache/spark/pull/13912
@srowen @rxin Would love to see this get merged as this has been a pain
point for us. Not a fan of timezoneless dates as an engineer but the need to
passthrough or write timezoneless dates to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14132
I finished my third pass. Will review it again when your new version is
ready. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71100213
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -755,4 +755,243 @@ class LogicalPlanToSQLSuite
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14102
@yhuai Thank you for your review! I will try to address all your comments
first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62446/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14235
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62446/consoleFull)**
for PR 14235 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099344
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71099153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71099090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71099098
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala
---
@@ -51,7 +53,8 @@ private[sql] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098985
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098966
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098821
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14028
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14028
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62445/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14028
**[Test build #62445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62445/consoleFull)**
for PR 14028 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098603
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098299
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/SQLBuilder.scala ---
@@ -425,6 +452,49 @@ class SQLBuilder(logicalPlan: LogicalPlan)
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098109
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14244
**[Test build #62447 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62447/consoleFull)**
for PR 14244 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098026
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71098009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13988#discussion_r71097989
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityGenerator.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14244
[SPARK-16598] [SQL] [TEST] Added a test case for verifying the table
identifier parsing
What changes were proposed in this pull request?
So far, the test cases of
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097771
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097752
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user ooq commented on the issue:
https://github.com/apache/spark/pull/14174
hey @sameeragarwal, the diff of the generated code can be found here (with
the left side for vectorized hashmap and right side for the new, row-based
one):
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71097256
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71097210
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user deanchen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13988#discussion_r71097167
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityGenerator.scala
---
@@ -0,0 +1,83 @@
+/*
+ * Licensed to
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
The followings are updated.
- Adds a heading line in golden SQL files.
- Adds more documents and replace `HiveQL` with `SQL`. The remaining `hive`
are only the one in test input SQL.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71096995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,51 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14235
**[Test build #62446 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62446/consoleFull)**
for PR 14235 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096802
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096761
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user koertkuipers commented on the issue:
https://github.com/apache/spark/pull/14222
there is a usefulness to this `ReduceAggregator` beyond `.reduceGroups`.
basically you can take any Aggregator without a zero and turn it into a valid
Aggregator, with the caveat being that
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096584
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096571
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096401
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096388
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71096347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,306 @@ import
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14235
When the optimized plans are different, we need to check whether the
optimized plan of the generated SQL perform worse than the original one. If so,
we need to improve the SQL generation logics.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71096037
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71096013
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095897
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r71095725
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JSONOptions.scala
---
@@ -51,7 +53,8 @@ private[sql] class JSONOptions(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095681
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095641
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/14175#discussion_r71095619
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -552,7 +552,9 @@ private[spark]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14028
**[Test build #62445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62445/consoleFull)**
for PR 14028 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r71095511
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -87,6 +87,7 @@ class Analyzer(
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095404
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14028
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user yhuai commented on the issue:
https://github.com/apache/spark/pull/14028
LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
For the self unittest, sure. I did it manually, but it would be better if
we had it, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14235
Hmm, I didn't remember correctly, but the result were different. For the
Hint test cases, I used SQLConf to setup the testsuite because I knew that the
optimizer would work differently.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095116
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -102,7 +140,7 @@ class LogicalPlanToSQLSuite
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14235#discussion_r71095137
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala
---
@@ -76,22 +85,51 @@ class LogicalPlanToSQLSuite
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/14243
cc @sun-rui
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
1 - 100 of 316 matches
Mail list logo
