Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Congratulations on your first commit, @janplus !
I've learn a lot while watching this PR, too. :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
Thanks @rxin @dongjoon-hyun @cloud-fan @liancheng
I've learnt a lot from this PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14008
Thanks - merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #3173 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3173/consoleFull)**
for PR 14008 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #3173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3173/consoleFull)**
for PR 14008 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14008
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61987/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #61987 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61987/consoleFull)**
for PR 14008 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14008
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #61987 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61987/consoleFull)**
for PR 14008 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14008
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
It seems failed the
`org.apache.spark.sql.sources.CreateTableAsSelectSuite.create a table, drop it
and create another one with the same name` test which is irrelevant with this
PR.
Maybe we
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14008
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #61983 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61983/consoleFull)**
for PR 14008 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14008
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61983/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14008
**[Test build #61983 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61983/consoleFull)**
for PR 14008 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14008
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
cc @cloud-fan Thank you.
I have resolved conflicts with master and done some code style fixes as you
suggested.
---
If your project is set up for it, you can reply to this email and have your
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14008
LGTM except one minor comment, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
cc @rxin @cloud-fan Thank you for review
I add a new commit doing the following things:
1. Use ExpectsInputTypes instead of ImplicitCastInputTypes.
2. Add some cases for invalid-type
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
cc @cloud-fan @rxin @liancheng
I did optimization for Literal `part`, so we don't need to check for every
row. But since we may not assume in all circumstances the `part` is Literal, I
keep
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
Resolve conflicts with master.
cc @cloud-fan , is there any more question about this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
@cloud-fan Thank you for review.
I did some code style fixes as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
@dongjoon-hyun @cloud-fan It is nice to have you review my PR. Thank you!
I have add a new commit with following things:
1. Revert driver side's literal key invalidation.
2. Resolve
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
So far, there were some different opinions on `new URL` error handling and
`Literal Pattern` handling. It's a frequent pattern of comments. :)
I agree @cloud-fan 's opinions also. If I
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
@dongjoon-hyun Thank you for review
I have add a new commit which does following things:
1. Implement **Literal** `key` validation in `Driver` side.
2. Correct some failure message.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Hi, @janplus .
Overall this PR looks solid to me now. It implemented most logic in the
same way with Hive parse_url.
The remaining difference from Hive is about `SymanticException`
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
@dongjoon-hyun and @cloud-fan Thank you for review.
I have add a new commit which does following things:
1. Cache the url and the key pattern use the similar approach of
`XPathBoolean`
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Hi, @janplus .
I've done my second pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
@rxin and @dongjoon-hyun Thanks for your review.
I have add a new commit which does following things:
1. Put `parse_url` function in the right order.
2. Use `""" """` instead of `+`
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Hi, @janplus .
I've done first pass.
Thank you for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Oh. Sure. @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14008
@dongjoon-hyun can you help review this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14008
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user janplus commented on the issue:
https://github.com/apache/spark/pull/14008
cc @rxin and @cloud-fan
Improvements for performance concern
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
34 matches
Mail list logo
