Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21153
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r188132284
--- Diff: python/pyspark/ml/util.py ---
@@ -396,6 +397,7 @@ def saveMetadata(instance, path, sc,
extraMetadata=None, paramMap=None):
-
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r187129517
--- Diff: python/pyspark/ml/util.py ---
@@ -396,6 +397,7 @@ def saveMetadata(instance, path, sc,
extraMetadata=None, paramMap=None):
-
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r185262870
--- Diff: python/pyspark/util.py ---
@@ -61,6 +62,26 @@ def _get_argspec(f):
return argspec
+def majorMinorVersion(version):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r185159691
--- Diff: python/pyspark/util.py ---
@@ -61,6 +62,26 @@ def _get_argspec(f):
return argspec
+def majorMinorVersion(version):
---
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r185131834
--- Diff: python/pyspark/util.py ---
@@ -61,6 +62,26 @@ def _get_argspec(f):
return argspec
+def majorMinorVersion(version):
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184693332
--- Diff: python/pyspark/ml/util.py ---
@@ -417,15 +419,24 @@ def _get_metadata_to_save(instance, sc,
extraMetadata=None, paramMap=None):
"""
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184693307
--- Diff: python/pyspark/ml/util.py ---
@@ -417,15 +419,24 @@ def _get_metadata_to_save(instance, sc,
extraMetadata=None, paramMap=None):
"""
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184632888
--- Diff: python/pyspark/ml/util.py ---
@@ -523,11 +534,29 @@ def getAndSetParams(instance, metadata):
"""
Extract Params from
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184626842
--- Diff: python/pyspark/ml/util.py ---
@@ -523,11 +534,29 @@ def getAndSetParams(instance, metadata):
"""
Extract Params
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184620777
--- Diff: python/pyspark/ml/util.py ---
@@ -417,15 +419,24 @@ def _get_metadata_to_save(instance, sc,
extraMetadata=None, paramMap=None):
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21153#discussion_r184620855
--- Diff: python/pyspark/ml/util.py ---
@@ -417,15 +419,24 @@ def _get_metadata_to_save(instance, sc,
extraMetadata=None, paramMap=None):
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21153
[SPARK-24058][ML][PySpark] Default Params in ML should be saved separately:
Python API
## What changes were proposed in this pull request?
See SPARK-23455 for reference. Now default params
13 matches
Mail list logo
