On 09/03/2017 10:11 PM, Michael Sevakis wrote:
So how about adding the dirchache.size != 0 condition there to not update
last_size if size is 0? Like this:
https://github.com/dreamlayers/rockbox/commit/d438eb3b9ee9a824e2cac85aaa306c3891694e3a
Hmmm... .size isn't going to be zero at that point
> So how about adding the dirchache.size != 0 condition there to not update>
> last_size if size is 0? Like this:
> https://github.com/dreamlayers/rockbox/commit/d438eb3b9ee9a824e2cac85aaa306c3891694e3a
Hmmm... .size isn't going to be zero at that point if there's been even one
entry added
Thanks for your response Mike. Yes, now I see the other places where
dircache.last_size is set to 0, and understand that those are important.
(I probably should have looked at that myself.)
Adding some splashf() I see that dircache.last_size is set to 0 on
shutdown before scanning is finished
It could cause issues with dircache not being able to expand itself to fit more
files. The size is zeroed if it gets overstuffed (more than 3/4 of the reserved
is used) or wasn't able to finish to establish a new set point so it can scan
later without blocking.
Mike
On Monday, February
