use of getBytes() in WebServer.java

2002-08-13 Thread Adam Megacz
Uh, that's a bit troubling. If I'm on an EBDIC system, getBytes() will return EBDIC bytes, and then send them over the socket. Shouldn't it be getBytes(ASCII)? - a -- Sick of HTML user interfaces? www.xwt.org

patch to correct improper handling of HTTP Basic authentication

2002-08-13 Thread Adam Megacz
XmlRpc.java does not provide adequate support to implement HTTP Basic Authentication. WebServer.java implements it incorrectly. This patch fixes both problems. If an HTTP request requires authentication, the server MUST return a 401 Unauthorized:

system.multicall()

2002-08-13 Thread Adam Megacz
Here's the patch for system.multicall(), plus a new file it adds (SystemMethods.java). This patch also includes my last patch for HTTP Basic authentication. - a __ org/apache/xmlrpc/SystemMethods.java package

Re: cvs commit: xml-rpc/src/java/org/apache/xmlrpc SystemHandler.java

2002-08-14 Thread Adam Megacz
://www.apache.org/. */ import org.apache.xmlrpc.*; import java.util.*; /** * Implements the XML-RPC standard system.* methods (such as * codesystem.multicall/code. * * @author a href=mailto:[EMAIL PROTECTED];Adam Megacz/a */ public class SystemHandler

Re: cvs commit: xml-rpc/src/java/org/apache/xmlrpc SystemHandler.java

2002-08-14 Thread Adam Megacz
Whoops, my mistake, apparently those changes did get folded in. I guess I must've missed the commit message. - a Adam Megacz [EMAIL PROTECTED] writes: Uh, you forgot the corresponding patches to XmlRpcServer.java. This class is useless without those changes. - a [EMAIL PROTECTED

Re: system.multicall()

2002-08-14 Thread Adam Megacz
Daniel Rall [EMAIL PROTECTED] writes: The multicall handler needs a reference to the XmlRpcServer to perform the multiple RPC calls; This is true, and cannot be avoided, since SystemHandler needs access (at least indirectly) to XmlRpcServer.handlers in order to dispatch the subcalls. You

Re: patch to correct improper handling of HTTP Basic authentication

2002-08-15 Thread Adam Megacz
/017143.html - a Adam Megacz [EMAIL PROTECTED] writes: XmlRpc.java does not provide adequate support to implement HTTP Basic Authentication. WebServer.java implements it incorrectly. This patch fixes both problems. If an HTTP request requires authentication, the server MUST return a 401

how to setDebug(true) on XmlRpcServer?

2002-08-16 Thread Adam Megacz
Since XmlRpcServer hides its XmlRpc in a package-protected inner class, how can I turn on debugging when using an XmlRpcServer? - a -- Sick of HTML user interfaces? www.xwt.org

org.apache.xmlrpc.XmlWriter emits invalid XML

2002-08-17 Thread Adam Megacz
According to XML 1.0, a CDATA section may contain only: [2] Char ::= #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x1-#x10] http://www.w3.org/TR/2000/REC-xml-20001006#charsets XmlWriter fails to #;-encode characters below 0x20, and emits XML which is

Re: how to setDebug(true) on XmlRpcServer?

2002-08-19 Thread Adam Megacz
Daniel Rall [EMAIL PROTECTED] writes: Since the debug field of the XmlRpc class is a class member (rather than an instance member) Whoops! Didn't see that. - a -- Sick of HTML user interfaces? www.xwt.org

Re: org.apache.xmlrpc.XmlWriter emits invalid XML

2002-08-19 Thread Adam Megacz
These characters are not allowed even if they are encoded as #; The only correct behaviour is to refuse to handle data containing these characters. So rather than entity encoding the characters, an XmlRpcException of some sort should be thrown? Ah, the joys of the

Re: [PATCH] Improve encoding support for XmlWriter

2004-01-20 Thread Adam Megacz
Ed Korthof [EMAIL PROTECTED] writes: Look for the update at the bottom (2003/06/30). Oh my god, I can't believe he actually FINALLY did it. I must've begged Dave to do this at least thirty times back in 2001/2002. Ed, thanks for bringing this to my attention. I still take issue with What