Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ rpmfc.c

2009-11-18 Thread Jeff Johnson
Nothing wrong with the patch. But a more general "policy" mechanism, with PCRE/GLOB patterns to enable/disable dependency extraction on a per-interpreter basis is needed. The filtering from PLD is a pretty sound step in that direction. But note https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ filetriggers.c

2009-11-18 Thread Jeff Johnson
On Nov 18, 2009, at 10:42 AM, Per Øyvind Karlsen wrote: > > I'll knock out the "r.fpio" for you if asked. > I certainly wouldn't mind. :) > I'll assume that is "asked" ... todo++. This path needs to become a macro: #define _FILES_AWAITING_FILETRIGGERS "/var/lib/rpm/files-awaiting-filetriggers

Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ filetriggers.c

2009-11-18 Thread Per Øyvind Karlsen
2009/11/18 Jeff Johnson > > On Nov 18, 2009, at 10:00 AM, Per Øyvind Karlsen wrote: > > > Index: rpm/lib/filetriggers.c > > > > > $ cvs diff -u -r2.19 -r2.20 filetriggers.c > > --- rpm/lib/filetriggers.c 2 Sep 2009

Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ filetriggers.c

2009-11-18 Thread Jeff Johnson
On Nov 18, 2009, at 10:20 AM, Jeff Johnson wrote: > > But its all under > #ifdef RPM_VENDOR_MANDRIVA > so "Have it your own way!" There's a memory leak here if %{_filetriggers_dir} is not defined: static const char * filetriggers_dir(void) /*...@globals _filetriggers_dir, rpmGlo

Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ filetriggers.c

2009-11-18 Thread Jeff Johnson
On Nov 18, 2009, at 10:07 AM, Jeff Johnson wrote: > > On Nov 18, 2009, at 10:00 AM, Per Øyvind Karlsen wrote: > >> Index: rpm/lib/filetriggers.c >> >> $ cvs diff -u -r2.19 -r2.20 filetriggers.c >> --- rpm/lib/filetrigg

Re: [CVS] RPM: rpm/ CHANGES rpm/lib/ filetriggers.c

2009-11-18 Thread Jeff Johnson
On Nov 18, 2009, at 10:00 AM, Per Øyvind Karlsen wrote: > Index: rpm/lib/filetriggers.c > > $ cvs diff -u -r2.19 -r2.20 filetriggers.c > --- rpm/lib/filetriggers.c 2 Sep 2009 10:29:13 - 2.19 > +++ rpm/li

Re: rpmdb segfaults after upgrade from rpm 4.6.0

2009-11-18 Thread Jeff Johnson
On Nov 18, 2009, at 9:15 AM, Per Øyvind Karlsen wrote: > > Hmm, if not automatically handling this in code, what about some option, > macro or something? It obviously seems like something that a lot of people is > likely to run into and therefore should be dealt with in a way easily usable >

Re: rpmdb segfaults after upgrade from rpm 4.6.0

2009-11-18 Thread Per Øyvind Karlsen
2009/11/18 Jeff Johnson > > So what is needed is a --rebuilddb with the PROT_WRITE added, and > then revert to only setting PROT_READ. How you wish to achieve > that conversion on the fly is up to you. The forward looking goal > is to use PROT_READ hardware protection rather than all the > overly