Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Jeffrey Johnson
On Apr 22, 2012, at 1:07 PM, Matthew Dawkins mdawk...@rpm5.org wrote: @@ -1128,6 +1132,12 @@ } } + /* XXX ugly quick dirty integration of haskell() dependencies */ + { fn = strstr(fc-fn[fc-ix], /usr/share/haskell-deps); + if (fn) +

Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Dmitry V. Levin
On Sun, Apr 22, 2012 at 02:28:29PM -0400, Jeffrey Johnson wrote: [...] 1) strstr(3) has hidden state that WILL break with multithreading. And the proper fix isn't to just use strstr_r(3). Isn't strstr(3) a thread-safe function? And what is strstr_r(3)? -- ldv

Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Jeffrey Johnson
On Apr 22, 2012, at 4:31 PM, Dmitry V. Levin l...@altlinux.org wrote: On Sun, Apr 22, 2012 at 02:28:29PM -0400, Jeffrey Johnson wrote: [...] 1) strstr(3) has hidden state that WILL break with multithreading. And the proper fix isn't to just use strstr_r(3). Isn't strstr(3)

Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Jeffrey Johnson
On Apr 22, 2012, at 5:43 PM, Jeffrey Johnson n3...@me.com wrote: On Apr 22, 2012, at 4:31 PM, Dmitry V. Levin l...@altlinux.org wrote: On Sun, Apr 22, 2012 at 02:28:29PM -0400, Jeffrey Johnson wrote: [...] 1) strstr(3) has hidden state that WILL break with multithreading. And

Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Dmitry V. Levin
On Sun, Apr 22, 2012 at 06:21:18PM -0400, Jeffrey Johnson wrote: [...] There's 124 patches in Mandriva Cooker headed towards @rpm5.org in need of review. This check-in was the first tentative step forward. Wouldn't it be a good idea to review these changes prior to committing them? This

Re: [CVS] RPM: rpm-5_4: rpm/ CHANGES rpm/lib/ rpmfc.c rpmfc.h rpm/macros/ ...

2012-04-22 Thread Jeffrey Johnson
On Apr 22, 2012, at 7:39 PM, Dmitry V. Levin l...@altlinux.org wrote: On Sun, Apr 22, 2012 at 06:21:18PM -0400, Jeffrey Johnson wrote: [...] There's 124 patches in Mandriva Cooker headed towards @rpm5.org in need of review. This check-in was the first tentative step forward. Wouldn't it