Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

ldv-alt requested changes on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

@proyvind pushed 1 commit. 12e9521 add disabler for brp-compress -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

@proyvind pushed 1 commit. 0d496d8 add brp script to check elf files for unresolved symbols and unused libs -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

@proyvind pushed 1 commit. a469648 add brp script for automatically creating library symlinks using ldconfig -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind commented on this pull request. > @@ -0,0 +1,15 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +INFODIR=`rpm --eval %{_infodir}/dir` + +dir="$RPM_BUILD_ROOT/$INFODIR" + +if [ -f $dir

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind commented on this pull request. > @@ -0,0 +1,49 @@ +#!/bin/sh + +# This script makes sure to remove any standard library search paths from rpath +# or runpath tags as they're not only redundant, but will break overriding +# search paths. Search paths of the tag that's not standard will

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

ignatenkobrain commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | nice one

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

ignatenkobrain commented on this pull request. > @@ -0,0 +1,15 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +INFODIR=`rpm --eval %{_infodir}/dir` + +dir="$RPM_BUILD_ROOT/$INFODIR" + +if [ -f

Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

ignatenkobrain commented on this pull request. > @@ -70,6 +70,15 @@ %{_rpmconfigdir}/brp-strip %{__strip} \ %{_rpmconfigdir}/brp-strip-static-archive %{__strip} \ %{_rpmconfigdir}/brp-strip-comment-note %{__strip} %{__objdump} \ +%{?!dont_clean_files: [ -n

[Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

I've added most of the helper scripts, there's a few remaining and some I'll have to consider whether to kill off in stead before done. Anyways, I'm making a preliminary pull request as a request for comments. Notice how all these scripts can either be disabled by setting an environment

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

I am not user of %auto{patch,setup} but I hate the backup files around. I really don't see any reason for their existence. And I saw quite some packages shipping them accidentally ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last <em...@fool.com>" does not work (#120)

hey @pmatilai - i'm using fedora 24 with: ``` $ rpm -q rpm rpm-sign gnupg2 gnupg rpm-4.13.0-1.fc24.x86_64 rpm-sign-4.13.0-1.fc24.x86_64 gnupg2-2.1.13-2.fc24.x86_64 gnupg-1.4.21-1.fc24.x86_64 ``` my DISPLAY variable is unset but my `TERM` is `screen-256color`. What is odd that I am trying to

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

pmatilai requested changes on this pull request. I'm actually in favor of enabling backups by default. However this patch clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent patches_num variable so any attempt to use %autosetup with this patch ends up in: `error:

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

pmatilai requested changes on this pull request. I'm actually in favor of enabling backups by default. However this patch clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent patches_num variable so any attempt to use %autosetup with this patch ends up in: `error: lua

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

I dont see any *real* reasons against backups by default here. The default should be the most useful one, and the way I see it for those living with gendiff for one reason or another backups are a must. In my experience the only reason NOT to create backups is stupid (often perl) projects which

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

@pmatilai I'm tempted to not modify the default backend because of reasons mentioned by @soig and @ignatenkobrain in #109. But let me see what I can do about introducing an alternative backend that creates patch backups. -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

Yup. Or actually the other way around: have the default "patch" version create backups because that's more in line with the other backends, and add another backend like patch_nobackup (gosh I hate that name) for the no-backup case. -- You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

@pmatilai so you'd want instead a `-S patchbackup` backend instead of using `-B` at `%autosetup`/`%autopatch`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

So actually I think this is best handled by having two separate backends (similar to git and git_am) where one creates backups and the other one doesn't. That way there's no need to introduce new option that is specific to one backend only. -- You are receiving this because you are subscribed

Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)

My issue with this is that it adds an option that is by definition only relevant to a single "backend" of %autosetup, and the most uninteresting one at that. I'm all for supporting backups for plain patch, doing them was actually always part of the plan only never implemented. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last <em...@fool.com>" does not work (#120)

OTOH the pinentry bug doesn't explain behavior change with different %_gpg_name value. Can you reproduce the problem if you explicity set TERM to something, eg `TERM=xterm rpm --addsign ./grub2-2.02-0.38.fc25.dusty.x86_64.rpm` -- You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last <em...@fool.com>" does not work (#120)

Okay, this is actually a bug in pinentry, see https://bugs.gnupg.org/gnupg/issue2452 With that info I can also reproduce the behavior by forcing an empty environment: ``` error: gpg exec failed (2) [pmatilai@sopuli rpm]$ cp ~/Downloads/xfce4-terminal-0.8.2-2.fc25.x86_64.rpm /tmp/; env -i

Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last <em...@fool.com>" does not work (#120)

That's strange. I'm not able to reproduce that, and it doesn't seem to be about actual length either since my name is longer and I always had this in my ~/.rpmmacros: `%_gpg_name Panu Matilainen ` What version of rpm, gpg and what distro are you using? -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)

I dont see what more there is to explain. Macros are expanded everywhere including what appear to be comments in spec. If you need to escape it to avoid expansion then double percent (%%) is the way to do it. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)

Closed #121. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/121#event-918754747___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)

\CC: @pmatilai, @ffesti, @ignatenkobrain, @myungjoo , @hk57kim , @jyoungyun -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)

We sometime use "#" symbol to append some contents in ./spec file. This issue describes incorrect operation of "#" symbol in case that we try to ignore a macro line (e.g. %define . . . ) in ./spec file. For example, the '#' (hash character) symbol to invalidate a macro statement does not valid