Is NEVR format saved in headers? If it was, it could be used when parsing NEVR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@s-t-e-v-e-n-k commented on this pull request.
> -dep_normalized_name = dep.key
+dep_normalized_name = dep.name.lower().replace('_',
'-')
if args.legacy:
-name =
@hroncok commented on this pull request.
>
-names = list(py_deps.keys())
-names.sort()
-for name in names:
+for name in sorted(list(py_deps.keys())):
```suggestion
for name in sorted(py_deps.keys()):
```
--
You are receiving this because you are subscribed to this
> Latest push now has every test successfully run the script, however that one
> test still fails because there's a difference in behaviour between the script
> in this repo and in python-rpm-generators.
>
> ```
> -if '>' == operator:
> -# distutils does not behave this way,
@hroncok commented on this pull request.
> from warnings import warn
+try:
+from importlib.metadata import PathDistribution
+from pathlib import Path
+except ImportError:
+from importlib_metadata import PathDistribution
+from pathlib2 import Path
I'd rather have those two
@torsava requested changes on this pull request.
Hi @s-t-e-v-e-n-k ,
first of all, I'm really sorry the review took so long :(
I've pointed out some issues in the comments, mostly in the less-or-not-used
parts of the code.
The PR as a whole looks fantastic, great piece of engineering. And all
Pushed a small but important change that you'll want to pick up for testing
purposes: don't emit change notifications on rpmtsFree().
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai pushed 1 commit.
36a57108ca62da95d44d5cffbe54071c685a Implement a transaction set change
notification callback
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@pmatilai
It seems useable now.
I will try to use new C API (PRs #1365, #1366, #1367) and do a simple tests.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@jrohel commented on this pull request.
> as passed e.g. as data arg ts.addInstall()"},
+{"Priv", (PyCFunction)rpmte_Priv,METH_NOARGS,
+ "te.Priv() -- Return associated user data (if any)\n"},
+{"SetPriv",(PyCFunction)rpmte_SetPriv, METH_O,
+
@jrohel , thanks for the feedback.
Another option wrt Python callback could be just replacing the crazy pkgObj
thing with rpmte, so the order and number of arguments would actually remain as
it was, just that the weird pkgObj becomes actually meaningful, consistent and
always present. Python
@pmatilai
Python API:
>From my point of view the new mode arguments (rpmte, what, amount, total,
>userdata) are much better than the old ones. And it is almost the same as in
>the new C API mode.
I prefer to drop "key" argument from this new API.
--
You are receiving this because you are
12 matches
Mail list logo
