Re: [Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-03 Thread Panu Matilainen
Coming to the conclusion that it's just not worth the trouble right now. I'll revive this once we've fixed the order (filed a ticket for that) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3011#issuecomment-2033714434 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-03 Thread Panu Matilainen
Closed #3011. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3011#event-12336023902 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-03 Thread Panu Matilainen
The thought crossed my mind too, I'm a bit torn on this all. Sure, reverting the order in the aliases would be safe. But, it seems like a bug that we're storing them in reverse order in the package in the first place, and something we should fix instead. But, that'd break it for the alleged

Re: [Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-02 Thread ニール・ゴンパ
@Conan-Kudo requested changes on this pull request. Actually, since these emit the sources and patches in reverse order, could we make the aliases also reverse that so they are in the correct order? -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-02 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3011#pullrequestreview-1973096004 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Add --patches and --sources aliases to rpmspec (PR #3011)

2024-04-02 Thread Panu Matilainen
These are common needs and the query is not exactly obvious, so why not. Hijack the otherwise unused poltest.spec for the sources test, its the only multi-source spec we have. Only, it hasnt been parseable in about ten years because of the Collections: tag, so remove that... You can view,