Re: [Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2024-04-03 Thread Panu Matilainen
Apologies for this not progressing anywhere, but the time in between has confirmed that something like this will need a general purpose use-case in rpm itself so that it can be regularly tested. We'll be exploring this area in the future, but this isn't the time, we need to focus on v6. I'm

Re: [Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2024-04-03 Thread Panu Matilainen
Closed #2557. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2557#event-12335587655 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2023-09-01 Thread Richard Phibel
@pmatilai Thanks for the comments. I tried to address them. Limiting reflinking to whole files would be a serious limitation. We wouldn't be able to use the RPM extents format. And I imagine that other users might like to have the possibility to reflink partial files. -- Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2023-09-01 Thread Richard Phibel
@rphibel pushed 1 commit. f659678235ea6839e924dec94d39f8fba272c139 Add FA_REFLINK file action -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2557/files/6aff1b9f869f4ca268a48830ccd338ed1966e04d..f659678235ea6839e924dec94d39f8fba272c139 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2023-07-03 Thread Panu Matilainen
Thanks for working on this. Some birds-eye comments on the approach: - We can't expose a linux-specific struct in the API like that. Need to find a way to abstract that out one way or the other, passing void pointers around is one possibility. Or limit the reflink to whole fd's in the API which

[Rpm-maint] [rpm-software-management/rpm] Add FA_REFLINK file action (PR #2557)

2023-06-27 Thread Richard Phibel
This PR adds a new `FA_REFLINK` file action. This action reflinks a file instead of doing a copy. This can be used as follows: - plugins call `rpmfilesSetFcr` with a [`file_clone_range`](https://man7.org/linux/man-pages/man2/ioctl_ficlonerange.2.html) structure containing reflink information