Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-04-03 Thread Panu Matilainen
After a few nights sleep - sorry but no. It'd be this strange macro you can never use because something else might be relying on it. Just like you shouldn't be overriding %_fixperms for your use because it breaks other things. The idea of a pre/post action slots for macros and whatnot is not a

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-04-03 Thread Panu Matilainen
Closed #2961. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2961#event-12336249093 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Petr Menšík
This is intended to be used for non-mock builds. It simplifies patches maintenance when preparing old rhel specs from Fedora system, so it does not need to be backported to rhel8 or previous. It is meant to be used for rebasing or testing in ``fedpkg local`` or ``fedpkg install`` modes, where

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Panu Matilainen
Applying such a patch upstream won't help rhel-7 or rhel-8 in the slightest. The upstream method for git integration is %autosetup, so I don't really see a case here. %setup is weird enough as it is, I'd rather not tangle up any more functionality into it. -- Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Petr Menšík
this allows creating git-based build patches applied, even on rhel7 or rhel8, where %autosetup is not used. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2961#issuecomment-1991193975 You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Petr Menšík
I have used (or misused) _fixperms macro to provide special actions for creating build repository as git repository, without the need to modify original source spec file. Something I have prepared at https://github.com/pemensik/rpm-gitprep. I would like to have a way more clean to it. --

Re: [Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Panu Matilainen
What's your use-case for this? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2961#issuecomment-1991114449 You are receiving this because you are subscribed to this thread. Message ID: ___

[Rpm-maint] [rpm-software-management/rpm] Add ability to specify extra command after %setup (PR #2961)

2024-03-12 Thread Petr Menšík
Allow custom action done after %_fixperms is done. Creates %_setup_post macro, which will be expanded after %setup. Consequently also always done in autosetup. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2961 -- Commit