Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Oh and thanks for the patch, I do remember cursing at the stupid limitation on a few occasions :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Closed #235. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/235#event-1313662104___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Merged the authors from the find-lang.sh "changelog" into CREDITS where they belong, and cleaned up the commit message and merged as a single commit 2249cf4507545a1f73c52941b32d063ba72edb35. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Changelogs embedded in individual files don't belong to a project maintained in a VCS to begin with. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

proyvind commented on this pull request. > @@ -13,6 +13,7 @@ # 2011-11-16 Per Øyvind Karlsen # * add support for HTML files (from Mandriva) +# * add support for multiple names well, the changelog entry and the original commit (@cooker) did take place in 2011,

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Conan-Kudo requested changes on this pull request. > @@ -13,6 +13,7 @@ # 2011-11-16 Per Øyvind Karlsen # * add support for HTML files (from Mandriva) +# * add support for multiple names This distinctly didn't happen in 2011. -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

proyvind commented on this pull request. This should be sufficient for approval, no? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

I went with bash as interpreter;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/235#issuecomment-310149625___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

@proyvind pushed 1 commit. 7b278b4 change shebang to /bin/bash -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

ignatenkobrain requested changes on this pull request. either you have to change interpreter to bash or not use arrays.. > @@ -54,7 +55,7 @@ fi shift if [ -z "$1" ] ; then usage -else NAME=$1 +else NAMES[0]=$1 ``` $ dash -c "NAMES[0]='x'" dash: 1: NAMES[0]=x: not found ``` -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

Conan-Kudo commented on this pull request. > @@ -54,7 +55,7 @@ fi shift if [ -z "$1" ] ; then usage -else NAME=$1 +else NAMES[0]=$1 Arrays are supported in POSIX shell, but not like that. They're way more rudimentary. -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

ignatenkobrain commented on this pull request. > @@ -54,7 +55,7 @@ fi shift if [ -z "$1" ] ; then usage -else NAME=$1 +else NAMES[0]=$1 IIRC it is bashism, arrays are not supported in POSIX shell -- You are receiving this because you are subscribed to this thread. Reply to this email

[Rpm-maint] [rpm-software-management/rpm] Find lang.sh multi names (#235)

You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/235 -- Commit Summary -- * add support for passing multiple names to find-lang.sh to avoid having to run find-lang.sh for each name and append the file lists produced later