Thanks. This must be like third or fourth attempt fixing this particular thing,
hopefully this one really does it for good :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #379.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/379#event-1419393251___
Rpm-maint mailing list
Ok, updated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/379#issuecomment-356616236___
Rpm-maint mailing list
...meh, never mind my previous comment, I'm having one of those mental Mondays
it seems. But please update the comment(s) anyway.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I don't see any signature tag number after RPMSIGTAG_RESERVEDSPACE.
Thinking a bit more about the comment, it's a bit wrong. It should be "all tag
numbers lower than RPMSIGTAG_RESERVEDSPACE" must be already added. We can add
higher tags afterwards with no problems.
--
You are receiving this
Cost of headerSizeof() is unmeasurable background noise in the context of
package generation, and even more so when talking about packages with >= 4GB
payload.
@mlschroe , those "reserved space tag must come last" comments - if you mean
that it needs to be added last, then you should state
headerSizeof() is expensive: you are better off doing more careful arithmetic.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
