Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-08-01 Thread wladmis
> `RPMTAG_BUILDTIME` is recorded from the machine that builds it. Yes, I know what `RPMTAG_BUILDTIME` is and for what it has been made. > In addition, I'm not sure it's sane for repositories to contain multiple > packages of the same NEVRD with different build-times and consider them > unique.

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-08-01 Thread ニール・ゴンパ
> Sorry, I don't understand the question. The buildtime value is an actual > value of package RPMTAG_BUILDTIME. Within packages of one branch (the branch > name is stored in RPMTAG_DISTTAG with some other metainformation) ALT rpm > compares buildtime of packages with the same NEVR, youngest

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-08-01 Thread wladmis
> At least in Fedora, openSUSE, and OpenMandriva, the package manager has the > option to "sync" the installed package set with what is in the repos, which > obviates the need for such a trick. This is probably harder to do in apt, but > it's not out of the realm of possibility, especially

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-06-26 Thread ニール・ゴンパ
@wladmis What is the value of considering the build-time? That would introduce a nearly uncontrollable value that could trigger upgrades/replacements when it is undesired. At least in Fedora, openSUSE, and OpenMandriva, the package manager has the option to "sync" the installed package set

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-06-19 Thread Panu Matilainen
Frankly, I dread the idea of introducing new elements to version comparison as history has shown that it takes *years* to catch and fix all the corner cases. But I wont comment on partial work, if there's been further work on this, please update the PR. -- You are receiving this because you

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2019-06-18 Thread ニール・ゴンパ
@wladmis So I've seen that this is more fleshed out in ALT Linux's rpm, do you plan on finishing up this PR for consideration? JFYI for everyone else, it looks like ALT has implemented `E:V-R:D` comparison in their rpm 4.13.x tree, where the D is the DistTag. It looks like my suggestion of

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-15 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. Yeah, but

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-15 Thread Panu Matilainen
pmatilai commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. FWIW, the D

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread Jeff Johnson
Colon is a perfectly natural tuple separator widely used: see $PATH for an obvious example. This is a parsing, not an aesthetic, issue whatever your opinion might be. Dependency tuples need to be easily parsed into a {E,V,R,D,...} tuple as simply and speedily as possible. -- You are

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. No one

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread Jeff Johnson
There are 2 parsing problems triggered by adding disttag: 1) how to represent distag in dependencies (omv used a ':' separator) 2) how to represent distag in package file names (omv used a '-' separator) There is also the question of precedence in version comparison, whether disttag should be

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread wladmis
wladmis commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. @Conan-Kudo

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. @wladmis

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. The

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. @wladmis

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread wladmis
wladmis commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. I don't know

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread wladmis
wladmis commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. I decided to

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. Do you

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings. I

Re: [Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-09 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. > @@ -731,13 +731,14 @@ int rpmdbCountPackages(rpmdb db, const char * name) } /** - * Attempt partial matches on name[-version[-release]][.arch] strings. + * Attempt partial matches on name[-version[-release]][/disttag][.arch] strings.

[Rpm-maint] [rpm-software-management/rpm] Handle DistTag (#594)

2018-11-07 Thread wladmis
Related to #589. I'm not sure, but if it is OK, there can be a new feature to handle `DistTag` (named `rpmlib(HandleDistTag)`, for example) that is required if there is non-empty `DistTag` while package is building. Something like: +++ build/pack.c (in proper place): /* if DistTag is