OK, pondering a bit more about this... It does seem like a solution to a
non-existent problem right now. It's also too niche of a feature to go
advertise and/or discuss on fedora-devel. I'll just close it now, the patch
exists in case we change our mind in the future.
--
Reply to this email
Closed #3018.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3018#event-13128512239
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
@dmnks commented on this pull request.
> @@ -32,7 +32,7 @@ directories, symlinks etc.
The file triggers are defined in spec files of packages. E.g. file trigger
executing `ldconfig` could be defined in glibc package.
-Similarly to regular triggers, file trigger scripts (except the
@dmnks commented on this pull request.
> @@ -248,4 +248,29 @@ char *argvJoin(ARGV_const_t argv, const char *sep)
return dest;
}
-
+
+ARGV_t argvFromVaList(const char *fmt, va_list ap)
+{
+ARGV_t argv = argvNew();
Oh, fair points, thanks. Will update the PR later.
--
Reply to
After a quick chat on our team channel, this may benefit from packagers'
feedback. It's meant for them, after all. I'll ask for it, let's convert to a
draft meanwhile.
--
Reply to this email directly or view it on GitHub:
@pmatilai commented on this pull request.
> @@ -248,4 +248,29 @@ char *argvJoin(ARGV_const_t argv, const char *sep)
return dest;
}
-
+
+ARGV_t argvFromVaList(const char *fmt, va_list ap)
+{
+ARGV_t argv = argvNew();
No need for argvNew(), argvAdd*() handles that as needed.
[Pass arg2 (albeit -1) to transaction triggers
too](https://github.com/rpm-software-management/rpm/pull/3018/commits/9a069b03ba6e51790aed5c19163e1b8658c1e71b)
should talk about "file triggers" in the commit message.
--
Reply to this email directly or view it on GitHub:
@ffesti commented on this pull request.
> @@ -32,7 +32,7 @@ directories, symlinks etc.
The file triggers are defined in spec files of packages. E.g. file trigger
executing `ldconfig` could be defined in glibc package.
-Similarly to regular triggers, file trigger scripts (except the
Details in the commit messages (GH didnt populate the description
automatically for some reason).
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3018
-- Commit Summary --
* Rename script-args to script-prog
* Replace
