mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
How reliable is it to see if
Conan-Kudo commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
No. He means that there are cases
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
Do you mean that not everybode
pmatilai commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
You can't just filter them out as
Conan-Kudo commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
Maybe we should just filter out
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
@pmatilai I agree that *.debug
pmatilai commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
res and rc are used pretty much
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
`res` is also used, e.g. in
Conan-Kudo commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
I think it'd be better to restore
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
but I can restore `rc` if it is a
mikhailnov commented on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
rc stands for "return code", res
Conan-Kudo requested changes on this pull request.
> @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags
> pkgFlags,
int didInstall, int test)
{
Package pkg;
-rpmRC rc = RPMRC_OK;
+rpmRC res = RPMRC_OK;
This seems like gratuitous
@mikhailnov pushed 1 commit.
e6eb6a3caa22ae4332433b23c440322d6980ddf1 Print all build errors and do not
stop after the first error
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Example situation:
in the spec file, I had: %{_libdir}/pulse/gsettings-helper and I
got an error that this file had not been found,
but in reality that file existed but in %{_libexecdir}/pulse/gsettings-helper.
I had to _guess_ that it exists. According to RPM log, it was not obvious.
RPM 5
14 matches
Mail list logo