Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-02-02 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; How reliable is it to see if

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-31 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; No. He means that there are cases

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-31 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; Do you mean that not everybode

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-31 Thread Panu Matilainen
pmatilai commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; You can't just filter them out as

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-30 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; Maybe we should just filter out

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-29 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; @pmatilai I agree that *.debug

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-29 Thread Panu Matilainen
pmatilai commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; res and rc are used pretty much

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-29 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; `res` is also used, e.g. in

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; I think it'd be better to restore

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; but I can restore `rc` if it is a

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread mikhailnov
mikhailnov commented on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; rc stands for "return code", res

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. > @@ -3107,7 +3107,7 @@ rpmRC processBinaryFiles(rpmSpec spec, rpmBuildPkgFlags > pkgFlags, int didInstall, int test) { Package pkg; -rpmRC rc = RPMRC_OK; +rpmRC res = RPMRC_OK; This seems like gratuitous

Re: [Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread mikhailnov
@mikhailnov pushed 1 commit. e6eb6a3caa22ae4332433b23c440322d6980ddf1 Print all build errors and do not stop after the first error -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Print all build errors and do not stop after the first error (#1020)

2020-01-28 Thread mikhailnov
Example situation: in the spec file, I had: %{_libdir}/pulse/gsettings-helper and I got an error that this file had not been found, but in reality that file existed but in %{_libexecdir}/pulse/gsettings-helper. I had to _guess_ that it exists. According to RPM log, it was not obvious. RPM 5