Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-21 Thread ニール・ゴンパ
My current guess on how this slips through is that files that are marked as excluded are still being passed to check-files, so it passes the check-files check. But my attempts at trying to make it _not_ do that seem to be in vain... :/ I at least have a test case to see if I fixed it, but so

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-21 Thread Panu Matilainen
The spirit of %exclude always was merely to support sub-packaging, not for leaving random junk in buildroot. But where even the tiniest crack exists, just like water will find its way, so will packagers :smile: -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-20 Thread Kevin Kofler
The current behavior of `%exclude` is a feature and should not be incompatibly changed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-03 Thread Miro Hrončok
This will break a lot of packages in Fedora indeed. For some of my packages I even rely on the behavior, such as here: https://src.fedoraproject.org/rpms/python-xmlschema/blob/a11ca456b41794af7aec847af66f1e7974a698ff/f/python-xmlschema.spec#_59 -- You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-03 Thread Vít Ondruch
It will definitely break something, probably a lot of things. OTOH, it would probably make the things more consistent, e.g. it would avoid issues such as [[1]], because one would need to delete the file instead of excluding it. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=878863 -- You

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-02 Thread Igor Gnatenko
I am predicting this will break multiple packages in Fedora, but I think this would be good behavior. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-02 Thread ニール・ゴンパ
(as for why I'm filing this now... well, I forgot about this in the shuffle two years ago, and I was just reminded of this again today...) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] RFE: %exclude should not permit files to bypass check-files and be omitted from all packages built from spec (#994)

2020-01-02 Thread ニール・ゴンパ
As part of some of the work I've done in OpenMandriva in transitioning the RPM stack from rpm5.org to rpm.org RPM, I've discovered that there was an _interesting_ behavioral difference with `%exclude`. In rpm5.org RPM, `%exclude` does not give you a "get out of jail free" card to bypass the