Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-31 Thread Panu Matilainen
Merged #1027 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1027#event-2996158046___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread Florian Festi
Yup, pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1027#issuecomment-580621471___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread Florian Festi
@ffesti pushed 1 commit. 44ca54c47a35b97245069b9e8d211f5ce7b169b4 Remove --sign from rpmbuild -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread Panu Matilainen
How about this instead: `rpmbuild alias --sign --eval "%{error:rpmbuild --sign is no longer supported. Use the rpmsign command instead!}"` ...which gives you both error on stderr, and a non-zero exit code: ``` $ rpmbuild -bb --sign foo.spec; echo $? error: rpmbuild --sign is no longer

Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread Florian Festi
I tried that but didn't get it to work. I'd also like to swallow the other cli arguments. Looks like the command is executed without a shell so what can be done easily is limited. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1027#pullrequestreview-350867595___

[Rpm-maint] [rpm-software-management/rpm] Remove --sign from rpmbuild (#1027)

2020-01-30 Thread Florian Festi
When splitting rpmsign from rpmbuild this command line parameter was kept as an popt alias. But this limits what other parameter can be passed to the rpmsign command in a difficult to understand way. In the end everyone is better off using the rpmsign command directly. Issue a error message